bug#21597: 25.0.50; Extremely slow redisplay on emacsclient

[Andrew Cohen <cohen@bu.edu>]

I have experienced more or less the same bug. I see the described
behavior when starting emacs in daemon mode (emacs --daemon) and then
connecting with emacsclient. If I start emacs normally, execute
`server-start` , and then connect with emacsclient the problem with
redisplay does not occur.


Following the suggestion to test each hunk in the commit

http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5c9304ea86b8cfc9d0b6d7769b90bd56e5dd1313

I tried reverting hunks one at a time. The only one that made a
difference was this one:


-  if (consider_all_windows_p)
+  if (!consider_all_windows_p)
     {
       FOR_EACH_FRAME (tail, frame)
-	XFRAME (frame)->updated_p = false;
+	{
+	  if (XFRAME (frame)->redisplay && XFRAME (frame) != sf)
+	    {
+	      consider_some_frames_p = true;
+	      break;
+	    }
+	}
+    }
+
+  if (consider_all_windows_p || consider_some_frames_p)
+    {
+      FOR_EACH_FRAME (tail, frame)
+	{
+	  if (XFRAME (frame)->redisplay || consider_all_windows_p)
+	    XFRAME (frame)->updated_p = false;
+	}

Reverting this solved the problem for me.