From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Apparent regression on the undo command Date: Mon, 23 Nov 2015 17:27:37 +0000 Message-ID: <87wpt8aanq.fsf@russet.org.uk> References: <87bnarsdfy.fsf@russet.org.uk> <871tbm9v83.fsf@russet.org.uk> <87wpte6slz.fsf@russet.org.uk> <87io4xpio3.fsf@red-bean.com> <87y4drllg8.fsf@russet.org.uk> <1512E415-81ED-4C4D-B03E-4ED0EE29D34C@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448299685 7774 80.91.229.3 (23 Nov 2015 17:28:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Nov 2015 17:28:05 +0000 (UTC) Cc: 21968@debbugs.gnu.org, emacs-devel To: David Reitter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 23 18:27:57 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0uuB-0007l2-Ck for ged-emacs-devel@m.gmane.org; Mon, 23 Nov 2015 18:27:55 +0100 Original-Received: from localhost ([::1]:33707 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0uuC-0005b0-1z for ged-emacs-devel@m.gmane.org; Mon, 23 Nov 2015 12:27:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0utz-0005MS-GN for emacs-devel@gnu.org; Mon, 23 Nov 2015 12:27:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0utv-0004MW-Iu for emacs-devel@gnu.org; Mon, 23 Nov 2015 12:27:43 -0500 Original-Received: from cheviot22.ncl.ac.uk ([128.240.234.22]:38377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0utv-0004M1-9v for emacs-devel@gnu.org; Mon, 23 Nov 2015 12:27:39 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot22.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1a0utt-0000cV-Ey; Mon, 23 Nov 2015 17:27:37 +0000 Original-Received: from jangai.ncl.ac.uk ([10.66.67.223] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1a0utt-0002PG-Gu; Mon, 23 Nov 2015 17:27:37 +0000 In-Reply-To: <1512E415-81ED-4C4D-B03E-4ED0EE29D34C@gmail.com> (David Reitter's message of "Sat, 21 Nov 2015 19:55:22 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195126 Archived-At: Okay, am working on this now! David Reitter writes: > Phil, > > I tried your fix. It works for backward-kill-word, but for kill-word > (forward), the cursor ends up in the wrong place (after the word, not where it > was initially). > > - David > > >> On Nov 21, 2015, at 6:18 AM, Artur Malabarba wrote: >> >> I can't speak for the code, but I just tested your fix and looks like it works. >> >> Thanks Phil. >> >> 2015-11-21 10:02 GMT+00:00 Phillip Lord : >> >> I have a possible fix for this now, currently on the >> branch fix/undo-point-in-wrong-place. I waiting for some other feedback >> on my code before I squash and merge it, but if you have the chance it >> would be good to know if it works. >> >> Phil >> >> >> Artur Malabarba writes: >> >> > No problem Phil. >> > Thanks for looking into this. >> > On 20 Nov 2015 7:51 am, "Phillip Lord" wrote: >> > >> >> >> >> It is my commit after all. I will work on it as soon as I can. Had a nasty >> >> cold for the last few days. >> >> >> >> Phil >> >> ________________________________________ >> >> From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org >> >> [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of >> >> Karl Fogel [kfogel@red-bean.com] >> >> Sent: 20 November 2015 01:24 >> >> To: Phillip Lord >> >> Cc: Artur Malabarba; emacs-devel >> >> Subject: Re: Apparent regression on the undo command >> >> >> >> phillip.lord@russet.org.uk (Phillip Lord) writes: >> >> >Artur Malabarba writes: >> >> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord : >> >> >>> I'll try and see if I can automate the problem and >> >> >>> run a bisect. >> >> >> >> >> >> The following works for me. When called on the *scratch* buffer it >> >> >> returns non-nil if the problem occurs. >> >> >> >> >> >> (progn >> >> >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) >> >> >> (equal (point-min) (point))) >> >> >> >> >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ >> >> > >> >> > >> >> >I tried various combinations -- works interactively but fails in batch >> >> >either because *scratch* hasn't been initialized, or undo appears to >> >> >work wrongly. >> >> > >> >> >No worries, it's easy enough to test by hand, and am doing so. >> >> >> >> Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from >> >> commit c210b8b128c. >> >> >> >> Best regards, >> >> -Karl >> >> >> >> >>