From: phillip.lord@russet.org.uk (Phillip Lord)
To: David Reitter <david.reitter@gmail.com>
Cc: 21968@debbugs.gnu.org, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Apparent regression on the undo command
Date: Mon, 23 Nov 2015 17:27:37 +0000 [thread overview]
Message-ID: <87wpt8aanq.fsf@russet.org.uk> (raw)
In-Reply-To: <1512E415-81ED-4C4D-B03E-4ED0EE29D34C@gmail.com> (David Reitter's message of "Sat, 21 Nov 2015 19:55:22 -0500")
Okay, am working on this now!
David Reitter <david.reitter@gmail.com> writes:
> Phil,
>
> I tried your fix. It works for backward-kill-word, but for kill-word
> (forward), the cursor ends up in the wrong place (after the word, not where it
> was initially).
>
> - David
>
>
>> On Nov 21, 2015, at 6:18 AM, Artur Malabarba <bruce.connor.am@gmail.com> wrote:
>>
>> I can't speak for the code, but I just tested your fix and looks like it works.
>>
>> Thanks Phil.
>>
>> 2015-11-21 10:02 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>:
>>
>> I have a possible fix for this now, currently on the
>> branch fix/undo-point-in-wrong-place. I waiting for some other feedback
>> on my code before I squash and merge it, but if you have the chance it
>> would be good to know if it works.
>>
>> Phil
>>
>>
>> Artur Malabarba <bruce.connor.am@gmail.com> writes:
>>
>> > No problem Phil.
>> > Thanks for looking into this.
>> > On 20 Nov 2015 7:51 am, "Phillip Lord" <phillip.lord@newcastle.ac.uk> wrote:
>> >
>> >>
>> >> It is my commit after all. I will work on it as soon as I can. Had a nasty
>> >> cold for the last few days.
>> >>
>> >> Phil
>> >> ________________________________________
>> >> From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org
>> >> [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of
>> >> Karl Fogel [kfogel@red-bean.com]
>> >> Sent: 20 November 2015 01:24
>> >> To: Phillip Lord
>> >> Cc: Artur Malabarba; emacs-devel
>> >> Subject: Re: Apparent regression on the undo command
>> >>
>> >> phillip.lord@russet.org.uk (Phillip Lord) writes:
>> >> >Artur Malabarba <bruce.connor.am@gmail.com> writes:
>> >> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>:
>> >> >>> I'll try and see if I can automate the problem and
>> >> >>> run a bisect.
>> >> >>
>> >> >> The following works for me. When called on the *scratch* buffer it
>> >> >> returns non-nil if the problem occurs.
>> >> >>
>> >> >> (progn
>> >> >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911])
>> >> >> (equal (point-min) (point)))
>> >> >>
>> >> >> That macro simply calls M-< C-k C-n C-n C-k C-/
>> >> >
>> >> >
>> >> >I tried various combinations -- works interactively but fails in batch
>> >> >either because *scratch* hasn't been initialized, or undo appears to
>> >> >work wrongly.
>> >> >
>> >> >No worries, it's easy enough to test by hand, and am doing so.
>> >>
>> >> Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from
>> >> commit c210b8b128c.
>> >>
>> >> Best regards,
>> >> -Karl
>> >>
>> >>
>>
next prev parent reply other threads:[~2015-11-23 17:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 11:50 Apparent regression on the undo command Artur Malabarba
2015-11-18 12:24 ` Phillip Lord
2015-11-18 13:16 ` Artur Malabarba
2015-11-19 9:47 ` Phillip Lord
2015-11-19 12:11 ` Artur Malabarba
2015-11-19 13:12 ` Phillip Lord
2015-11-20 1:24 ` Karl Fogel
2015-11-20 7:51 ` Phillip Lord
2015-11-20 10:06 ` Artur Malabarba
2015-11-21 10:02 ` Phillip Lord
2015-11-21 11:18 ` Artur Malabarba
2015-11-22 0:55 ` bug#21968: " David Reitter
2015-11-22 0:55 ` David Reitter
2015-11-23 17:27 ` bug#21968: " Phillip Lord
2015-11-23 17:27 ` Phillip Lord [this message]
2015-12-14 20:04 ` John Wiegley
2015-12-14 20:09 ` Eli Zaretskii
2015-12-14 21:28 ` Phillip Lord
2015-12-14 22:05 ` John Wiegley
2015-12-14 22:30 ` Phillip Lord
2015-12-14 22:34 ` John Wiegley
2015-12-15 9:31 ` Phillip Lord
2015-12-15 15:06 ` John Wiegley
2015-11-18 22:50 ` Markus Triska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpt8aanq.fsf@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=21968@debbugs.gnu.org \
--cc=david.reitter@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.