From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: Dynamic modules: emacs-module.c and signaling errors Date: Tue, 24 Nov 2015 13:12:30 -0700 Message-ID: <87wpt7p369.fsf@tromey.com> References: <83k2p7xk13.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448395998 15693 80.91.229.3 (24 Nov 2015 20:13:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Nov 2015 20:13:18 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, Philipp Stephani , dancol@dancol.org, tzz@lifelogs.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 24 21:13:05 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a1JxY-0007gt-1i for ged-emacs-devel@m.gmane.org; Tue, 24 Nov 2015 21:13:04 +0100 Original-Received: from localhost ([::1]:41177 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1JxZ-0003WT-FE for ged-emacs-devel@m.gmane.org; Tue, 24 Nov 2015 15:13:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1JxM-0003WJ-33 for emacs-devel@gnu.org; Tue, 24 Nov 2015 15:12:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1JxI-0007CG-SO for emacs-devel@gnu.org; Tue, 24 Nov 2015 15:12:52 -0500 Original-Received: from gproxy1-pub.mail.unifiedlayer.com ([69.89.25.95]:51128) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1a1JxI-0007Bw-Ju for emacs-devel@gnu.org; Tue, 24 Nov 2015 15:12:48 -0500 Original-Received: (qmail 6328 invoked by uid 0); 24 Nov 2015 20:12:41 -0000 Original-Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy1.mail.unifiedlayer.com with SMTP; 24 Nov 2015 20:12:41 -0000 Original-Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id lYCZ1r00D2f2jeq01YCcAs; Tue, 24 Nov 2015 13:12:40 -0700 X-Authority-Analysis: v=2.1 cv=VOBOwb/X c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=zstS-IiYAAAA:8 a=PnD2wP_eR3oA:10 a=q5Y1GWT81MIA:10 a=qtqOOiqGOCEA:10 a=mDV3o1hIAAAA:8 a=AY2N82vd0PTHtPmTd7IA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=mkrSZDAGauMrNoWCH3Ll880wIQMlYOXzT4CDsTeUHMg=; b=Aj2EK0Jwavz1Q4MGzoV1dMxbq3A6ylLaxFo7iqzs0sKXvOr+EfrOeIJ3vzYtDIBvF/zhtNDs80woBcR9JON1uYShEKZj3Zj9JJkHug2o/BUG6R61Vg3mEwTSdTXofdTh; Original-Received: from [174.16.156.173] (port=56544 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.84) (envelope-from ) id 1a1Jx4-0005qG-4s; Tue, 24 Nov 2015 13:12:34 -0700 X-Attribution: Tom In-Reply-To: <83k2p7xk13.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 24 Nov 2015 21:41:12 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 174.16.156.173 authed with tom+tromey.com} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 69.89.25.95 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195186 Archived-At: >>>>> "Eli" == Eli Zaretskii writes: Eli> Since this obviously works as it was designed, my question is: how Eli> should a module be written so that this kind of errors signal a normal Eli> Lisp error we are accustomed with Emacs primitives? What I did in my module is do an error check after every call in to Emacs, returning early when one is seen. Then eventually control returns to Fmodule_call, which handles translating this to a Lisp signal. The module in question isn't doing this check after calling extract_integer, but it should. Tom