From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 75336a2: Merge branch 'feature/standard-test-location' Date: Thu, 03 Dec 2015 17:31:12 +0000 Message-ID: <87wpsvo2vz.fsf@russet.org.uk> References: <20151126211432.7647.1395@vcs.savannah.gnu.org> <5659F8CC.2070106@yandex.ru> <87d1uukk29.fsf@russet.org.uk> <565A0931.8010502@yandex.ru> <874mg5lt2u.fsf@russet.org.uk> <565A7C13.6080807@yandex.ru> <87y4dga4n2.fsf@russet.org.uk> <86k2oysknp.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1449163921 6777 80.91.229.3 (3 Dec 2015 17:32:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Dec 2015 17:32:01 +0000 (UTC) Cc: emacs-devel@gnu.org, Dmitry Gutov To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 03 18:32:00 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a4Xjb-00038m-A6 for ged-emacs-devel@m.gmane.org; Thu, 03 Dec 2015 18:31:59 +0100 Original-Received: from localhost ([::1]:36672 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4Xja-0006Us-Fj for ged-emacs-devel@m.gmane.org; Thu, 03 Dec 2015 12:31:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4Xj1-0005yZ-0N for emacs-devel@gnu.org; Thu, 03 Dec 2015 12:31:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4Xiw-0001OP-DP for emacs-devel@gnu.org; Thu, 03 Dec 2015 12:31:22 -0500 Original-Received: from cheviot12.ncl.ac.uk ([128.240.234.12]:53113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4Xiw-0001Kx-0w for emacs-devel@gnu.org; Thu, 03 Dec 2015 12:31:18 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot12.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1a4Xiq-0004xg-CB; Thu, 03 Dec 2015 17:31:12 +0000 Original-Received: from jangai.ncl.ac.uk ([10.66.67.223] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1a4Xiq-0005RR-4j; Thu, 03 Dec 2015 17:31:12 +0000 In-Reply-To: <86k2oysknp.fsf@stephe-leake.org> (Stephen Leake's message of "Tue, 1 Dec 2015 01:16:58 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195819 Archived-At: Stephen Leake writes: > phillip.lord@russet.org.uk (Phillip Lord) writes: > >>> The .el extension points to emacs-lisp-mode already, doesn't it? >> >> Then you are testing two things: auto-mode-alist *and* indentation. > > Yes. But that's a Good Thing. > > And it will significantly reduce perceived "noise" in the test sources, > which is also a Good Thing. > > The need to set the mode via a local variable documents that you are not > expecting auto-mode-alist to handle it. I think that you are partly right about this, although, of course, you are assuming that indentation tests WILL be in files. As is stands sisyphus does not make this assumption -- it's possible to drop code inline into tests also. There are advantages to this for short pieces of code. Still, you are correct -- auto-mode-alist should be usable if wanted. >>> Have you considered just adding a few functions to ert-x? As a first step, I >>> mean. >> >> Not yet, no. I wanted to get something working and useful first. The >> problem with adding it to ert-x is that it's core, and I think I'd >> rather have it in ELPA in the short term. > > I think "it" here is your new test macros, that make it easier to write > indentation tests? > > They are useful for testing core code, so they should be in core. At > least until we get "core ELPA" packages working; then this would be a > candidate for moving to Gnu ELPA. > > Putting them in a separate package for now probably makes sense; once > they are fully polished we can decide if they should be in ert or ert-x. I'd agree with all this also. I think that my packages will be good for testing core. I'm not making any decisions till I find out how long it takes me write. Maybe "core ELPA" will be working by then. Who knows! Phil