From: David Kastrup <dak@gnu.org>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: Glenn Morris <rgm@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: builds are getting slower?
Date: Thu, 10 Dec 2015 09:57:23 +0100 [thread overview]
Message-ID: <87wpsm4r64.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <CAAdUY-L2Dkue--wBPpLSttzW=c3NpL3zfGZqCzHLb7pdSO6OdQ@mail.gmail.com> (Artur Malabarba's message of "Thu, 10 Dec 2015 08:14:30 +0000")
Artur Malabarba <bruce.connor.am@gmail.com> writes:
> On 10 Dec 2015 6:53 am, "Paul Eggert" <eggert@cs.ucla.edu> wrote:
>> There's a larger performance hit between 20151109 and 20151110. The log
> for that time period (0730 Pacific cutoff) is attached as log2.txt.
> Nothing jumps out, I'm afraid.
>>
>
> In one of my commis there I think I added (require 'map) to files.el, but I
> don't think the impact of that would be so noticeable.
If that _replaces_ some builtins by more generic stuff, that could
explain some of it.
> There's another commit there which could affect performance (it talks about
> not using XFASTINT, in a function that is used a bajillion times throughout
> core). It's this one by Eli.
>
> commit 86c19714b097aa477d339ed99ffb5136c755a046
> Author: Eli Zaretskii <eliz@gnu.org>
> AuthorDate: Mon Nov 9 10:31:45 2015
> Commit: Eli Zaretskii <eliz@gnu.org>
> CommitDate: Mon Nov 9 10:31:45 2015
>
> Fix assertion violation in define-key
>
> * src/keymap.c (store_in_keymap): Don't use XFASTINT on non-character
> objects. Reported by Drew Adams <drew.adams@oracle.com>
> and Juanma Barranquero <lekktu@gmail.com>.
I doubt it is this one. It may be used "bajillion times" throughout the
core, but as a rule not in a loop. So XFASTINT may be replaced by XINT
(or whatever) a few ten thousands of times. That should not be enough
to cause a significant difference.
--
David Kastrup
next prev parent reply other threads:[~2015-12-10 8:57 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 2:15 builds are getting slower? Glenn Morris
2015-12-10 2:41 ` Paul Eggert
2015-12-10 3:51 ` Glenn Morris
2015-12-10 6:53 ` Paul Eggert
2015-12-10 8:14 ` Artur Malabarba
2015-12-10 8:57 ` David Kastrup [this message]
2015-12-10 16:16 ` Eli Zaretskii
2015-12-10 17:27 ` Glenn Morris
2015-12-13 6:10 ` Paul Eggert
2015-12-13 21:53 ` Glenn Morris
2015-12-13 23:53 ` Glenn Morris
2015-12-14 3:31 ` Eli Zaretskii
2015-12-14 22:20 ` John Wiegley
2015-12-14 23:40 ` Paul Eggert
2015-12-15 0:38 ` John Wiegley
2015-12-15 8:13 ` Michael Albinus
2016-01-03 20:02 ` mark expensive tests (was: builds are getting slower?) Michael Albinus
2016-01-03 20:09 ` mark expensive tests John Wiegley
2016-01-03 20:40 ` Paul Eggert
2016-01-03 21:08 ` John Wiegley
2016-01-03 21:43 ` Paul Eggert
2016-01-03 21:45 ` John Wiegley
2016-01-04 3:18 ` Richard Stallman
2016-01-04 3:34 ` Paul Eggert
2016-01-04 8:16 ` Michael Albinus
2016-01-04 15:24 ` Paul Eggert
2016-01-04 15:31 ` Michael Albinus
2016-01-04 15:34 ` Dmitry Gutov
2016-01-04 15:43 ` Michael Albinus
2016-01-07 22:14 ` Phillip Lord
2016-01-08 8:58 ` Eli Zaretskii
2016-01-08 20:42 ` Achim Gratz
2016-01-09 0:21 ` John Wiegley
2016-01-09 12:09 ` Achim Gratz
2016-01-12 16:55 ` Simon Michael
2016-01-09 0:21 ` John Wiegley
2016-01-04 15:49 ` Eli Zaretskii
2016-01-04 15:48 ` Eli Zaretskii
2016-01-04 16:50 ` Paul Eggert
2016-01-04 17:18 ` Eli Zaretskii
2016-01-04 17:56 ` Paul Eggert
2016-01-04 15:47 ` Eli Zaretskii
2016-01-04 16:19 ` Michael Albinus
2016-01-04 16:51 ` Eli Zaretskii
2016-01-04 17:01 ` Michael Albinus
2016-01-04 17:23 ` Eli Zaretskii
2016-01-04 17:55 ` Michael Albinus
2016-01-04 22:30 ` Michael Albinus
2015-12-15 13:12 ` builds are getting slower? Phillip Lord
2015-12-15 8:18 ` Glenn Morris
2015-12-15 12:38 ` Artur Malabarba
2015-12-15 12:49 ` David Kastrup
2015-12-15 16:15 ` Eli Zaretskii
2015-12-16 11:50 ` Artur Malabarba
2015-12-16 11:58 ` Eli Zaretskii
2015-12-16 13:09 ` Artur Malabarba
2015-12-16 13:25 ` David Kastrup
2015-12-16 13:53 ` Eli Zaretskii
2015-12-17 2:11 ` Glenn Morris
2015-12-17 16:06 ` John Wiegley
2016-01-16 8:55 ` Artur Malabarba
2016-01-19 22:55 ` Glenn Morris
2016-01-20 0:04 ` Artur Malabarba
2016-01-26 1:46 ` Artur Malabarba
2016-01-26 18:52 ` Glenn Morris
2016-01-26 19:24 ` Stefan Monnier
2016-01-26 19:40 ` John Wiegley
2016-01-26 20:15 ` Artur Malabarba
2016-01-26 22:23 ` Paul Eggert
2016-01-29 1:29 ` John Wiegley
[not found] ` <CAAdUY-KaYN5L8wAyFpUYL=dVG2twMYQk4+iBH_cpW2fyMaHOow@mail.gmail.com>
2016-01-29 11:46 ` Artur Malabarba
2015-12-17 2:13 ` Glenn Morris
2015-12-15 19:25 ` Glenn Morris
2015-12-15 19:40 ` David Kastrup
-- strict thread matches above, loose matches on Subject: below --
2015-12-15 14:23 Pádraig Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpsm4r64.fsf@fencepost.gnu.org \
--to=dak@gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.