From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#19401: 25.0.50; metar.el (metar-convert-temperature) wrong type argument stringp nil Date: Tue, 29 Dec 2015 15:26:49 -0500 Message-ID: <87wprx57cm.fsf@udel.edu> References: <87oar2x9is.fsf@udel.edu> <87egrx1162.fsf@web.de> <87egrxqaeb.fsf@udel.edu> <87a92k28rk.fsf@web.de> <85mw5m91um.fsf@iznogoud.viz> <85sifem7yq.fsf@iznogoud.viz> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451420844 15641 80.91.229.3 (29 Dec 2015 20:27:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Dec 2015 20:27:24 +0000 (UTC) To: 19401@debbugs.gnu.org, Mario Lang , Wolfgang Jenkner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 29 21:27:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aE0rQ-0007Hy-OO for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Dec 2015 21:27:12 +0100 Original-Received: from localhost ([::1]:49998 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aE0rP-00062f-Ua for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Dec 2015 15:27:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aE0rL-00062W-HE for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2015 15:27:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aE0rG-0003HT-GQ for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2015 15:27:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aE0rG-0003HP-CP for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2015 15:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aE0rG-0001Js-1F for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2015 15:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Dec 2015 20:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19401 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19401-submit@debbugs.gnu.org id=B19401.14514208205065 (code B ref 19401); Tue, 29 Dec 2015 20:27:01 +0000 Original-Received: (at 19401) by debbugs.gnu.org; 29 Dec 2015 20:27:00 +0000 Original-Received: from localhost ([127.0.0.1]:48935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aE0rE-0001Jd-I0 for submit@debbugs.gnu.org; Tue, 29 Dec 2015 15:27:00 -0500 Original-Received: from mail-qk0-f171.google.com ([209.85.220.171]:33922) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aE0rC-0001JO-G6 for 19401@debbugs.gnu.org; Tue, 29 Dec 2015 15:26:59 -0500 Original-Received: by mail-qk0-f171.google.com with SMTP id p187so207413078qkd.1 for <19401@debbugs.gnu.org>; Tue, 29 Dec 2015 12:26:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=3F2LIKRXCX7beM2AfHvsLSB4l2TqZdnuQ1lxXIWnYJc=; b=wwStez+zElju72VZGIiMhSPxUMLUPzRc9bABDrDaGHoqtzeg9YTi4X72zgGZ1i8hTJ 51Ds7/PpCsRKtQ94yaHDoWwquvAaJPvgG1PgCHKfpPdwf98+9NI0w2Zi5WfrRhdSTScl aWULHHrXuW+uyPoCCCoj+I5jynDwrGnNI6QAQMbl9YRdy/HuSWC8I1CaF5+8mY4+zSog 7VbJPXxBoNMutkKo3tHj+S45O+B88iR3DRdHfl/SzeixJP0Y7nXIqGjfwHLgJxtQuiBZ 0Mxo9AdZK2k/bcdGQj4i9Z5QzOU52Ks5cbwf+/y3VOfKL/8WPcuiBnXzx88KB8Hb5QsI 9vUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=3F2LIKRXCX7beM2AfHvsLSB4l2TqZdnuQ1lxXIWnYJc=; b=iQeANrzxf96ZLvJBOuHCxqLgkc/8z5MNlkYgpycYVGnePVcVMlsrR/JLlsL9meRq5B A0/LKot8vYvhqNN4EkWM6so41ijYuGXSztgS6pxUbcml9saPX5vhawmHL9imuTM24qdH kiS73gFawzXcdXyA2lu1Oo7uGwY9cPUh4s9aS4XnqsANE5cJ/e/v2MEXa4e5JCvf3buo mdn6N9J3HQpU01Ze+s+91BTEUzKylGbAVk9JwfjnBdFgZMNdpuWhf+dfYMNamLLcEaV/ Afs38fNLTojzki0MK3arZLYaDghZTR5oSxTJ41dGLC2YQIBGYhFq1hO9+NtmJVg/XWPC TF1A== X-Gm-Message-State: ALoCoQmiJUzJxvYxP3RPO0hwDRdvgzsE2jiii6MZG0HmQRJxtrONU/9IjWZE9w3wuZWUKbz+raKbSbHfvT1hoctVUi3Phrq3tA== X-Received: by 10.55.82.193 with SMTP id g184mr81636465qkb.65.1451420813111; Tue, 29 Dec 2015 12:26:53 -0800 (PST) Original-Received: from holos.localdomain (c-73-172-248-173.hsd1.md.comcast.net. [73.172.248.173]) by smtp.gmail.com with ESMTPSA id a197sm10426461qhc.25.2015.12.29.12.26.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Dec 2015 12:26:51 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 49A7069D61; Tue, 29 Dec 2015 15:26:49 -0500 (EST) In-Reply-To: <85sifem7yq.fsf@iznogoud.viz> (Wolfgang Jenkner's message of "Wed, 14 Jan 2015 02:47:28 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110980 Archived-At: Wolfgang Jenkner writes: > On Tue, Jan 13 2015, Wolfgang Jenkner wrote: > >> Please note that this patch assumes that the patch from (Bug#19582) has >> been applied. > > Actually, the following patch (on top of the last one) might be enough > for metar to avoid the need for that fix from bug#19582, and so to > remain compatible with older (than the future trunk ;-) emacs versions. > >>>From ad084a9b35e79f3524e4ef01137cf256c0509266 Mon Sep 17 00:00:00 2001 > From: Wolfgang Jenkner > Date: Wed, 14 Jan 2015 02:31:01 +0100 > Subject: [PATCH] [metar] Add a work-around for bug#19582. > > * packages/metar/metar.el (metar-convert-unit): Rewrite expr if it > starts with the `neg' operator. Technically, this is wrong because > various functions in calc-units expect already simplified > expressions. In practice, it should work around the above bug. > --- > packages/metar/metar.el | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/packages/metar/metar.el b/packages/metar/metar.el > index 9575313..a05a353 100644 > --- a/packages/metar/metar.el > +++ b/packages/metar/metar.el > @@ -249,6 +249,9 @@ It must have the signature of `math-convert-units', which is the default." > (unless (symbolp new-unit) > (setq new-unit (intern new-unit))) > (let ((expr (math-simplify (math-read-expr value)))) > + ;; Sneakily work around bug#19582. > + (when (eq (car-safe expr) 'neg) > + (setq expr `(* -1 ,(cadr expr)))) > (cl-assert (or (math-zerop expr) > (not (memq (math-single-units-in-expr-p expr) '(nil wrong)))) > nil It looks to me that the patch in bug#19401 that Wolfgang's patches depend on has been applied some time ago. I find the issue in emacs 24 and 25 to be fixed with both metar.el patches applied.