From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: Recommend these .gitconfig settings for git integrity. Date: Mon, 01 Feb 2016 09:42:51 -0600 Message-ID: <87wpqo77yc.fsf@red-bean.com> References: <87a8nlfqj9.fsf@red-bean.com> <83h9ht1o8q.fsf@gnu.org> <87mvrle8ho.fsf@red-bean.com> <56AE8126.9090708@cs.ucla.edu> Reply-To: Karl Fogel NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1454341407 21470 80.91.229.3 (1 Feb 2016 15:43:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Feb 2016 15:43:27 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 01 16:43:13 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aQGdE-0003FJ-4o for ged-emacs-devel@m.gmane.org; Mon, 01 Feb 2016 16:43:12 +0100 Original-Received: from localhost ([::1]:52936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQGdD-000729-Az for ged-emacs-devel@m.gmane.org; Mon, 01 Feb 2016 10:43:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQGd0-000723-3t for emacs-devel@gnu.org; Mon, 01 Feb 2016 10:42:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQGcw-0004IE-P6 for emacs-devel@gnu.org; Mon, 01 Feb 2016 10:42:58 -0500 Original-Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]:36673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQGcw-0004I5-Jd; Mon, 01 Feb 2016 10:42:54 -0500 Original-Received: by mail-io0-x236.google.com with SMTP id g73so162527642ioe.3; Mon, 01 Feb 2016 07:42:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=jEGgU+1iWRcteA+fGdNA5jQAkFgZJODF5yhQhhYaQfY=; b=WoModKcAoveIbThvnPFPzRPM1AEy8epJ87qKCp292Or1QZLAEU3nNh3tglLpW9638I v5jv4XqIJtik8zJFNdKB9lzX7Ax60WpQJDVMvWhbarm76tQ52nE+9lc5oftxy2HfbDOL POGcZiXdFjtwanUPgiGIgdoOG4Ow3xZ15Fw42mKR/qUKXtSMCSk0DBpknvMoWmSqQiQ8 GaK+yoXwKFqiSWrIrPo4oRPVcvPAJN7ozvkxGitWi0wkqwbpCAtvghBE3vOQBlwpTqRw ooqaJbHzUimBQr8izvqbLMKx3Qk2+F2bIjeSgnJ0fZsRX5qmiFFeyIpmPLicgF3tPTA3 zmbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:reply-to :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=jEGgU+1iWRcteA+fGdNA5jQAkFgZJODF5yhQhhYaQfY=; b=lZ6xSRvpq11Gzhi9XKiCydF8L3ncTTr3xbFtK8weB95nH4Wzn4hy8Z2d1Di10/tFbY Hya/XnOrssT0Z/cEb/X5aQmpbaggLvGv0k8pqYNX8lGmnDoyAr/u52Mggt2Z+CcU7fPZ L1tqt3fWEx7fVDSd0LRQ4j91Oxw9staMTfaAFhuayNoujB/2p3Amczl+U5x6RH/qQzcZ /6Z16FnxIYT7IFRH9g6VJGQk1PJZmUYweOCpW9DG9W+fcurcfjEkgfvPPqJnk3AxHqqW SHEXtNkP7Pz9kGHLKxIS0T4BHH7HZTVlCgnWyTD7/ETCnMIkWaXp0rIPlmndCeG9Q68m Hbog== X-Gm-Message-State: AG10YOStqIUTfw9EFgb2Y/j1Gt1KCMmnzigY2otYpE8lsqOICwibWDEzhVDskkYrwXbTXA== X-Received: by 10.107.5.209 with SMTP id 200mr23689618iof.193.1454341373897; Mon, 01 Feb 2016 07:42:53 -0800 (PST) Original-Received: from floss (74-92-190-114-Illinois.hfc.comcastbusiness.net. [74.92.190.114]) by smtp.gmail.com with ESMTPSA id ee9sm4502884igb.7.2016.02.01.07.42.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Feb 2016 07:42:52 -0800 (PST) In-Reply-To: <56AE8126.9090708@cs.ucla.edu> (Paul Eggert's message of "Sun, 31 Jan 2016 13:48:22 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c06::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199122 Archived-At: Quoting Paul Eggert out of order: >I installed the attached patch to try to automate this; I think >this'll be more effective. *nod* That has autogen.sh install the setting in the repository-specific git config. That's a good a companion to also including the advice in admin/notes/git-workflow and http://www.emacswiki.org/emacs/GitForEmacsDevs, but by itself it's not enough, I think. It only takes effect after the user runs autogen.sh, so she might have pulled an arbitrary number of times before the setting gets put in place by autogen.sh. >We shouldn't need to configure fetch.fsckObjects and >receive.fsckObjects, as they default to transfer.fsckObjects. Yeah... Hmmm. I think Eric Myhre's post recommending all three setting was his too-simple-to-fail way of making sure that users didn't have a combination whereby transfer.fsckObjects=true was overridden by one or both of fetch.fsckObjects=false or receive.fsckObjects=false. Anyway, we seem to have consensus that the intended resultant setting is a good one. So I'll add the advice to the above file and wiki page, and will find some way to express the desired result without asking the user to make redundant settings. Best regards, -Karl >>>From b1ccd481738b1427ac0e294f2405a9ebe86c8561 Mon Sep 17 00:00:00 2001 >From: Paul Eggert >Date: Sun, 31 Jan 2016 13:43:13 -0800 >Subject: [PATCH] autogen.sh now arranges for git to check hashes > >Suggested by Karl Fogel in: >http://lists.gnu.org/archive/html/emacs-devel/2016-01/msg01802.html >* autogen.sh: Do "git config transfer.fsckObjects true". >--- > autogen.sh | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/autogen.sh b/autogen.sh >index a63c53c..877bb84 100755 >--- a/autogen.sh >+++ b/autogen.sh >@@ -220,6 +220,11 @@ echo timestamp > src/stamp-h.in || exit > ## Configure Git, if using Git. > if test -d .git && (git status -s) >/dev/null 2>&1; then > >+ # Check hashes when transferring objects among repositories. >+ >+ git config transfer.fsckObjects true || exit >+ >+ > # Configure 'git diff' hunk header format. > > git config 'diff.elisp.xfuncname' \