From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.bugs Subject: bug#19559: 24.3; C-n in doc-view-mode Date: Mon, 14 Mar 2016 11:20:48 +0100 Message-ID: <87wpp5uzr3.fsf@mbork.pl> References: <87r3v2ifs5.fsf@robertthorpeconsulting.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1457950888 9742 80.91.229.3 (14 Mar 2016 10:21:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Mar 2016 10:21:28 +0000 (UTC) Cc: 19559@debbugs.gnu.org To: Robert Thorpe Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 14 11:21:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1afPcb-0002XD-EE for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Mar 2016 11:21:09 +0100 Original-Received: from localhost ([::1]:39963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afPca-0001TB-Ho for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Mar 2016 06:21:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afPcW-0001T6-Uq for bug-gnu-emacs@gnu.org; Mon, 14 Mar 2016 06:21:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afPcU-0005am-7k for bug-gnu-emacs@gnu.org; Mon, 14 Mar 2016 06:21:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afPcU-0005ai-3O for bug-gnu-emacs@gnu.org; Mon, 14 Mar 2016 06:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1afPcT-0007qH-Vz for bug-gnu-emacs@gnu.org; Mon, 14 Mar 2016 06:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Marcin Borkowski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Mar 2016 10:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19559-submit@debbugs.gnu.org id=B19559.145795085830124 (code B ref 19559); Mon, 14 Mar 2016 10:21:01 +0000 Original-Received: (at 19559) by debbugs.gnu.org; 14 Mar 2016 10:20:58 +0000 Original-Received: from localhost ([127.0.0.1]:47471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1afPcP-0007po-Q3 for submit@debbugs.gnu.org; Mon, 14 Mar 2016 06:20:57 -0400 Original-Received: from mail.mojserwer.eu ([195.110.48.8]:56952) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1afPcN-0007pf-Gb for 19559@debbugs.gnu.org; Mon, 14 Mar 2016 06:20:56 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 607C6A075F4; Mon, 14 Mar 2016 11:20:54 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1sAgGLyRdPoT; Mon, 14 Mar 2016 11:20:52 +0100 (CET) Original-Received: from localhost (98-171.echostar.pl [213.156.98.171]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 4E039A075F3; Mon, 14 Mar 2016 11:20:52 +0100 (CET) In-Reply-To: <87r3v2ifs5.fsf@robertthorpeconsulting.com> (Robert Thorpe's message of "Sat, 10 Jan 2015 19:42:18 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114888 Archived-At: --=-=-= Content-Type: text/plain Hello, I attach a patch prepared using git-format-patch. It's my first patch for Emacs, so please let me know if I did it correctly (especially wrt the commit message). Best, -- Marcin --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-bug-19559.patch >From 0f616d9501a5bd56381a4e8198816d2f26b6ae9e Mon Sep 17 00:00:00 2001 From: Marcin Borkowski Date: Mon, 14 Mar 2016 11:15:10 +0100 Subject: [PATCH] Fix bug #19559 The function `doc-view-next-line-or-next-page' disregarded its argument when continuous scrolling was not in effect (i.e., by default). --- lisp/doc-view.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 9d912c3..223565c 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -626,7 +626,7 @@ doc-view-next-line-or-next-page (image-bob) (image-bol 1)) (set-window-hscroll (selected-window) hscroll))) - (image-next-line 1))) + (image-next-line arg))) (defun doc-view-previous-line-or-previous-page (&optional arg) "Scroll downward by ARG lines if possible, else goto previous page. -- 2.4.3 --=-=-=--