From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24133: 25.1.50; Some checkdoc.el functions use call-interactively incorrectly Date: Fri, 26 Aug 2016 22:58:59 -0400 Message-ID: <87wpj2syrw.fsf@users.sourceforge.net> References: <2eb6d6f3-09e8-093b-568f-634dced3fcd6@gmail.com> <87bn0oqlk7.fsf@cochranmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1472266765 7056 195.159.176.226 (27 Aug 2016 02:59:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 Aug 2016 02:59:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: Matthew Malcomson , 24133@debbugs.gnu.org To: Robert Cochran Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 27 04:59:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdTq0-0000yg-73 for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Aug 2016 04:59:16 +0200 Original-Received: from localhost ([::1]:34511 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdTpx-00078u-Mx for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Aug 2016 22:59:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdTps-00078o-2B for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2016 22:59:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdTpn-0003Iv-0S for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2016 22:59:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdTpm-0003IY-TH for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2016 22:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bdTpm-0007kF-CR for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2016 22:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Aug 2016 02:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24133-submit@debbugs.gnu.org id=B24133.147226672929752 (code B ref 24133); Sat, 27 Aug 2016 02:59:02 +0000 Original-Received: (at 24133) by debbugs.gnu.org; 27 Aug 2016 02:58:49 +0000 Original-Received: from localhost ([127.0.0.1]:41789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdTpZ-0007jo-4S for submit@debbugs.gnu.org; Fri, 26 Aug 2016 22:58:49 -0400 Original-Received: from mail-it0-f53.google.com ([209.85.214.53]:34872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdTpX-0007jb-RB for 24133@debbugs.gnu.org; Fri, 26 Aug 2016 22:58:48 -0400 Original-Received: by mail-it0-f53.google.com with SMTP id x131so22875513ite.0 for <24133@debbugs.gnu.org>; Fri, 26 Aug 2016 19:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=KdcIH8WRc3Ga04MPH//HzXS5fxyuABtk8w/F4vjEcdc=; b=ngAsz3e2Pxi/tOCW5OdVP98jPT0RYbQo8duUgLtP5EIADJXP1GuymvjSTvGWHDltmD fpSs/xpAlg08Z8F3mTtkS2UnX8i3WiGiWi6vdGR3EoDHuHe1Kzd6h1bDkzEIUh2D5T0t TvC7ErdSVdvpSrpsVaP4nOSRAK6lJN6C70TOJxXQR226XBsgdpRf7yndbpZqNgiK49uQ +Gy+NwTIPXuPqmUCulCjjh37J62LieN2TUBRL5+6a+AsjZY14zTXHV0Pa/bZKXqlEY6l XMApozuSaVYVYj5+c+A6t9LsSIbrzpDAPd4i2ilBnyAOFOkLHEbPvH92agKjcNUPB4Cw tWkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=KdcIH8WRc3Ga04MPH//HzXS5fxyuABtk8w/F4vjEcdc=; b=dOJa6UxCYjJCJ5ltHAQlaUf+RmKH+svhtYN/yBAjDui2xPR6XqufEdmN7+R0pXnLaw //YTAPng+mZfkdKF4HrnBHDmXxB2xyfFP/Ek6ktJ3+FT5WrQF0LHm2TZrmNTZGTKSDYf oaZd71j6cvMLBCsd4+NRl4mOKfFLRE15XRpHH+VnpilVFe+ZdxnSF2zda3f+UJFp9sjh aoutucLNIHp7N09ZwdC2LG+6cALspBkK7JVijvKslVCdqmsytS3D4fDbBNRoFTTjVFUk ujHtZZSbMkRgGHg8sYYyXXHm4ZpX7Mwd4+Nmw2zaZqfois5m6reb1kbt/qcPy6iv0E9Z o1uA== X-Gm-Message-State: AE9vXwNMIo4mET9XlFpzFOxNSUryt2rX24dlB9DhnkMkPhZoZT14kskPbCM3ZnTm+zXsNA== X-Received: by 10.36.190.201 with SMTP id i192mr2489327itf.98.1472266722243; Fri, 26 Aug 2016 19:58:42 -0700 (PDT) Original-Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id g78sm864058itb.12.2016.08.26.19.58.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Aug 2016 19:58:41 -0700 (PDT) In-Reply-To: <87bn0oqlk7.fsf@cochranmail.com> (Robert Cochran's message of "Fri, 19 Aug 2016 18:24:40 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122708 Archived-At: Robert Cochran writes: > It seems that `call-interactively' propagates the prefix argument to the > called function automatically (it did with a test command that printed > its arg in my git emacs -Q), so you should be able to remove the last 2 > arguments to each call and it should Just Work(tm). > > I have a patch, attached, that does just that. Looks good, except for some minor format problems in the commit message (refer to etc/CONTRIBUTE "** Commit messages", and https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html). > Subject: [PATCH] Fix uses of (call-interactively) in > lisp/emacs-lisp/checkdoc.el > > * lisp/emacs-lisp/checkdoc.el (checkdoc-ispell) > (checkdoc-ispell-current-buffer) The lines in a changelog entry should be not indented (i.e., they should in the same column as the "*"). > (checkdoc-ispell-interactive) > (checkdoc-ispell-message-text) > (checkdoc-ispell-start) > (checkdoc-ispell-continue) > (checkdoc-ispell-comments) > (checkdoc-ispell-defun): > Do not pass 'current-prefix-arg' to 'call-interactively' as an event > vector; merely allow it to propagate forward to the interactive call. > The explanatory part of the message should go before the changelog entry, not after. > Passing the prefix argument as the 3rd argument to 'call-interactively' > causes the prefix argument to be interpreted as events, which is not > only wrong, but also causes a type error, as 'current-prefix-arg' can > never be a vector as 'call-interactively' expects. 'call-interactively' Sentences should end with a double space (set `sentence-end-double-space' to t). > automatically passes its prefix argument to the called function, so just > do that, eliminating faulty behavior.