From: npostavs@users.sourceforge.net
To: "José L. Doménech" <domenechjosel@gmail.com>
Cc: 24620@debbugs.gnu.org, Michael Albinus <michael.albinus@gmx.de>
Subject: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters
Date: Thu, 27 Oct 2016 19:14:49 -0400 [thread overview]
Message-ID: <87wpgtqt92.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87insdpp45.wl-domenechjosel@gmail.com> ("José L. Doménech"'s message of "Thu, 27 Oct 2016 21:29:30 +0200")
José L. Doménech <domenechjosel@gmail.com> writes:
>
> So the patch becomes something like:
>
> (dired-shell-command
> (replace-regexp-in-string
> - "%o" out-file
> + "%o" (shell-quote-argument out-file)
> (replace-regexp-in-string
> - "%i" (mapconcat #'file-name-nondirectory in-files " ")
> - (cdr rule)))))
> + "%i" (mapconcat (lambda (file-desc)
> + (shell-quote-argument
> + (file-name-nondirectory file-desc)))
> + in-files " ")
> + (cdr rule) nil t) nil t)))
That looks pretty good. I think it would be even nicer to use the
`format-spec' function instead of calling `replace-regexp-in-string'
twice.
next prev parent reply other threads:[~2016-10-27 23:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 7:06 bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters José L. Doménech
2016-10-27 14:03 ` José L. Doménech
2016-10-27 17:19 ` Eli Zaretskii
2016-10-27 17:34 ` Michael Albinus
2016-10-27 18:39 ` José L. Doménech
2016-10-27 18:51 ` Noam Postavsky
2016-10-27 19:29 ` José L. Doménech
2016-10-27 23:14 ` npostavs [this message]
2016-10-28 7:06 ` José L. Doménech
2016-10-29 2:06 ` npostavs
2016-10-29 9:17 ` José L. Doménech
2016-10-29 12:06 ` npostavs
2016-10-29 18:40 ` José L. Doménech
2016-10-29 19:42 ` José L. Doménech
2016-10-30 1:39 ` npostavs
2016-10-30 8:33 ` José L. Doménech
2016-10-29 18:41 ` José L. Doménech
2016-10-28 9:22 ` bug#24620: Forward: " José L. Doménech
2016-10-27 19:31 ` José L. Doménech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpgtqt92.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=24620@debbugs.gnu.org \
--cc=domenechjosel@gmail.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.