Annoying "Parsing...done" message when editing C++ files

Annoying "Parsing...done" message when editing C++ files

[Hong Xu]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]


Is it possible to remove the annoying "Parsing...done" message in C++
mode? It often competes with other useful information I've set up.

I saw this line in progmodes/cpp.el, but don't know how to diminish it:

     (message "Parsing...done"))


Hong

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: Annoying "Parsing...done" message when editing C++ files

[Alex Kost]

Hong Xu (2016-11-01 18:41 -0700) wrote:

> Is it possible to remove the annoying "Parsing...done" message in C++
> mode? It often competes with other useful information I've set up.
>
> I saw this line in progmodes/cpp.el, but don't know how to diminish it:
>
>      (message "Parsing...done"))

Since this message is just a line of code in 'cpp-highlight-buffer'
command, I think the only way to get rid of it is to write your own
function that will override 'cpp-highlight-buffer', but I wouldn't
recommend doing it as you'll have to maintain your version of this
command (which is pretty big).  It's probably better to make a bug
report that you'd like to have an option to avoid these "Parsing..."
messages.

-- 
Alex

Re: Annoying "Parsing...done" message when editing C++ files

[John Mastro]

Hong Xu <hong@topbug.net> wrote:
>
> Is it possible to remove the annoying "Parsing...done" message in C++
> mode? It often competes with other useful information I've set up.
>
> I saw this line in progmodes/cpp.el, but don't know how to diminish it:
>
>      (message "Parsing...done"))

Something like this should do the trick:

(defun my-cpp-highlight-buffer-advice (orig &rest args)
  (let ((inhibit-message t))
    (apply orig args)))

(with-eval-after-load 'cpp
  (advice-add 'cpp-highlight-buffer :around
              #'my-cpp-highlight-buffer-advice))

Hope that helps

        John

Re: Annoying "Parsing...done" message when editing C++ files

[Stefan Monnier]

> (with-eval-after-load 'cpp
>   (advice-add 'cpp-highlight-buffer :around
>               #'my-cpp-highlight-buffer-advice))

You shouldn't need to wrap this in `with-eval-after-load`:
`advice-add` is careful to preserve the advice across (re)definition of
the function.


        Stefan

Re: Annoying "Parsing...done" message when editing C++ files

[Stefan Monnier]

> (defun my-cpp-highlight-buffer-advice (orig &rest args)
>   (let ((inhibit-message t))
>     (apply orig args)))
>
> (with-eval-after-load 'cpp
>   (advice-add 'cpp-highlight-buffer :around
>               #'my-cpp-highlight-buffer-advice))

One more thing: just like with the docstring, it's often better to
name the function after what it *does* than after who uses it.

This applies less to hooks and such (which tend to be rather
specific/ad-hoc), but here it does because your piece of advice is
actually quite generic:

    (defun my-inhibit-messages (orig &rest args)
      (let ((inhibit-message t))
        (apply orig args)))
    (advice-add 'cpp-highlight-buffer :around #'my-inhibit-messages)

Oh, yet another thing: you can shorten the function slightly to

    (defun my-inhibit-messages (&rest args)
      (let ((inhibit-message t))
        (apply args)))


-- Stefan

Re: Annoying "Parsing...done" message when editing C++ files

[Hong Xu]

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]


On 2016-11-02 Wed 10:19 GMT-0700, John Mastro <john.b.mastro@gmail.com> wrote:
> Something like this should do the trick:
>
> (defun my-cpp-highlight-buffer-advice (orig &rest args)
>   (let ((inhibit-message t))
>     (apply orig args)))
>
> (with-eval-after-load 'cpp
>   (advice-add 'cpp-highlight-buffer :around
>               #'my-cpp-highlight-buffer-advice))
>
> Hope that helps
>

Thanks. FYI, I've submitted a patch to resolve this issue, which is
probably more elegant:

    https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24861#17

Hong

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: Annoying "Parsing...done" message when editing C++ files

[Alex Kost]

John Mastro (2016-11-02 10:19 -0700) wrote:

> Hong Xu <hong@topbug.net> wrote:
>>
>> Is it possible to remove the annoying "Parsing...done" message in C++
>> mode? It often competes with other useful information I've set up.
>>
>> I saw this line in progmodes/cpp.el, but don't know how to diminish it:
>>
>>      (message "Parsing...done"))
>
> Something like this should do the trick:
>
> (defun my-cpp-highlight-buffer-advice (orig &rest args)
>   (let ((inhibit-message t))
>     (apply orig args)))

Wow, this is great, I didn't know about 'inhibit-message', thanks!

> (with-eval-after-load 'cpp
>   (advice-add 'cpp-highlight-buffer :around
>               #'my-cpp-highlight-buffer-advice))
>
> Hope that helps
>
>         John
>
>

-- 
Alex