From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Alexey Lebedeff <binarin@gmail.com>
Cc: Orgmode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Tag visibility fixup after setting them
Date: Thu, 29 Dec 2016 01:39:30 +0100 [thread overview]
Message-ID: <87wpejo9fh.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87shp9r7ds.fsf@gmail.com> (Alexey Lebedeff's message of "Tue, 27 Dec 2016 13:30:55 +0300")
Hello,
Alexey Lebedeff <binarin@gmail.com> writes:
> This fixes bug where you sometimes can't immediately see tags that were
> just set. And to reveal them you need to go through global visibility
> cycle.
Thank you for the patch, and the test.
> +(defun org-insert-visible-text (&rest args)
> + "Inserts arguments at point and makes them visible in outline.
> +
> +When text is being inserted on the invisible region boundary, it
> +can be inadvertently sucked into invisibility."
> + (let* ((before-point (point)))
> + (apply #'insert args)
> + (outline-flag-region before-point (point) nil)))
I don't think, for the time being, it deserves a dedicated function.
I suggest to integrate it in `org-set-tags' instead.
Could you send an updated patch ?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2016-12-29 0:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 10:30 [PATCH] Tag visibility fixup after setting them Alexey Lebedeff
2016-12-29 0:39 ` Nicolas Goaziou [this message]
2016-12-29 13:11 ` Alexey Lebedeff
2016-12-29 15:41 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpejo9fh.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=binarin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.