From: Mark Oteiza <mvoteiza@udel.edu>
To: emacs-devel@gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: [PATCH] checking eww download directory
Date: Fri, 27 Jan 2017 14:10:51 -0500 [thread overview]
Message-ID: <87wpdgmi84.fsf@udel.edu> (raw)
Two things:
- it would be nice if eww looked a little harder for an existing
downloads directory. Perhaps what's below is too much, comments
welcome
- currently if eww-download-directory isn't accessible, emacs will
download a file and the sentinel will fail, and one is left with a
hidden buffer with the downloaded contents and no saved file. Easy
solution: fail early by checking with access-file
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 0282fe68e6..6c62729849 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -55,9 +55,20 @@ eww-search-prefix
:group 'eww
:type 'string)
-(defcustom eww-download-directory "~/Downloads/"
+(defcustom eww-download-directory
+ (cond
+ ((memq system-type '(ms-dos windows-nt cygwin))
+ (expand-file-name "Downloads" (getenv "USERPROFILE")))
+ ((cl-some
+ (lambda (str)
+ (let ((f (expand-file-name str "~")))
+ (and (file-directory-p f)
+ (string-match-p "downloads?" (downcase f))
+ (abbreviate-file-name f))))
+ (directory-files "~")))
+ (t "~/Downloads/"))
"Directory where files will downloaded."
- :version "24.4"
+ :version "26.1"
:group 'eww
:type 'directory)
@@ -1501,6 +1512,7 @@ eww-copy-page-url
(defun eww-download ()
"Download URL under point to `eww-download-directory'."
(interactive)
+ (access-file eww-download-directory "Download failed")
(let ((url (get-text-property (point) 'shr-url)))
(if (not url)
(message "No URL under point")
next reply other threads:[~2017-01-27 19:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 19:10 Mark Oteiza [this message]
2017-01-27 19:21 ` [PATCH] checking eww download directory Lars Ingebrigtsen
2017-01-27 19:48 ` Mark Oteiza
2017-01-27 20:10 ` Eli Zaretskii
2017-01-28 8:01 ` Yuri Khan
2017-01-28 8:54 ` Eli Zaretskii
2017-01-28 14:14 ` Lars Ingebrigtsen
2017-01-28 21:04 ` Mark Oteiza
2017-01-27 19:27 ` Lars Ingebrigtsen
2017-01-27 19:38 ` Clément Pit-Claudel
2017-01-27 20:17 ` Mark Oteiza
2017-01-27 22:21 ` Clément Pit-Claudel
2017-01-28 7:53 ` Eli Zaretskii
2017-01-29 1:01 ` Library for XDG things (was Re: [PATCH] checking eww download directory) Mark Oteiza
2017-01-30 14:40 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpdgmi84.fsf@udel.edu \
--to=mvoteiza@udel.edu \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.