all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marcin Borkowski <mbork@mbork.pl>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Add `advice-remove-all`
Date: Tue, 02 May 2017 07:31:23 +0200	[thread overview]
Message-ID: <87wp9zx1sk.fsf@jane> (raw)
In-Reply-To: <jwva86wmr2w.fsf-monnier+Inbox@gnu.org>


On 2017-05-01, at 19:21, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>>>> I recently had the need to remove all advice from a function I was playing
>>>> around with, and was surprised to find that `advice-remove-all` did not
>>>> exist.
>>> Do you have a use-case?
>>> In the case of https://emacs.stackexchange.com/questions/24657, my
>>> impression that all that was needed is an interactive `advice-remove`
>>> which provides completion (so that to remove all pieces of advice, you
>>> may have to use this command a few times, maybe, but it's rather rare).
>> Would that work when I (quite foolishly, I admit) advised something with
>> an anonymous function?
>
> In the absence of actual code, I can only say that it could work.
> Clearly, it would be better to write the code so that it does.

Of course.  Maybe I'll try to do that...

>         Stefan
>
> PS: I don't think it's foolish, BTW.

Well, it seems to me it is: showing the value of such a hook is
less-than-optimal and removing the lambda from it _might_ be tricky.

Best,

--
Marcin Borkowski



  reply	other threads:[~2017-05-02  5:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27  3:23 [PATCH] Add `advice-remove-all` Tianxiang Xiong
2017-04-27 12:52 ` Stefan Monnier
2017-05-01 13:26   ` Marcin Borkowski
2017-05-01 17:21     ` Stefan Monnier
2017-05-02  5:31       ` Marcin Borkowski [this message]
2017-05-02 13:47         ` Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2019-09-04 16:59 Matthew Newton
2019-09-04 18:30 ` Stefan Monnier
2019-09-05  0:14   ` T.V Raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp9zx1sk.fsf@jane \
    --to=mbork@mbork.pl \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.