From: npostavs@users.sourceforge.net
To: Alex Branham <branham@utexas.edu>
Cc: 27341@debbugs.gnu.org
Subject: bug#27341: updated patch to fix docstring
Date: Sun, 02 Jul 2017 15:13:29 -0400 [thread overview]
Message-ID: <87wp7qk5ye.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87tw2u7k4i.fsf@utexas.edu> (Alex Branham's message of "Sun, 02 Jul 2017 20:45:49 +0200")
Alex Branham <branham@utexas.edu> writes:
>> You missed the double spacing before the "Else,".
>
> D'oh! Fixed this time, sorry!
Oh, the funny indentation came back, do you have some Emacs setting
that's doing that?
>>> Actually, we need to check (use-region-p) anyway in case the mark
>>> hasn't been activated yet in the buffer:
>>
>> Hmm, I just tried this and it doesn't quite do the job. I believe the
>> problem is that the (interactive "r") form throws an error when the mark
>> hasn't been activated yet. To handle this case correctly you need to
>> replace the "r" with some lisp code that produces the argument list.
>
> Ok, now I don't use "r" and just get the region directly. I think that'll do the trick?
Oh yeah, that works. We should try not to add compiler warnings though:
ELC net/eww.elc
In toplevel form:
../../emacs-master/lisp/net/eww.el:315:1:Warning: Unused lexical argument
‘end’
../../emacs-master/lisp/net/eww.el:315:1:Warning: Unused lexical argument
‘beg’
I think we can just drop the arguments as well, lisp programs can always
do (eww (buffer-substring BEG END)) instead.
Do you think the prompt string should be a bit more detailed? "Query"
seems a bit vague (e.g., consider if you hit M-s M-w by accident).
Maybe we should just do (call-interactively 'eww) and then we'll get the
prompt from there.
next prev parent reply other threads:[~2017-07-02 19:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 11:21 bug#27341: eww-search-words should prompt if region inactive Alex Branham
2017-06-13 9:24 ` bug#27341: updated patch to fix docstring Alex Branham
2017-06-25 14:29 ` npostavs
2017-06-26 14:00 ` Alex Branham
2017-06-26 23:50 ` npostavs
2017-06-27 5:32 ` Alex Branham
2017-06-27 13:23 ` Alex Branham
2017-06-30 0:54 ` npostavs
2017-06-30 6:25 ` Alex Branham
2017-07-02 18:32 ` npostavs
2017-07-02 18:45 ` Alex Branham
2017-07-02 19:13 ` npostavs [this message]
2017-07-02 19:25 ` Alex Branham
2017-07-02 20:23 ` npostavs
2017-06-27 14:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp7qk5ye.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=27341@debbugs.gnu.org \
--cc=branham@utexas.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.