From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: Some testing issues Date: Sat, 08 Jul 2017 16:52:24 +0200 Message-ID: <87wp7jnfpz.fsf@rosalinde> References: <8737a8j61r.fsf@rosalinde> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499525573 17800 195.159.176.226 (8 Jul 2017 14:52:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Jul 2017 14:52:53 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 08 16:52:49 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTr6B-00046J-73 for ged-emacs-devel@m.gmane.org; Sat, 08 Jul 2017 16:52:43 +0200 Original-Received: from localhost ([::1]:33119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTr6G-0003Oj-Lb for ged-emacs-devel@m.gmane.org; Sat, 08 Jul 2017 10:52:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTr68-0003NU-6N for emacs-devel@gnu.org; Sat, 08 Jul 2017 10:52:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTr65-0002za-2q for emacs-devel@gnu.org; Sat, 08 Jul 2017 10:52:40 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:57592) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dTr64-0002z4-Oe for emacs-devel@gnu.org; Sat, 08 Jul 2017 10:52:37 -0400 Original-Received: from rosalinde ([83.135.5.146]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Le69A-1e1mCM0mOi-00ptTM; Sat, 08 Jul 2017 16:52:26 +0200 In-Reply-To: (Stefan Monnier's message of "Sat, 08 Jul 2017 00:45:10 -0400") X-Provags-ID: V03:K0:GEkupmxj/YjEUF4di2mMJseNw6QUD+AAHsNCTH/hFkLZaG86fwq eTrZHl/ApVHdDlseWPPpkB889jzZ/0MIKdrPDuF3B7sRXliACC7PIBq77Idx1E1b5GXTum0 2Yn7h9DGUsTSpSToh/+lDE3ghqJCYj+uHhMriBAhuc/S6ATCFZCrCDtXEdaiShSyJDjgWfv 1CixM2ALNDVYW/m/ybpQA== X-UI-Out-Filterresults: notjunk:1;V01:K0:mL1iR1Nk2ak=:zTqH877/8xNY3IK3x/f+Q4 8o/MMeub+37GboKzLR61h8mX+uszPq1DRqOf71vfibk0tYIkyS2u/kxWYSm5VngCSok6FIkqO Nd9iXQiLGSZX9FgMf3CTzjfHKrSGpQNn7J48jLEVPTO9x6hcNqoeHQLyxE7S6VjX0ZABeQRwg /ZilCWFx2wQdHMwzHgawX844HeU0YWkMt5DjWxvYvIVl4nNJhJZPOD5L6Ygn6FzFH84vZg87e 3xH20BwW0vvpwy7Is11voZviehIH0UyUoNeDLz6X4uKTntbERsVPruK+tzczr2IL6yqrL9EKA iKaKUcOf/c785fVgcOoGlwk3TCIR/KTw+isZl1p8pmG3UXjFJm8+4LIzqQwWWqNEGGuXoAbNw Jz0SIwLNBaNp0tROLH8aTu4vFgR57AM74EzWuveIdPmKufcbAjmsE1bdnwhQtTlPnm/GGvJm5 jLMyboL/Bk/wRQGscL21T6aKXwPV+wQQi6S6a7y5uGGkA7E7XJfiuJu5J5Ue1saW/w7OLDglj ntgpqTKhXoLLjKvCW5BjkPoryQnDUdUg5zuN7pzMIwJZtxStWm2sV3ZkAiH93vasIBCqqZk/Y 9GLRpCs0swqk5KnN39FqHN3uyW06awydyAXNs5LmN6T6JAjBJ6uFLN47N7aMKxBNFqy/BZDSs KgU2If6nHx/O6Qvg8hkRAM/LFPYaBT9G077UUjeDKmvD22oE2g6tmK+oZdn7jYuJ8f/NaUBsT 2zbWpwTnKDgBsNJCjU3ZvVQUNyZLeisSo99tDjFvJgnBX7lDa2AqPnN6w6Xoa5dfFm2jm/wS X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216328 Archived-At: On Sat, 08 Jul 2017 00:45:10 -0400 Stefan Monnier wrote: >> Several of the tests call the function todo-toggle-view-done-items, >> which contains this code: >> >> (if (not (pos-visible-in-window-p shown)) >> (recenter) > > This code is indeed brittle: pos-visible-in-window-p presumes that > (current-buffer) is the same as (window-buffer (selected-window)), but > that's not always the case. Is there a less brittle way to test the visibility of point? At least as far as using todo-toggle-view-done-items in todo-mode in concerned, (current-buffer) is equivalent to (window-buffer (selected-window)), but apparently that is not so in the test environment. Steve Berman