From: Stephen Berman <stephen.berman@gmx.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 27243@debbugs.gnu.org
Subject: bug#27243: closed (Re: bug#27243: dired-auto-revert-buffer jumps point to beginning of buffer)
Date: Sat, 15 Jul 2017 13:14:06 +0200 [thread overview]
Message-ID: <87wp7arlz5.fsf@rosalinde> (raw)
In-Reply-To: <5969C609.4040803@gmx.at> (martin rudalics's message of "Sat, 15 Jul 2017 09:36:41 +0200")
On Fri, 14 Jul 2017 22:52:18 -0700 John Wiegley <jwiegley@gmail.com> wrote:
>>>>>> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> Thanks for confirming. I think this is the right fix and would commit it,
>> but since this exchange has taken place in a closed bug, it may have fallen
>> under the radar, so I'd like an explicit go-ahead. Eli, John?
>
> At first glance it looks OK to me, though I defer to Eli's experience in such
> matters.
On Sat, 15 Jul 2017 10:18:06 +0300 Eli Zaretskii <eliz@gnu.org> wrote:
> No objections here.
>
> Thanks.
Thanks for okaying, but...
On Sat, 15 Jul 2017 09:36:41 +0200 martin rudalics <rudalics@gmx.at> wrote:
>> + (set-window-buffer (selected-window)
>> + (set-buffer (dired-noselect dirname switches))))
>
> This really should be
>
> (pop-to-buffer-same-window (dired-noselect dirname switches))
>
> Even if people disliked it in the past and some still dislike it: Try
>
> C-h f
> M-x dired
Wow, that's disastrous! And frightening: I use the "(set-window-buffer
(selected-window) (set-buffer ...))" idiom a lot in todo-mode.el; I just
checked two commands using `C-h f' followed by the command invocation:
one worked fine but the other caused the same disaster. So now I have
to check all uses :(. Is there a general guideline for when to use
set-window-buffer and when to use pop-to-buffer-same-window?
Anyway, I'll commit the dired.el change you recommend; many thanks.
Steve Berman
next prev parent reply other threads:[~2017-07-15 11:14 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 23:45 bug#27243: dired-auto-revert-buffer jumps point to beginning of buffer Antoine Levitt
2017-06-05 13:37 ` Stephen Berman
2017-06-05 15:02 ` Eli Zaretskii
2017-06-05 15:15 ` Stephen Berman
2017-06-05 16:20 ` Eli Zaretskii
2017-06-10 8:24 ` Eli Zaretskii
[not found] ` <CABfD5m0==QAKYoJDkaPQxoyS1BQT-eTQJLmYZC6Z-V5A0jfeig@mail.gmail.com>
2017-06-10 8:45 ` Antoine Levitt
[not found] ` <handler.27243.D27243.14970831096548.notifdone@debbugs.gnu.org>
2017-06-17 12:16 ` bug#27243: closed (Re: bug#27243: dired-auto-revert-buffer jumps point to beginning of buffer) Antoine Levitt
2017-06-17 13:32 ` Stephen Berman
2017-07-09 17:37 ` Antoine Levitt
2017-07-14 9:56 ` Stephen Berman
2017-07-15 5:52 ` John Wiegley
2017-07-15 7:18 ` Eli Zaretskii
2017-07-17 9:22 ` Stephen Berman
2017-07-22 15:28 ` Antoine Levitt
2017-07-22 16:55 ` Glenn Morris
2017-07-22 22:48 ` Stephen Berman
2017-07-22 22:48 ` bug#27243: another case: dired-auto-revert-buffer jumps point to beginning of buffer Stephen Berman
2017-07-23 14:43 ` Eli Zaretskii
2017-07-23 18:40 ` martin rudalics
2017-07-23 18:58 ` Eli Zaretskii
2017-07-23 21:09 ` martin rudalics
2017-07-28 8:49 ` Stephen Berman
2017-07-28 9:28 ` Eli Zaretskii
2017-07-28 12:22 ` martin rudalics
2017-07-28 13:02 ` Stefan Monnier
2017-07-28 13:12 ` Eli Zaretskii
2017-07-28 13:16 ` Stefan Monnier
2017-07-28 13:41 ` Eli Zaretskii
2017-07-28 14:14 ` martin rudalics
2017-07-28 14:45 ` Eli Zaretskii
2017-07-28 14:54 ` Stephen Berman
2017-07-29 11:44 ` Stephen Berman
2020-05-25 4:21 ` Michael Heerdegen
[not found] ` <874ks4ekpg.fsf@web.de>
2020-05-25 7:26 ` Stephen Berman
2020-05-25 23:36 ` Michael Heerdegen
2020-05-27 1:23 ` Michael Heerdegen
2020-05-27 5:36 ` Michael Heerdegen
2020-05-27 14:52 ` martin rudalics
2020-05-27 17:01 ` Michael Heerdegen
2020-05-27 17:56 ` martin rudalics
2020-05-30 22:11 ` Juri Linkov
2020-05-26 8:02 ` martin rudalics
2020-05-27 1:16 ` Michael Heerdegen
2017-07-15 7:36 ` bug#27243: closed (Re: bug#27243: dired-auto-revert-buffer jumps point to beginning of buffer) martin rudalics
2017-07-15 11:14 ` Stephen Berman [this message]
2017-07-15 13:59 ` martin rudalics
2017-07-17 9:28 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp7arlz5.fsf@rosalinde \
--to=stephen.berman@gmx.net \
--cc=27243@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.