bug#27823: 26.0.50; nsm in paranoid mode always saves fingerprint in session-only mode

bug#27823: 26.0.50; nsm in paranoid mode always saves fingerprint in session-only mode

[Robert Pluim]

; This is with the HEAD of master
; Make sure that network-security.data doesn't contain the fingerprint
  for lists.gnu.org, which for me is sha1:e9248aef3ac9bcbba8d57fa471a07073adb88cbd

emacs -Q
(setq network-security-level 'paranoid)
M-x eww RET
https://lists.gnu.org RET
; Answer 'session only' to the prompt
C-x C-c
emacs -Q
(setq network-security-level 'paranoid)
M-x eww RET
https://lists.gnu.org RET

; Be very surprised that you're not reprompted to accept the
  certificate, and see that its fingerprint has been added to
  network-security.data

If I've said 'session only', I expect emacs to save nothing about the
connection at all.

Regards

Robert

In GNU Emacs 26.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
 of 2017-07-25 built on rpluim-ubuntu
Repository revision: 4e619aaa163f771c0ce271671c2b6fde09f8ba81
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description:	KDE neon LTS User Edition 5.8

bug#27823: 26.0.50; nsm in paranoid mode always saves fingerprint in session-only mode

[Lars Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> emacs -Q
> (setq network-security-level 'paranoid)
> M-x eww RET
> https://lists.gnu.org RET
> ; Answer 'session only' to the prompt
> C-x C-c
> emacs -Q
> (setq network-security-level 'paranoid)
> M-x eww RET
> https://lists.gnu.org RET
>
> ; Be very surprised that you're not reprompted to accept the
>   certificate, and see that its fingerprint has been added to
>   network-security.data
>
> If I've said 'session only', I expect emacs to save nothing about the
> connection at all.

Yup.  Looks like the error was in the NSM saving the fingerprint once
more after it had already been saved in the correct temporary storage.
This should now be fixed on the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no