From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28489: Acknowledgement (27.0.50; eieio-persistent slot type validation should be a bit smarter) Date: Tue, 26 Sep 2017 20:05:25 -0400 Message-ID: <87wp4lf1kq.fsf@users.sourceforge.net> References: <87lglcn8dt.fsf@ericabrahamsen.net> <878th1i50l.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1506470777 21696 195.159.176.226 (27 Sep 2017 00:06:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 27 Sep 2017 00:06:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: 28489@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 27 02:06:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwzra-0004oI-0r for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Sep 2017 02:06:06 +0200 Original-Received: from localhost ([::1]:51542 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwzrf-00040V-NU for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Sep 2017 20:06:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwzrZ-00040Q-T3 for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2017 20:06:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwzrW-000173-NF for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2017 20:06:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53381) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dwzrW-00016w-JQ for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2017 20:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dwzrW-00075d-CJ for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2017 20:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Sep 2017 00:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28489-submit@debbugs.gnu.org id=B28489.150647075227236 (code B ref 28489); Wed, 27 Sep 2017 00:06:02 +0000 Original-Received: (at 28489) by debbugs.gnu.org; 27 Sep 2017 00:05:52 +0000 Original-Received: from localhost ([127.0.0.1]:33828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwzrM-00075E-Mq for submit@debbugs.gnu.org; Tue, 26 Sep 2017 20:05:52 -0400 Original-Received: from mail-it0-f53.google.com ([209.85.214.53]:52515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwzrK-00074y-Jh for 28489@debbugs.gnu.org; Tue, 26 Sep 2017 20:05:51 -0400 Original-Received: by mail-it0-f53.google.com with SMTP id c195so4754565itb.1 for <28489@debbugs.gnu.org>; Tue, 26 Sep 2017 17:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=o60J7tw7oNfBNo13nIKGMg4vfB7Z/aw8RcSFcVu5Vww=; b=i4DLwAS08iknySi+ZJOKJV1Ux/a4DfsnwEWE0mewG1fCwku43ndmNdiMOZtycBAcvh UVVnGFREH7jFZQqD1cD1t3m4+RPWyrZdBpiGmw8Y4Zf2bZ9wdMJYGUy77N0hKtegJbi0 Et18hZuRUz37Z8y4fL8sReVVq+JKnGOAoREVGhRZPz+upwZ6TvpvnBAHaRW5QHA9EcFw M8+2nrxNH26/puHI6VR8IAM6HSINxOZI8x1WFzlXKqpRgsvD7QnMdystLQEF9nama/vG lBCrhKjGXXc0ED3T2Dbss4IMbGRiy5MRh3NfkSsXFbPsLnvE0Q+grty8+V3xEkVwZ89n 3OxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=o60J7tw7oNfBNo13nIKGMg4vfB7Z/aw8RcSFcVu5Vww=; b=A7vwyePvp5wK0s8WOOsANSbmNvUT7v2DbInVY2iMvk6TGZLHv1gHUNl7iRnGHOBxm9 1ZwS0lW7Cr2UwAKzXPHEWl5y3sJLd4STzKDiBT1HOdt64sD+Mj1JW5T54c6hXnlGcwU9 e6m5fx/Vnb+tRcdawuL/XyDf+6sZMmHUWlXQ57tfrBeyFFYun2Ln0VBUehn1ZPUIxt17 1zR5d8VBa0kuPRkRDFOsi8QIAn4Mw8BwBwIgbfR49TgWfu6Zws4OTk/d4G6+vmOOpc6G 9NXkraLTP6z6QRALoTcIRCnbB685zQTGWNZdnuoKmL6RGr+DxaUczEeO4wV289XeATxG JUvw== X-Gm-Message-State: AHPjjUiUSSGh1qGLhhjpJzMo2cmPASJ1JBCpUBmEu418jgafkj+IICTi odcvUGUkzFHcf0roqIrOB8Lzxw== X-Google-Smtp-Source: AOwi7QBOdED9WP15btrnwNMEX7/6XTKybtByL+Vk8bjhSFlUoFI5rPgvHYLpCxHJ0eO5yVbbZ5hecA== X-Received: by 10.36.11.8 with SMTP id 8mr113267itd.94.1506470744829; Tue, 26 Sep 2017 17:05:44 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e98sm4964051ioi.35.2017.09.26.17.05.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Sep 2017 17:05:43 -0700 (PDT) In-Reply-To: <878th1i50l.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 26 Sep 2017 13:22:50 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137478 Archived-At: Eric Abrahamsen writes: > ((eq (car-safe type) 'or) > - ;; If type is a list, and is an or, it is possibly something > - ;; like (or null myclass), so check for that. > - (let ((ans nil)) > - (dolist (subtype (cdr type)) > - (setq ans (eieio-persistent-slot-type-is-class-p > - subtype))) > - ans)) > + ;; If type is a list, and is an or, it is possible that > + ;; multiple classes are acceptable, find them all. > + (seq-filter (lambda (elt) (class-p elt)) (cdr type))) You seem to have removed some recursion here, is that correct? If yes, probably something worth explaining in the commit message. Minor nitpicks: - The lambda could be replaced with just #'class-p. - The indentation has a mix of tabs and spaces.