From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#28605: 26.0.60; Part of leftmost character hidden Date: Tue, 03 Oct 2017 15:08:51 +0200 Message-ID: <87wp4c750c.fsf@gmail.com> References: <59CB5D69.7040404@gmx.at> <59CE05F2.1010202@gmx.at> <59CE8E74.5010308@gmx.at> <59D35549.6030905@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507036236 24024 195.159.176.226 (3 Oct 2017 13:10:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 3 Oct 2017 13:10:36 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: Lars Magne Ingebrigtsen , 28605@debbugs.gnu.org, Kaushal To: Ola Nilsson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 03 15:10:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzMxj-000586-F6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Oct 2017 15:10:15 +0200 Original-Received: from localhost ([::1]:58525 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzMxn-0005ih-Oz for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Oct 2017 09:10:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzMxc-0005eV-LZ for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 09:10:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzMxW-0004wR-ON for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 09:10:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36733) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dzMxW-0004wB-Kh for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 09:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dzMxW-0000ep-Ef for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2017 09:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Oct 2017 13:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28605-submit@debbugs.gnu.org id=B28605.15070361442426 (code B ref 28605); Tue, 03 Oct 2017 13:10:02 +0000 Original-Received: (at 28605) by debbugs.gnu.org; 3 Oct 2017 13:09:04 +0000 Original-Received: from localhost ([127.0.0.1]:45414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzMwZ-0000d3-Qd for submit@debbugs.gnu.org; Tue, 03 Oct 2017 09:09:03 -0400 Original-Received: from mail-wm0-f52.google.com ([74.125.82.52]:43802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzMwY-0000cU-4h for 28605@debbugs.gnu.org; Tue, 03 Oct 2017 09:09:02 -0400 Original-Received: by mail-wm0-f52.google.com with SMTP id m72so10944522wmc.0 for <28605@debbugs.gnu.org>; Tue, 03 Oct 2017 06:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:user-agent:mime-version; bh=o2DadGKZ+ae3OmLESlbHcH64EHEKC+Q3ugmnw8Nm+HQ=; b=J10hrHc3zDLoaoBPFTS1MaXGb0FoRhzj+bYtWwycC/fuHsaoian2P/j/a7RcVXe6IM LwmHnb3XCaO3O9dxkfUPECtsgTmPvJqVc1vSw51FUPrm4gNz+s+tpBUc0Z+wJmmXU+Jn 7GHbudUjorY4XMTFUTUbOGngGBWiJflFFoO8V8MzVOtN/SS+nK+Is81mb+vLN/5JnZQK Ly0RH6Ur2iAnC9uFUxQN1olSYk3piluWfhymK96RNlKIiRCZknJZxBwOwEeDtULFggKF XHUZthBBztjCp+MNtj3BRgZum9zWvUrA39bp/7UXpviQ9GScEsyHcPbZkdoagM2+NBKj 6S2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=o2DadGKZ+ae3OmLESlbHcH64EHEKC+Q3ugmnw8Nm+HQ=; b=XtB4vJ/qZ5bQt08lrRqAravfcZuY71j+ej3Z5jI+93bpcT3STbrz1qMnlYtkk2470H FdWomYKCNML7CSvtIyTxld5JWxOji1LkK6rTKviafphr47juPebEgDEtDz1yJF6FKJhC llBKDsoRxhtfai272IxFzIZV/qYPHZJq4zcX3mnxaEJkqEHss/BGZDqxb15MflhR/o6N XlCnwzsm5HPAl/gyuNL9jxL8WJjdWmrEDWVKljC/p1c07GPibksSU58ia0EqQo3aS4r5 4qvzdMLobLIxcGo9v0jJ7wZdherDUJz3k6SBBgNZvddPm7HG2mVdhJacPM+jvMglP+qp 22cg== X-Gm-Message-State: AHPjjUi8eHaXmcsQupN6ONA3E2zuVqfphux/eBfyTBwMkgWL/n7dqqCY ivXcDOElkTJGsiLjoDI5/cc= X-Google-Smtp-Source: AOwi7QC2zZchx734p9FXSca0mMzHf/WHRg+QjNgjyucNTyF8SMMIV4eI4PW/CWmJj6kFjQvV9ZnJjw== X-Received: by 10.80.212.40 with SMTP id t40mr24870366edh.67.1507036136373; Tue, 03 Oct 2017 06:08:56 -0700 (PDT) Original-Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id h33sm11934223edh.70.2017.10.03.06.08.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Oct 2017 06:08:55 -0700 (PDT) Gmane-Reply-To-List: yes In-Reply-To: (Ola Nilsson's message of "Tue, 3 Oct 2017 14:12:26 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137822 Archived-At: Ola Nilsson writes: >> does your problem go away? If so, then it would be interesting how the >> values returned by xg_get_scale differ with gtk_widget_get_scale_factor >> and xg_get_gdk_scale called. > > Made no difference what I can see, except a lot of messages : > > (emacs:2302): Gtk-CRITICAL **: gtk_distribute_natural_allocation: > assertion 'extra_space >= 0' failed Through inspection I noticed we're not adjusting the width of the scrollbar for the scale. Does the following help? diff --git a/src/gtkutil.c b/src/gtkutil.c index 0da7039..60ba627 100644 --- a/src/gtkutil.c +++ b/src/gtkutil.c @@ -3879,6 +3879,7 @@ xg_update_scrollbar_pos (struct frame *f, top /= scale; left /= scale; height /= scale; + width /= scale; left -= (scale - 1) * ((width / scale) >> 1); /* Clear out old position. */