From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions Date: Thu, 05 Oct 2017 13:18:37 +0200 Message-ID: <87wp49u9ki.fsf@mouse.gnus.org> References: <83poaxrzl1.fsf@gnu.org> <20170913172232.7jwwomyfmy567nrx@odonien.localdomain> <83lglio36q.fsf@gnu.org> <20170924131050.6erv6sshvz23dlbu@odonien.localdomain> <838tgy9d18.fsf@gnu.org> <877ew9vqwv.fsf@mouse.gnus.org> <83vajtx3hu.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507202373 15127 195.159.176.226 (5 Oct 2017 11:19:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Oct 2017 11:19:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: v.schneidermann@gmail.com, 28402@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 05 13:19:26 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e04BZ-0002kF-LP for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 13:19:25 +0200 Original-Received: from localhost ([::1]:39123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e04Bd-0006Dc-QT for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 07:19:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e04BE-00060z-Sr for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 07:19:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e04BC-0001gi-77 for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 07:19:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41128) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e04BC-0001gN-3c for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 07:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e04BB-0002hI-Pb for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 07:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Oct 2017 11:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28402-submit@debbugs.gnu.org id=B28402.150720232710345 (code B ref 28402); Thu, 05 Oct 2017 11:19:01 +0000 Original-Received: (at 28402) by debbugs.gnu.org; 5 Oct 2017 11:18:47 +0000 Original-Received: from localhost ([127.0.0.1]:49809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e04Aw-0002gn-PV for submit@debbugs.gnu.org; Thu, 05 Oct 2017 07:18:46 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:38610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e04At-0002gb-3t for 28402@debbugs.gnu.org; Thu, 05 Oct 2017 07:18:45 -0400 Original-Received: from cm-84.209.243.26.getinternet.no ([84.209.243.26] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e04Ao-00008s-52; Thu, 05 Oct 2017 13:18:41 +0200 In-Reply-To: <83vajtx3hu.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Oct 2017 14:01:33 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137959 Archived-At: Eli Zaretskii writes: >> - (cond (external >> - (funcall external dom)) >> - ((fboundp function) >> - (funcall function dom)) >> - (t >> - (shr-generic dom))) >> + (shr-indirect-call tag-name dom) [...] > Wouldn't reverting it make the entire change rather pointless? No, the other calls to shr-indirect are fine, and was what was missing. > If the issue is with stack usage, we could increase the stack when > shr-descend is called. As for speed, the old code had such an > indirection as well, albeit via funcall, no? The old call calls virtually always ends up with (funcall function dom) The new code calls shr-indirect-call which will will then (funcall function dom) So one extra function call for each node. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no