From: joaotavora@gmail.com (João Távora)
To: Mark Oteiza <mvoteiza@udel.edu>
Cc: emacs-devel@gnu.org, "Simen Heggestøyl" <simenheg@gmail.com>,
dgutov@yandex.ru, "Steve Purcell" <steve@sanityinc.com>,
sdl.web@gmail.com, monnier@iro.umontreal.ca
Subject: Re: Flymake refactored
Date: Fri, 06 Oct 2017 23:03:23 +0100 [thread overview]
Message-ID: <87wp48x7bo.fsf@gmail.com> (raw)
In-Reply-To: <20171006212239.lp6ooj5tk5sau2rv@logos.localdomain> (Mark Oteiza's message of "Fri, 6 Oct 2017 17:22:39 -0400")
Mark Oteiza <mvoteiza@udel.edu> writes:
> but perhaps there is a downside to this beyond possibly needlessly doing
> a lot of derived-mode-p checks while running through the hook.
Yes, it's repeating what mode hooks are supposed to take care of.
Stefan and I discussed it during the initial review. In the end he
convinced me, and I removed the derived-mode-p in elisp-mode.el
But I can understand the akwardness you are experiencing. It is because
you are forced to use hooks inside hooks.
A global blacklist is less bizarre but still confusing if you just know
about flymake-diagnostic-functions. What about taking advantage of the
fact that erroring backends disable themselves with this fun hack?
(defun blacklist (&rest _args) (error "blacklisted"))
(advice-add 'elisp-flymake-checkdoc :around 'blacklist)
(advice-remove 'elisp-flymake-checkdoc 'blacklist) ; regret it
>> * flymake-no-changes-timeout (set to nil to disable automatic idle-checking)
>> * flymake-start-syntax-check-on-find-file
>>
>> The "on save" behaviour isn't very easy to configure yet. The names
>> aren't brilliant, they're inherited from old Flymake.
>
> Oh ok, thanks. I missed the latter two variables.
I thought you were going to ask for per-backend values. In that
hypothetical case, then I guess these varaibles could also take on
functions of a single argument as values. The argument would be the
backend and the return value would be used. Kinda tricky (but not
impossible) for flymake-no-changes-timeout though (perhaps only
nil/non-nil should be allowed for that one.)
João
next prev parent reply other threads:[~2017-10-06 22:03 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 14:27 Flymake refactored João Távora
2017-09-28 19:52 ` Stefan Monnier
2017-09-29 0:22 ` João Távora
2017-09-29 3:11 ` Stefan Monnier
2017-10-01 16:52 ` João Távora
2017-10-01 20:50 ` Stefan Monnier
2017-10-02 1:01 ` João Távora
2017-10-02 3:12 ` Stefan Monnier
2017-10-03 0:33 ` João Távora
2017-10-03 1:09 ` Stefan Monnier
2017-09-29 12:51 ` Dmitry Gutov
2017-09-29 14:55 ` Ted Zlatanov
2017-09-29 15:03 ` Dmitry Gutov
2017-09-29 16:26 ` Ted Zlatanov
2017-09-29 17:35 ` Dmitry Gutov
2017-09-29 17:56 ` Ted Zlatanov
2017-09-30 15:07 ` Dmitry Gutov
2017-09-30 7:55 ` Marcin Borkowski
2017-09-30 23:43 ` João Távora
2017-10-01 8:53 ` Marcin Borkowski
2017-10-01 11:54 ` Mark Oteiza
2017-10-04 17:37 ` Simen Heggestøyl
2017-10-05 2:08 ` João Távora
2017-10-05 3:52 ` Mark Oteiza
2017-10-05 10:57 ` João Távora
2017-10-05 13:11 ` Stefan Monnier
2017-10-05 14:45 ` João Távora
2017-10-05 23:01 ` João Távora
2017-10-05 21:22 ` Mark Oteiza
2017-10-05 23:05 ` João Távora
2017-10-06 3:35 ` Stefan Monnier
2017-10-06 7:09 ` Lele Gaifax
2017-10-06 8:14 ` Eli Zaretskii
2017-10-06 8:19 ` Lele Gaifax
2017-10-06 9:48 ` Eli Zaretskii
2017-10-06 9:54 ` Lele Gaifax
2017-10-06 13:04 ` Mark Oteiza
2017-10-06 14:47 ` Lele Gaifax
2017-10-06 15:21 ` Mark Oteiza
2017-10-06 15:26 ` Mark Oteiza
2017-10-06 15:28 ` Lele Gaifax
2017-10-06 16:28 ` João Távora
2017-10-06 19:24 ` Lele Gaifax
2017-10-06 15:13 ` João Távora
2017-10-07 13:28 ` Stefan Monnier
2017-10-07 13:44 ` Eli Zaretskii
2017-10-07 14:40 ` Lele Gaifax
2017-10-07 14:52 ` Eli Zaretskii
2017-10-08 2:06 ` Stefan Monnier
2017-10-08 9:32 ` João Távora
2017-10-08 11:24 ` Lele Gaifax
2017-10-08 14:17 ` Stefan Monnier
2017-10-08 23:33 ` João Távora
2017-10-09 3:01 ` Stefan Monnier
2017-10-09 10:19 ` João Távora
2017-10-09 15:50 ` [SUSPECTED SPAM] " Stefan Monnier
2017-10-09 16:33 ` [PATCH] " Lele Gaifax
2017-10-07 6:31 ` Marcin Borkowski
2017-10-07 13:37 ` Stefan Monnier
2017-10-07 16:48 ` Marcin Borkowski
2017-10-06 12:54 ` John Wiegley
2017-10-06 15:17 ` Mark Oteiza
2017-10-06 16:04 ` João Távora
2017-10-06 21:22 ` Mark Oteiza
2017-10-06 22:03 ` João Távora [this message]
2017-10-07 13:31 ` Stefan Monnier
2017-10-07 16:02 ` João Távora
2017-10-07 16:07 ` João Távora
2017-10-07 18:18 ` Mark Oteiza
2017-10-08 9:06 ` João Távora
2017-10-08 12:51 ` Mark Oteiza
2017-10-08 23:21 ` João Távora
2017-10-10 14:27 ` Mark Oteiza
2017-10-10 15:20 ` João Távora
2017-10-10 16:10 ` Mark Oteiza
2017-10-05 11:28 ` Lele Gaifax
2017-10-05 15:12 ` Lele Gaifax
2017-10-10 10:40 ` Lele Gaifax
2017-10-10 12:27 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp48x7bo.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=mvoteiza@udel.edu \
--cc=sdl.web@gmail.com \
--cc=simenheg@gmail.com \
--cc=steve@sanityinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.