From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Something weird with when-let*/if-let* Date: Sun, 15 Oct 2017 20:23:20 -0700 Message-ID: <87wp3vepxz.fsf@ericabrahamsen.net> References: <877evy2am9.fsf@ericabrahamsen.net> <87shel27rc.fsf@ericabrahamsen.net> <87efq51r12.fsf@ericabrahamsen.net> <8760bh1oqj.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1508124326 12338 195.159.176.226 (16 Oct 2017 03:25:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Oct 2017 03:25:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 16 05:25:23 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3w1m-0002BQ-Vv for ged-emacs-devel@m.gmane.org; Mon, 16 Oct 2017 05:25:19 +0200 Original-Received: from localhost ([::1]:59164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3w1u-0000Jf-Ch for ged-emacs-devel@m.gmane.org; Sun, 15 Oct 2017 23:25:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3w1n-0000JF-Rh for emacs-devel@gnu.org; Sun, 15 Oct 2017 23:25:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3w1k-0005SZ-Gg for emacs-devel@gnu.org; Sun, 15 Oct 2017 23:25:19 -0400 Original-Received: from [195.159.176.226] (port=55452 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3w1k-0005S3-9I for emacs-devel@gnu.org; Sun, 15 Oct 2017 23:25:16 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1e3w1Y-0000Ya-Ie for emacs-devel@gnu.org; Mon, 16 Oct 2017 05:25:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 15 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:y67GESL3gOlBEH1N5nft6Vvyvsw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219564 Archived-At: Stefan Monnier writes: >> Besides message.el, nnimap.el is the only gnus lib to use when-let*. >> I can just add another subr-x require in nnimap for now -- if it starts > > That's indeed what should be done, regardless of what message.el does: > if a foo.el uses a macro defined in bar.el, it should generally require > that bar.el directly rather than rely on some toto.el file to load it. > > I'm not saying that we follow this rule all the time, but in my > experience, this is a sane rule to follow. The downside is really > negligible: if foo.el requires foo.el which also requires bar.el, the > extra/redundant (require 'bar) will cost very little anyway. Done!