all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 28997@debbugs.gnu.org
Subject: bug#28997: 27.0.50; Error in async shell-command process filter
Date: Tue, 31 Oct 2017 06:48:52 -0400	[thread overview]
Message-ID: <87wp3ba8yz.fsf@users.sourceforge.net> (raw)
In-Reply-To: <8737672pna.fsf@gmail.com> (Basil L. Contovounesios's message of "Wed, 25 Oct 2017 16:50:01 +0100")

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> The first patch replaces the quoted lambda process filter
> with a closure over the name of output-buffer.  By keeping
> track of this name, a lot of the surrounding
> buffer-name-determining code can be simplified via DRY.

This looks good to me.

> The second patch is purely aesthetic and simplifies the cond
> that is touched by my first patch into an equivalent pcase.

I'm not sure about this one.  There was some contention in the past over
use of pcase, with some suggestions even to make an opposite
transformation, e.g., [1].

[1]: https://lists.gnu.org/archive/html/emacs-devel/2016-01/msg00055.html





  parent reply	other threads:[~2017-10-31 10:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-25 15:50 bug#28997: 27.0.50; Error in async shell-command process filter Basil L. Contovounesios
     [not found] ` <handler.28997.B.150894878317903.ack@debbugs.gnu.org>
2017-10-26 18:20   ` bug#28997: Acknowledgement (27.0.50; Error in async shell-command process filter) Basil L. Contovounesios
2017-10-31 10:48 ` Noam Postavsky [this message]
2017-10-31 11:30   ` bug#28997: 27.0.50; Error in async shell-command process filter Basil L. Contovounesios
2017-10-31 11:44   ` Basil L. Contovounesios
2017-11-02 13:26   ` Basil L. Contovounesios
2017-11-02 15:57     ` Eli Zaretskii
2017-11-02 23:55       ` Basil L. Contovounesios
2017-11-03  7:24         ` Eli Zaretskii
2017-11-03 10:02           ` Basil L. Contovounesios
2017-11-03  9:52 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp3ba8yz.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=28997@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.