From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jay Kamat Newsgroups: gmane.emacs.bugs Subject: bug#29821: Ensure quick substitution only occurs at start of line Date: Tue, 02 Jan 2018 09:48:00 -0800 Message-ID: <87wp105ezz.fsf@gmail.com> References: <87fu8272h6.fsf@gmail.com> <87shbqto33.fsf@users.sourceforge.net> <87wp11rqtr.fsf@users.sourceforge.net> <871sj96lgu.fsf@gmail.com> <87tvw4syi9.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1514915239 29720 195.159.176.226 (2 Jan 2018 17:47:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Jan 2018 17:47:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29821@debbugs.gnu.org, Andreas Schwab To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 02 18:47:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWQeb-00078Q-Cf for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jan 2018 18:47:09 +0100 Original-Received: from localhost ([::1]:50071 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWQga-0001YK-K7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jan 2018 12:49:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWQgU-0001Vm-Oz for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 12:49:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWQgQ-0001f1-Lw for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 12:49:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52946) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWQgQ-0001eT-He for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 12:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eWQgQ-000398-4c for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2018 12:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jay Kamat Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jan 2018 17:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29821 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29821-submit@debbugs.gnu.org id=B29821.151491529212037 (code B ref 29821); Tue, 02 Jan 2018 17:49:02 +0000 Original-Received: (at 29821) by debbugs.gnu.org; 2 Jan 2018 17:48:12 +0000 Original-Received: from localhost ([127.0.0.1]:33394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWQfb-000385-Q8 for submit@debbugs.gnu.org; Tue, 02 Jan 2018 12:48:12 -0500 Original-Received: from mail-pf0-f174.google.com ([209.85.192.174]:35697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWQfa-00037q-4B for 29821@debbugs.gnu.org; Tue, 02 Jan 2018 12:48:10 -0500 Original-Received: by mail-pf0-f174.google.com with SMTP id j124so25929578pfc.2 for <29821@debbugs.gnu.org>; Tue, 02 Jan 2018 09:48:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=33awApRBJvMfDQxlLK5sZ3cLsgqmt8NtqpAQwmsYb98=; b=W5HjHBVw7K2aTznDncwtNwl8xGbGqkW3idan84SQGJSyjVr3muTGxbZYyrfHCch+kJ Pg0QbA7aRjxBTAwYvjwlCU5YpGpcOe45CCvOAVIxsznWzdO+kEGt8K/ubTyuhCOmDToz gMa/euJJxBWl5a/WUrXLrozg9LNjl/DskFUNhmzKQY5zmCJnOaQ++TlU01XH7UAtgKs8 tcDlHyuNRyf9Hl3TZwdL1Ba5RB+PrnsKss1nX1z4OSsNepbTFTdE/AAVEq3y9YC/isJu oGkkx0PzSU9PsIB36uh/xnATV2lMgcGMc+Ie+pTqYhW3FOBn3KkXuGrOkU1iEltl88T7 5ejw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=33awApRBJvMfDQxlLK5sZ3cLsgqmt8NtqpAQwmsYb98=; b=KN8VmFvg7KpPnkS/upryGlvQuEFC8TjIuUWh2fTiNpJWT8q3GiWLxZlAFZIVE4ubkF R7w3QD4X40z0w5zlFxo3rlLhiyjf0X0PqOCt2odrxbKu6N2PczlcNhSFzWJh1Q+4UjW2 xEGG2HhmOhjrZEj6HX18OyCiadzpGNWb1RArxYNfL1U48j/JORnXVfRQnuRcUddEOFXa hwE2fIZdMjKmzekU/FGoivdj21hLcSZfFx9AuCZu0J48uVQbBFOZQ50uKBaraRfPQnpD yerhlPycGppq7TQh/+EMoJ1uEXtn0lTFUa03jkKKjTz0J2U15IKpZRkhRoVNOG7vAUYB jYTQ== X-Gm-Message-State: AKGB3mJIq484NaiOtK15i1mn+AtBP5aJL3/iXWJ74tslqvsd2ASM43qd PgcPV4BprRcb8tF05xFwbE0= X-Google-Smtp-Source: ACJfBosNi/ySRGLdKOTUSkyOlbmSXWM47h/MQHcEXMagJgX2e4i8IxGhR3TAOW7AABCDUKOV9VE9ow== X-Received: by 10.101.65.205 with SMTP id b13mr25543671pgq.30.1514915282018; Tue, 02 Jan 2018 09:48:02 -0800 (PST) Original-Received: from laythe (c-67-161-9-47.hsd1.ca.comcast.net. [67.161.9.47]) by smtp.gmail.com with ESMTPSA id c2sm22930661pgq.48.2018.01.02.09.48.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Jan 2018 09:48:01 -0800 (PST) In-Reply-To: <87tvw4syi9.fsf@users.sourceforge.net> (Noam Postavsky's message of "Mon, 01 Jan 2018 22:58:06 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141713 Archived-At: Noam Postavsky writes: > Couldn't you error here (if the line matches ^...^...^) instead of > returning nil, and then avoid affecting the other substitution? > (although I agree signaling an error in the other place is probably > acceptable) I could be missing something, but I don't think this is that easy. In the case of a failed search for something like '!!:s/a/b/', `eshell-history-reference' previously returned the previous line, unmodified. I could pull the previous line and compare it with the one returned to see if `eshell-history-reference' has modified it, but I don't like that solution, it seems like a bit of a hack. Let me know if you think that's better though, or if I have it wrong... If we really want to preserve the previous behavior of 'echo "foo"(:s/bar/baz/)', I would prefer setting a lexical variable around functions like `eshell-pred-substitute' so it can figure out which type of substitution it's in and error accordingly. Thanks, -Jay