From: Jay Kamat <jaygkamat@gmail.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 29821@debbugs.gnu.org, Andreas Schwab <schwab@linux-m68k.org>
Subject: bug#29821: Ensure quick substitution only occurs at start of line
Date: Tue, 02 Jan 2018 09:48:00 -0800 [thread overview]
Message-ID: <87wp105ezz.fsf@gmail.com> (raw)
In-Reply-To: <87tvw4syi9.fsf@users.sourceforge.net> (Noam Postavsky's message of "Mon, 01 Jan 2018 22:58:06 -0500")
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> Couldn't you error here (if the line matches ^...^...^) instead of
> returning nil, and then avoid affecting the other substitution?
> (although I agree signaling an error in the other place is probably
> acceptable)
I could be missing something, but I don't think this is that easy. In
the case of a failed search for something like '!!:s/a/b/',
`eshell-history-reference' previously returned the previous line,
unmodified. I could pull the previous line and compare it with the one
returned to see if `eshell-history-reference' has modified it, but I
don't like that solution, it seems like a bit of a hack. Let me know if
you think that's better though, or if I have it wrong...
If we really want to preserve the previous behavior of
'echo "foo"(:s/bar/baz/)', I would prefer setting a lexical variable
around functions like `eshell-pred-substitute' so it can figure out
which type of substitution it's in and error accordingly.
Thanks,
-Jay
next prev parent reply other threads:[~2018-01-02 17:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 23:57 bug#29821: Ensure quick substitution only occurs at start of line Jay Kamat
2018-01-01 0:33 ` Noam Postavsky
2018-01-01 9:56 ` Andreas Schwab
2018-01-02 1:29 ` Noam Postavsky
2018-01-02 2:30 ` Jay Kamat
2018-01-02 3:58 ` Noam Postavsky
2018-01-02 17:48 ` Jay Kamat [this message]
2018-01-03 1:51 ` Noam Postavsky
2018-01-04 1:17 ` Jay Kamat
2018-01-04 3:10 ` Noam Postavsky
2018-01-04 20:26 ` Jay Kamat
2018-01-05 1:04 ` Noam Postavsky
2018-01-05 1:53 ` Jay Kamat
2018-01-05 14:31 ` Noam Postavsky
2018-01-01 23:44 ` Jay Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp105ezz.fsf@gmail.com \
--to=jaygkamat@gmail.com \
--cc=29821@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.