all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: 30539@debbugs.gnu.org
Subject: bug#30539: 26.0; `char-displayable-p' is much slower in Emacs 25 and 26
Date: Thu, 22 Feb 2018 20:49:23 -0500	[thread overview]
Message-ID: <87woz44grg.fsf@gmail.com> (raw)
In-Reply-To: <923b8123-937d-4ffb-9988-5359fdcbb6bc@default> (Drew Adams's message of "Thu, 22 Feb 2018 06:50:34 -0800 (PST)")

Drew Adams <drew.adams@oracle.com> writes:

> Can someone please confirm that they can repro this problem?

I can reproduce on a Windows 10 box.  It looks like something was being
cached before, where now it's not.  E.g., try the following function
(char-names as defined in your throw-mule-bug-2.el).  In Emacs 24,
there's only one slow call.

(defun my-test-each-char ()
  (interactive)
  (view-echo-area-messages)
  (pcase-dolist (`(,name . ,ch) char-names)
    (read-char (format "continue? (next: %s)" name))
    (let ((t0 (current-time))
          dt displayable)
      (setq displayable (char-displayable-p ch))
      (setq dt (subtract-time (current-time) t0))
      (message "%s display:%s (%fs)" name displayable (float-time dt)))))

Doing (setq inhibit-compacting-font-caches t) brings back reasonable
performance.

I can't reproduce on my GNU/Linux box, although that may just be due to
different fonts installed.  In particular, char-displayable-p never gave
me nil.





  reply	other threads:[~2018-02-23  1:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 22:07 bug#30539: 26.0; `char-displayable-p' is much slower in Emacs 25 and 26 Drew Adams
2018-02-20 18:08 ` Drew Adams
2018-02-22 14:50   ` Drew Adams
2018-02-23  1:49     ` Noam Postavsky [this message]
2018-02-23  2:43       ` Drew Adams
2018-02-23  3:32         ` Noam Postavsky
2018-02-23  4:07           ` Drew Adams
2018-02-23  7:14             ` Eli Zaretskii
2020-06-27 21:34           ` Drew Adams
2020-11-18 15:35       ` Stefan Kangas
2020-11-18 17:21         ` Eli Zaretskii
2020-11-18 18:30           ` Stefan Kangas
2018-02-28 19:21   ` Charles A. Roelli
     [not found] <<8c79c39f-7abb-4591-a676-17fb46af5a8f@default>
     [not found] ` <<ec3497d7-9a7d-4be8-8712-19bb6bdd96e8@default>
     [not found]   ` <<m2d10oj4xj.fsf@aurox.ch>
2018-02-28 19:53     ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woz44grg.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=30539@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.