From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom. Date: Tue, 27 Feb 2018 23:39:13 +0200 Organization: LINKOV.NET Message-ID: <87woyyr7a6.fsf@mail.linkov.net> References: <20180221213025.27066.69339@vcs0.savannah.gnu.org> <20180221213027.372932052F@vcs0.savannah.gnu.org> <32a4ebb4-5977-9805-c226-ec4666bc31aa@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1519767503 12964 195.159.176.226 (27 Feb 2018 21:38:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Feb 2018 21:38:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org, Dmitry Gutov To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 27 22:38:19 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqmx0-0002wf-5z for ged-emacs-devel@m.gmane.org; Tue, 27 Feb 2018 22:38:18 +0100 Original-Received: from localhost ([::1]:40238 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqmz2-0001BD-AP for ged-emacs-devel@m.gmane.org; Tue, 27 Feb 2018 16:40:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqmyC-0001B2-Mz for emacs-devel@gnu.org; Tue, 27 Feb 2018 16:39:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqmy9-0004Yh-LK for emacs-devel@gnu.org; Tue, 27 Feb 2018 16:39:32 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:49601 helo=homiemail-a20.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqmy9-0004Vu-Eg for emacs-devel@gnu.org; Tue, 27 Feb 2018 16:39:29 -0500 Original-Received: from homiemail-a20.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a20.g.dreamhost.com (Postfix) with ESMTP id 527897EC07D; Tue, 27 Feb 2018 13:39:27 -0800 (PST) Original-Received: from localhost.linkov.net (m91-129-98-215.cust.tele2.ee [91.129.98.215]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a20.g.dreamhost.com (Postfix) with ESMTPSA id 438667EC076; Tue, 27 Feb 2018 13:39:26 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Sun, 25 Feb 2018 22:24:38 -0500") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 69.163.253.7 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223142 Archived-At: >>>> +(defcustom next-error-find-buffer-function nil >>> Why make it a defcustom rather than a defvar? >> I think we'll want to provide a set of predefined functions in the fut= ure, >> for the user to choose one from. > > So a defcustom makes sense, good. > >>>> + (when next-error-find-buffer-function >>>> + (funcall next-error-find-buffer-function avoid-current >>>> + extra-test-inclusive >>>> + extra-test-exclusive)= ) >>> Could you arrange for the default value of this new *-function var no= t >>> to be nil so we can modify it with add-function? >> Personally, I don't really expect this variable to be modified >> programmatically. And if it is, most likely not in a "function >> combination" fashion. > > But using `ignore` instead of `nil` both simplifies the code and makes > the var compatible with add-function, so it doesn't matter if > `add-function` is really useful with it. So I just changed the default value from nil to =E2=80=98ignore=E2=80=99.