From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#18207: erc-truncate-buffer-on-save: misleading variable name and docstring Date: Sat, 14 Apr 2018 20:53:09 +0200 Message-ID: <87wox939ii.fsf@mouse.gnus.org> References: <87vbq5ucqa.fsf@violet.siamics.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1523731934 6357 195.159.176.226 (14 Apr 2018 18:52:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Apr 2018 18:52:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 18207@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 14 20:52:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7QHQ-0001WW-DV for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Apr 2018 20:52:08 +0200 Original-Received: from localhost ([::1]:56728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7QJX-0004fV-4A for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Apr 2018 14:54:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7QJK-0004do-UD for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 14:54:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7QJH-0006gy-22 for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 14:54:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44753) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f7QJG-0006gn-Qb for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 14:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f7QJG-0001cO-EI for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 14:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Apr 2018 18:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18207 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18207-submit@debbugs.gnu.org id=B18207.15237320016156 (code B ref 18207); Sat, 14 Apr 2018 18:54:02 +0000 Original-Received: (at 18207) by debbugs.gnu.org; 14 Apr 2018 18:53:21 +0000 Original-Received: from localhost ([127.0.0.1]:52648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7QIb-0001bB-9R for submit@debbugs.gnu.org; Sat, 14 Apr 2018 14:53:21 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:56040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7QIa-0001b1-1r for 18207@debbugs.gnu.org; Sat, 14 Apr 2018 14:53:20 -0400 Original-Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f7QIX-00076Q-48; Sat, 14 Apr 2018 20:53:19 +0200 Original-Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f7QIQ-00072I-1q; Sat, 14 Apr 2018 20:53:10 +0200 In-Reply-To: <87vbq5ucqa.fsf@violet.siamics.net> (Ivan Shmakov's message of "Wed, 06 Aug 2014 10:35:57 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145359 Archived-At: Ivan Shmakov writes: > The docstring for erc-truncate-buffer-on-save reads: > > Truncate any ERC (channel, query, server) buffer when it is saved. > > This is somewhat misleading, as there=E2=80=99re also erc-truncate > module, and, in particular, =E2=80=93 the erc-truncate-buffer function, > which are used to truncate buffer /to a given size/ (see > erc-max-buffer-size.) On the contrary, this variable, when > non-nil, forces the buffer to be /completely erased,/ as per the > following lisp/erc/erc-log.el fragment: > > 434 (if (and erc-truncate-buffer-on-save > 435 (called-interactively-p 'interactive)) > 436 (progn > 437 (let ((inhibit-read-only t)) (erase-buffer)) > 438 (move-marker erc-last-saved-position (point-max)) > 439 (erc-display-prompt)) > > I believe that this behavior should be made clear in the > documentation, like: > > Erase ERC (channel, query, server) buffers when one is saved. I've now made a similar change to Emacs 27.1. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no