From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Nutt Newsgroups: gmane.emacs.bugs Subject: bug#31941: 26.1; Moving directory on remote host via tramp scp always performs copy Date: Fri, 22 Jun 2018 14:33:50 -0500 Message-ID: <87wouqaa5d.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529696348 32337 195.159.176.226 (22 Jun 2018 19:39:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Jun 2018 19:39:08 +0000 (UTC) To: 31941@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 22 21:39:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWRtd-0008HS-V9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jun 2018 21:39:02 +0200 Original-Received: from localhost ([::1]:35859 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWRvl-00080s-3j for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jun 2018 15:41:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWRvb-0007zc-A8 for bug-gnu-emacs@gnu.org; Fri, 22 Jun 2018 15:41:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWRva-0000lE-KD for bug-gnu-emacs@gnu.org; Fri, 22 Jun 2018 15:41:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52693) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWRva-0000lA-Ff for bug-gnu-emacs@gnu.org; Fri, 22 Jun 2018 15:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fWRva-0001cX-6e for bug-gnu-emacs@gnu.org; Fri, 22 Jun 2018 15:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Nutt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jun 2018 19:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31941 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15296964096161 (code B ref -1); Fri, 22 Jun 2018 19:41:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Jun 2018 19:40:09 +0000 Original-Received: from localhost ([127.0.0.1]:60590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWRuh-0001bG-QG for submit@debbugs.gnu.org; Fri, 22 Jun 2018 15:40:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWRrq-0001WX-8K for submit@debbugs.gnu.org; Fri, 22 Jun 2018 15:37:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWRrk-0007bL-C0 for submit@debbugs.gnu.org; Fri, 22 Jun 2018 15:37:05 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:60430) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fWRrk-0007bH-8Y for submit@debbugs.gnu.org; Fri, 22 Jun 2018 15:37:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWRrj-00054O-7V for bug-gnu-emacs@gnu.org; Fri, 22 Jun 2018 15:37:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWRri-0007ao-Gs for bug-gnu-emacs@gnu.org; Fri, 22 Jun 2018 15:37:03 -0400 Original-Received: from mail-ot0-x22e.google.com ([2607:f8b0:4003:c0f::22e]:41963) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWRri-0007a3-Bf for bug-gnu-emacs@gnu.org; Fri, 22 Jun 2018 15:37:02 -0400 Original-Received: by mail-ot0-x22e.google.com with SMTP id d19-v6so8714292oti.8 for ; Fri, 22 Jun 2018 12:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=LpJbjHxjUoWdSfNpzRCtYfYVHrxaMrxetKfA636MfaY=; b=aO7LvwsV50EoSZs1+BDe8eAvQejkzV9hB3g0TWghsgt9UNWFlh8HvdfkrWNzELmpEM L9Cr6exSPKH8I0KF523eqkSNVUjpQ/WdQidY9aN9kcvclel6RHMuTTSQhgXLZWACu9HS NRONLUeqodDOanlt712sEU4SVDd51dZwnl4s4ZYATGYYvVinlofgV8ypuAKp3vGkj2Rs 8sFtISB0iPMxd5fD2d98W8AXUvAg4AEsZSY0BCAZOmhepkqRfOiTYvhKrkIez04Etbtc zJyDb4iQNkJfmbmL/fFK37ATcBdnnjIR+e6EzVSvLHs0F0ANmq8YNw8M1WGkFdntqbqR 5AYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=LpJbjHxjUoWdSfNpzRCtYfYVHrxaMrxetKfA636MfaY=; b=iaFC8l01/075aBSeOlvUBf1reQzeHJ7o92I0+hRlAXz6FJAHPLosSctLWrsaYuEwBZ xWSkZ5okctGPEJqZBzGyScQWCSv+vBixEaepXl6MQTjuafYjZZPfq6MusGeJ4IqSLNPZ VATjA4DwK4K4fMkKjpkCQK+2/F6oGtiqjpMx+2OAC8XWslYE/0CwCV90qW+Np8UpAUmS Ucvay2wt3TPm4yMr/QoO22YIOZ+uJkXItjMJEZQkAukDyWSyKbc5+Nqa7dAGQWRI2+Ux GXgFoRi8li0tRrskk1NaShnZUgG5TFSIl1EFmRKdQ7zgNAOIU+W/1ReyvXKsnPMMMVKD PdGQ== X-Gm-Message-State: APt69E20zkLhbARMBpyUQauUK8HMzconDgdD/08ST8eouNlm1X2Ile/I Ae09YhnLvdezERRB3NEn0IGYSq5d X-Google-Smtp-Source: ADUXVKImnR7Lx1w5jewBBUD550MH7KAmogRc3L2S402zj8yDmZqkIaxpN2ABdz7o4s2vspKg4Lj1aA== X-Received: by 2002:a9d:3578:: with SMTP id l53-v6mr1857257ote.15.1529696221191; Fri, 22 Jun 2018 12:37:01 -0700 (PDT) Original-Received: from book ([2605:6000:1523:159:6e29:95ff:fee6:ff96]) by smtp.gmail.com with ESMTPSA id a52-v6sm6532846ote.30.2018.06.22.12.37.00 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Jun 2018 12:37:00 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Fri, 22 Jun 2018 15:40:06 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147748 Archived-At: In Emacs 26, when moving a directory within a remote host over Tramp using the scp method (e.g. with dired-do-rename or mv in eshell), a copy and delete are always performed, even when a much simpler mv would suffice. The behavior is the same when running emacs with -q or with emacs built from master. This is a regression from the behavior in 25.3. I think I've isolated the change to the commit b500e0 where the following was added at the beginning of `tramp-do-copy-or-rename-file' in tramp-sh.el to explicitly call `copy-directory'. (if (file-directory-p filename) (progn (copy-directory filename newname keep-date t) (when (eq op 'rename) (delete-directory filename 'recursive))) I think the conditional should also check if op is a rename and if the remote of filename and newname are the same, in which case the normal behavior of the function should proceed which should result in a mv command.