From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Rolf Ade Newsgroups: gmane.emacs.bugs Subject: bug#23565: 24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable Date: Thu, 05 Jul 2018 00:10:22 +0200 Message-ID: <87woua8xf5.fsf@pointsman.de> References: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> <871scw3x6g.fsf@tromey.com> <87zhz99742.fsf@pointsman.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1530742147 16260 195.159.176.226 (4 Jul 2018 22:09:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Jul 2018 22:09:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 23565@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 05 00:09:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fapxO-000480-LD for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jul 2018 00:09:02 +0200 Original-Received: from localhost ([::1]:49391 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fapzV-0007CC-IS for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Jul 2018 18:11:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fapzP-0007C6-57 for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 18:11:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fapzK-0006cc-5b for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 18:11:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39159) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fapzK-0006cS-0y for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 18:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fapzJ-0003Ak-SB for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 18:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Rolf Ade Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jul 2018 22:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23565 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 23565-submit@debbugs.gnu.org id=B23565.153074223112156 (code B ref 23565); Wed, 04 Jul 2018 22:11:01 +0000 Original-Received: (at 23565) by debbugs.gnu.org; 4 Jul 2018 22:10:31 +0000 Original-Received: from localhost ([127.0.0.1]:47056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fapyn-00039x-Ec for submit@debbugs.gnu.org; Wed, 04 Jul 2018 18:10:31 -0400 Original-Received: from mxout3.interscholz.de ([85.236.196.238]:55304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fapyj-00039l-Hl for 23565@debbugs.gnu.org; Wed, 04 Jul 2018 18:10:27 -0400 Original-Received: from localhost (mxout3 [127.0.0.1]) by mxout3.interscholz.de (Postfix) with ESMTP id 358F522288; Thu, 5 Jul 2018 00:10:24 +0200 (CEST) X-Virus-Scanned: interscholz amavisd-new at mxout3.interscholz.de Original-Received: from server.web01.interscholz.net (server.web01.interscholz.net [85.236.196.138]) by mxout3.interscholz.de (Postfix) with ESMTP id 8D28B21471; Thu, 5 Jul 2018 00:10:23 +0200 (CEST) Original-Received: from linux-qg7d (p5B3177C9.dip0.t-ipconnect.de [91.49.119.201]) by server.web01.interscholz.net (Postfix) with ESMTPSA id E65C1F0001; Thu, 5 Jul 2018 00:10:22 +0200 (CEST) In-Reply-To: <87zhz99742.fsf@pointsman.de> (Rolf Ade's message of "Mon, 02 Jul 2018 14:04:13 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148207 Archived-At: Rolf Ade writes: > Tom Tromey writes: >> I've checked in a fix for the tcl-end-of-defun problem. >> I think it should fix tcl-eval-defun as well, but I didn't test this. > > I've build current master and did a few tests. Yes, it seems, that > tcl-end-of-defun as well as tcl-eval-defun now work for me as expected, > even in the reported-as-broken cases. > > I'll copy masters tcl-mode.el over to my currently used 26.1 > installation (and bytecompile, of course) and give it a try in my daily > Tcl coding, for a few days, to see, if I stumble over any unexpected > side-effect of the changes. > > I'll report in a week or at most two (it varies a bit how much Tcl > coding I have to do and this is driven by others). Well, beside the improvement (tcl-end-of-defun and tcl-eval-defun does work better), which I again confirm I see one more (unexpected and unwanted) effect. With emacs 26.1: - emacs -Q - M-x tcl-mode - Insert do { foo Indent the second line ("foo") with and you get do { foo Do the same with master and you get do { foo the second line ("foo") does not get indented with . Something is special with "proc". If there is a proc before such code as above the indentation works even with master, e.g. with proc do {script} { eval $script } do { foo the line "foo" will be indented by with 26.1 and master.