From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: Clarify `pcase' `rx' pattern doc Date: Sat, 07 Jul 2018 16:35:32 +0200 Message-ID: <87wou7dsgb.fsf@web.de> References: <87fu1rqr6m.fsf@web.de> <87in6gff2t.fsf@web.de> <83wouwrq3d.fsf@gnu.org> <87tvpw4cjt.fsf@web.de> <83vaacqjpl.fsf@gnu.org> <87lgb841g0.fsf@web.de> <831scxvd5a.fsf@gnu.org> <87bmbk4586.fsf@web.de> <834lhbleol.fsf@gnu.org> <8736wvf9rv.fsf@web.de> <83va9ri1wh.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1530974055 26523 195.159.176.226 (7 Jul 2018 14:34:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Jul 2018 14:34:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 07 16:34:11 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fboHq-0006kO-J3 for ged-emacs-devel@m.gmane.org; Sat, 07 Jul 2018 16:34:10 +0200 Original-Received: from localhost ([::1]:33891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fboJx-0005Gn-G8 for ged-emacs-devel@m.gmane.org; Sat, 07 Jul 2018 10:36:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fboJJ-0005GV-Lk for emacs-devel@gnu.org; Sat, 07 Jul 2018 10:35:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fboJI-0006bG-MQ for emacs-devel@gnu.org; Sat, 07 Jul 2018 10:35:41 -0400 Original-Received: from mout.web.de ([212.227.15.14]:60079) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fboJD-0006Xy-3D; Sat, 07 Jul 2018 10:35:35 -0400 Original-Received: from drachen.dragon ([94.216.139.22]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Mg7Vd-1fPvgf43Yj-00NONw; Sat, 07 Jul 2018 16:35:33 +0200 In-Reply-To: <83va9ri1wh.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 Jul 2018 16:57:50 +0300") X-Provags-ID: V03:K1:BsZ0gJ1kF8T/B7R92U+wPHrulhSeF3ifXcrM/khn8+XZvY4bAwx zFxJgnb2MUSWNafJiSz8DRNH1rLr3yswRkLMDaZOwNLdSfbAA2Z7DRzBltfa29TZFXzMCXl muszA2PY6h9c30vqL/JfYLTeyhSrHWZlG7i9ZbqR4Gt/Ovqkry47s4m0lY03QSvxCTKvJp8 XvGgk2qiYPtqS/kYgD+Qg== X-UI-Out-Filterresults: notjunk:1;V01:K0:gpQy6OCjmFo=:nKFrrx/8/pWEzfnHFp8f0t g25++Hvza3sKaFgu1d0xsbAdoMZvUtzPsz0sdFMyW302Nw36/+i4r3WR0wkXGDCWGSGaXV7rT Fa9PPOmmnxlZlSnW3sP0YvLzQ23zI2Mpqwg7DkEmi/BxV75wW5jyIzyzFg1YZ2vWY3+BXGAcX PTLBG7H493a4PESI6xyRmjbz8KCz1Z9S08SgBjqe5BOKFonKYtnRpRSCQdPUK911B9UsnVoZg fqW36S6b0Ed27YjwXSUekmwGuvJADmu/u66uK42HwlJ9+2tc4pc/IDPm4SUHoR4IEBcef73NH tUh32lTX1/mBNjr7n3/ZaUWTg+XGswbMNkU5g3rAQkYDnFUApq6vPoNekU2mp1WScUKtDeh/5 51AmyEMKKpkSpR1G8GAesID3/Kn/GHmdP7Dc+FApiP0rVC5nvnPJJy57C9Th/IMwH7r0L+t8n dTYg9y35Og3s7ApUgMDk9fynwGlAM9FsJbwjCZUMAqhnYLxxfCEE0MzyX1EcX4dLLWZZ42X+W CD1kc0bLV0W3bi2EaGXLKNRFBiNXDp2CoWwzmo3cGhi2aBbSy0WnKzFpJ9B8s+YA4kmNM+ZLW atT8OigKpy2zRxvt221+H5QcKibVNu8bb+CPmhJyXHTf533qDCDfBtrhkQcgI1bYNuqp71rUL 6UTJazArbp88NtIJ12vDgzZ2jW+DdGzeHvjKHL0+k3jUh5NAeOpfbblhaLX3qgKhlOexqt1bM 7Tj3inM7mrUVsmPeS1Lj6R2aNMJ8yDOlxPD90+GZyR1Yi0GbwjRiyCHs6BrpBXvFL/yBQ/De X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.14 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227061 Archived-At: Eli Zaretskii writes: > > > > > + [...] If the target is not a string, signal an error. > > > > > > > > We want to change that, so I think you can drop that sentence. > > > > > > Shouldn't it be dropped when that change is committed? > > > > Then we would break documented behavior then. What would be the gain? > > Sorry, I must be confused about this. You said "we want to change > that", so I interpreted that to mean that such a change was not yet > done and will be done shortly. IMO, changes in documentation should > be committed together with code changes that modify the behavior > described in the documentation, thus my question. Did I > misunderstand? No, I don't think so. > If you fear that having this sentence in the doc string will somehow > preclude us from making the code change, or make it harder, then the > doc string already says that, so if there's a problem, it is already > with us, no? No, my fear is that users or package maintainers rely on what we document now although we surely know what we add to the docs won't hold later. IOW, what you suggest to document is a misfeature we want to get rid of very soon. I intend to do this right after this commit we speak about here (but in master). The main effect would be a merge conflict. > > AFAIK, in `let' VAR must be a symbol, but it seems the submatch is also > > numbered as side effect, e.g. > > > > (pcase "Hala" > > ((rx "H" (let x "a") (regex ".*") (backref 1)) x)) > > ==> "a" > > So you agree that "explicitly named" is a better wording? I think it would be an improvement, yes. Michael.