From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#32990: 26.1.50; isearch-forward + t-m-m/mark-active doc Date: Thu, 22 Nov 2018 00:31:45 +0200 Organization: LINKOV.NET Message-ID: <87wop6f4fi.fsf@mail.linkov.net> References: <83muroyzfk.fsf@gnu.org> <83woqrx9pt.fsf@gnu.org> <835zy3tfrb.fsf@gnu.org> <83bm7pueej.fsf@gnu.org> <834ld6m5jk.fsf@gnu.org> <831s7tauzy.fsf@gnu.org> <87sgzzwisx.fsf@mail.linkov.net> <87o9ak4ttv.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1542841027 19381 195.159.176.226 (21 Nov 2018 22:57:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Nov 2018 22:57:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 32990@debbugs.gnu.org To: charles@aurox.ch (Charles A. Roelli) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 21 23:57:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbQc-0004ve-4x for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Nov 2018 23:57:02 +0100 Original-Received: from localhost ([::1]:42894 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPbSi-0001TD-JS for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Nov 2018 17:59:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPbF6-0005Ig-Jc for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 17:45:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPbF1-0008Ho-D4 for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 17:45:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36057) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPbF0-0008GD-FW for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 17:45:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gPbF0-0004sk-7w for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 17:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Nov 2018 22:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32990 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32990-submit@debbugs.gnu.org id=B32990.154284024518672 (code B ref 32990); Wed, 21 Nov 2018 22:45:02 +0000 Original-Received: (at 32990) by debbugs.gnu.org; 21 Nov 2018 22:44:05 +0000 Original-Received: from localhost ([127.0.0.1]:40312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbE5-0004r6-97 for submit@debbugs.gnu.org; Wed, 21 Nov 2018 17:44:05 -0500 Original-Received: from cichlid.maple.relay.mailchannels.net ([23.83.214.36]:48502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPbE3-0004qx-90 for 32990@debbugs.gnu.org; Wed, 21 Nov 2018 17:44:04 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E33083E438C; Wed, 21 Nov 2018 22:44:01 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a37.g.dreamhost.com (unknown [100.96.35.77]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7B0033E49B2; Wed, 21 Nov 2018 22:44:01 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a37.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Wed, 21 Nov 2018 22:44:01 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Squirrel-Imminent: 122ec80e36a8dc6d_1542840241659_3843815499 X-MC-Loop-Signature: 1542840241659:3615622236 X-MC-Ingress-Time: 1542840241659 Original-Received: from pdx1-sub0-mail-a37.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTP id 3DF658092B; Wed, 21 Nov 2018 14:44:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=l8AOlmQf8aYugRa996AB62hdcAM=; b= ArC74ajtrZcJe1hIi4O4cwR5LBzB/CcAWzCkG8GIeGLvcc4PLga6HdM5ueZDPzXw VFrjE6lrnOzOactBBsuxfSSBcxYmg0hTqotLlefp7apEiuvznIQNDIX2AupgE2mv xwxs+a3JvMVh5f39wKB7n/eMcIuoNlrPvUHNgIYNt1A= Original-Received: from mail.jurta.org (m91-129-105-252.cust.tele2.ee [91.129.105.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTPSA id E265680925; Wed, 21 Nov 2018 14:43:58 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a37 In-Reply-To: (Charles A. Roelli's message of "Wed, 21 Nov 2018 21:14:30 +0100") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddtkedgtddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdehrddvhedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedrvdehvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegthhgrrhhlvghssegruhhrohigrdgthhenucevlhhushhtvghrufhiiigvpedt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152652 Archived-At: >> > >From tmm I tried "C==>Cancel last input item DEL", but it does nothing. >> > Do you see the same? >> >> Yes. This may be `with-isearch-suspended's doing (as used in >> `isearch-tmm-menubar'): it pushes a new state of Isearch after running >> its arg BODY, so we will have to compensate for that somehow. > > Should be fixed in the following change based on the latest master. > In with-isearch-suspended, the state of Isearch is now only pushed if > the new state is not `equal' to the state of Isearch we had before > running the body (which should be in (car isearch-cmds), I think). Thanks, I tested your new version and have a few suggestions: 1. There are two menu items with the same action word "Cancel": "Cancel search" "Cancel last input item" This is confusing terminology. I suggest to rename the latter to "Undo last input item" 2. Hard-coding command symbols with '(memq this-command ...' is not a good style. Isearch provides a special feature to put the property 'isearch-scroll' (a misnomer, unfortunately) for the purpose to not hard-code command symbols. 3. Please add a comment to with-isearch-suspended stating that pushing a new state is not necessary for cases that don't change search parameters. So that such commands that use with-isearch-suspended don't need special code to restore an old value of isearch-cmds.