From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: 34898@debbugs.gnu.org
Subject: bug#34898: 24.4; `message-separator' face only works for default value of `mail-header-separator'
Date: Sun, 17 Mar 2019 19:59:41 -0700 [thread overview]
Message-ID: <87wokw3n1e.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <86zhptjnl4.fsf@zoho.eu>
Emanuel Berg <moasenwood@zoho.eu> writes:
> On gmane.emacs.help, Sun, 17 Mar 2019 15:22:50 +0100,
> Damien Collard wrote in Emanuel Berg's thread
> "what has the face `message-separator' *really*
> done for us?"
>
> Well, it seems to only be of effect when
> `mail-header-separator' has its default
> value "--text follows this line--".
> I checked, and
>
> - when it's the default separator, I can
> confirm that changing the face
> `message-separator' does change the
> separator's color.
>
> - when I changed `mail-header-separator' to
> "---" (or anything different from the
> default), the face `message-separator'
> doesn't apply to it anymore!
>
> So it's a bug.
The value of `mail-header-separator' gets added to
`message-font-lock-keywords', which does the actual fontification. Using
setq to change the value of `mail-header-separator' did not change the
font lock keyword, despite setting the variable before message.el is
loaded (or is it pre-loaded?). Using the customize interface to set
`mail-header-separator' *does* work as expected.
Dunno if it's supposed to work this way or not.
Eric
next prev parent reply other threads:[~2019-03-18 2:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 19:41 bug#34898: 24.4; `message-separator' face only works for default value of `mail-header-separator' Emanuel Berg
2019-03-18 2:59 ` Eric Abrahamsen [this message]
2019-03-18 3:14 ` Emanuel Berg
2019-03-18 17:21 ` Basil L. Contovounesios
2019-03-18 22:55 ` Emanuel Berg
2019-03-18 16:46 ` Eli Zaretskii
2019-03-18 16:55 ` Emanuel Berg
2019-03-18 17:01 ` Basil L. Contovounesios
2019-03-18 18:23 ` Basil L. Contovounesios
2019-04-22 23:43 ` Basil L. Contovounesios
2019-05-13 20:00 ` Lars Ingebrigtsen
2019-05-14 1:18 ` Basil L. Contovounesios
2019-03-18 17:14 ` Basil L. Contovounesios
2019-03-18 18:46 ` Eric Abrahamsen
[not found] ` <handler.34898.C.155779671310380.notifdonectrl.0@debbugs.gnu.org>
2019-05-14 11:15 ` bug#34898: acknowledged by developer (Re: bug#34898: 24.4; `message-separator' face only works for default value of `mail-header-separator') Emanuel Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wokw3n1e.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=34898@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.