bug#4410: 23.1.50; copy-file get wrong number of args with url-handler-mode

bug#4410: 23.1.50; copy-file get wrong number of args with url-handler-mode

[Lennart Borgman]

Turn on url-handler-mode and evaluate

  (copy-file
   "http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
   "temp.tmp")

This gives the error

Debugger entered--Lisp error: (wrong-number-of-arguments #[(url newname
&optional ok-if-already-exists keep-time) "binary data removed..."
[newname ok-if-already-exists url handle buffer file-exists-p error
"Opening output file: File already exists, %s"
url-retrieve-synchronously nil "Opening input file: No such file or
directory, %s" mm-dissect-buffer t mm-save-part-to-file kill-buffer
mm-destroy-parts] 4
("c:/emacs/u/090911/emacs/lisp/url/url-handlers.elc" . 6235)] 5)
  url-copy-file("http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
"c:/emacs/p/090804/EmacsW32/nxhtml/util/temp.tmp" nil nil nil)
  apply(url-copy-file
("http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
"c:/emacs/p/090804/EmacsW32/nxhtml/util/temp.tmp" nil nil nil))
  url-file-handler(copy-file
"http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
"c:/emacs/p/090804/EmacsW32/nxhtml/util/temp.tmp" nil nil nil)
  copy-file("http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
"temp.tmp")



If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
c:/emacs/u/090911/emacs/etc/DEBUG for instructions.


In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600)
 of 2009-09-11
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/g/include -fno-crossjumping'

bug#4410: marked as done (23.1.50; copy-file get wrong number of args with url-handler-mode)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

Your message dated Sun, 13 Sep 2009 17:23:41 -0400
with message-id <87ws42lesi.fsf@cyd.mit.edu>
and subject line Re: 23.1.50; copy-file get wrong number of args with url-handler-mode
has caused the Emacs bug report #4410,
regarding 23.1.50; copy-file get wrong number of args with url-handler-mode
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4410: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4410
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4466 bytes --]

From: Lennart Borgman <lennart.borgman@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: 23.1.50; copy-file get wrong number of args with url-handler-mode
Date: Fri, 11 Sep 2009 23:58:12 +0200
Message-ID: <e01d8a50909111458m3aa37abfjaca171fb0378e363@mail.gmail.com>

Turn on url-handler-mode and evaluate

  (copy-file
   "http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
   "temp.tmp")

This gives the error

Debugger entered--Lisp error: (wrong-number-of-arguments #[(url newname
&optional ok-if-already-exists keep-time) "binary data removed..."
[newname ok-if-already-exists url handle buffer file-exists-p error
"Opening output file: File already exists, %s"
url-retrieve-synchronously nil "Opening input file: No such file or
directory, %s" mm-dissect-buffer t mm-save-part-to-file kill-buffer
mm-destroy-parts] 4
("c:/emacs/u/090911/emacs/lisp/url/url-handlers.elc" . 6235)] 5)
  url-copy-file("http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
"c:/emacs/p/090804/EmacsW32/nxhtml/util/temp.tmp" nil nil nil)
  apply(url-copy-file
("http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
"c:/emacs/p/090804/EmacsW32/nxhtml/util/temp.tmp" nil nil nil))
  url-file-handler(copy-file
"http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
"c:/emacs/p/090804/EmacsW32/nxhtml/util/temp.tmp" nil nil nil)
  copy-file("http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
"temp.tmp")



If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
c:/emacs/u/090911/emacs/etc/DEBUG for instructions.


In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600)
 of 2009-09-11
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/g/include -fno-crossjumping'


[-- Attachment #3: Type: message/rfc822, Size: 1278 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Lennart Borgman <lennart.borgman@gmail.com>
Cc: 4410-done@emacsbugs.donarmstrong.com
Subject: Re: 23.1.50; copy-file get wrong number of args with url-handler-mode
Date: Sun, 13 Sep 2009 17:23:41 -0400
Message-ID: <87ws42lesi.fsf@cyd.mit.edu>

> Turn on url-handler-mode and evaluate
>
>   (copy-file
>    "http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
>    "temp.tmp")
>
> This gives the error

Thanks, I've checked in a fix.

bug#4410: 23.1.50; copy-file get wrong number of args with url-handler-mode

[Basil L. Contovounesios]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

found 4410 24.4
tags 4410 patch
quit

Chong Yidong <cyd@stupidchicken.com> writes:

>> Turn on url-handler-mode and evaluate
>>
>>   (copy-file
>>    "http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
>>    "temp.tmp")
>>
>> This gives the error
>
> Thanks, I've checked in a fix.

This error was reintroduced in Emacs 24.4.
May I push the following fix to emacs-26?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-url-copy-file-arglist.patch --]
[-- Type: text/x-diff, Size: 3009 bytes --]

From bd5795e0d1eb1632909393612dd53b6beda606f0 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Tue, 19 Mar 2019 16:00:18 +0000
Subject: [PATCH] Fix url-copy-file arglist

* lisp/url/url-handlers.el: Silence byte-compiler.
(url-copy-file): Add 6th argument following change to copy-file in
2012-12-16T19:22:27+01:00!romain@orebokech.com. (bug#4410)
---
 lisp/url/url-handlers.el | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/lisp/url/url-handlers.el b/lisp/url/url-handlers.el
index 3af4e9e7b1..91f9b7f520 100644
--- a/lisp/url/url-handlers.el
+++ b/lisp/url/url-handlers.el
@@ -41,6 +41,9 @@
 (declare-function mm-decode-string "mm-bodies" (string charset))
 ;; mm-decode loads mail-parse.
 (declare-function mail-content-type-get "mail-parse" (ct attribute))
+;; mm-bodies loads mm-util.
+(declare-function mm-charset-to-coding-system "mm-util"
+                  (charset &optional lbt allow-override silent))
 
 ;; Implementation status
 ;; ---------------------
@@ -250,15 +253,15 @@ url-handler-file-remote-p
 ;; The actual implementation
 ;;;###autoload
 (defun url-copy-file (url newname &optional ok-if-already-exists
-			  _keep-time _preserve-uid-gid)
+                          _keep-time _preserve-uid-gid _preserve-permissions)
   "Copy URL to NEWNAME.  Both args must be strings.
-Signals a `file-already-exists' error if file NEWNAME already exists,
+Signal a `file-already-exists' error if file NEWNAME already exists,
 unless a third argument OK-IF-ALREADY-EXISTS is supplied and non-nil.
 A number as third arg means request confirmation if NEWNAME already exists.
 This is what happens in interactive use with M-x.
 Fourth arg KEEP-TIME non-nil means give the new file the same
 last-modified time as the old one.  (This works on only some systems.)
-Fifth arg PRESERVE-UID-GID is ignored.
+Args PRESERVE-UID-GID and PRESERVE-PERMISSIONS are ignored.
 A prefix arg makes KEEP-TIME non-nil."
   (if (and (file-exists-p newname)
 	   (not ok-if-already-exists))
@@ -341,7 +344,7 @@ url-insert-file-contents
     (unless buffer (signal 'file-error (list url "No Data")))
     (with-current-buffer buffer
       ;; XXX: This is HTTP/S specific and should be moved to url-http
-      ;; instead.  See https://debbugs.gnu.org/17549.
+      ;; instead.  See bug#17549.
       (when (bound-and-true-p url-http-response-status)
         ;; Don't signal an error if VISIT is non-nil, because
         ;; 'insert-file-contents' doesn't.  This is required to
@@ -354,7 +357,7 @@ url-insert-file-contents
                          (< url-http-response-status 300)))
           (let ((desc (nth 2 (assq url-http-response-status url-http-codes))))
             (kill-buffer buffer)
-            ;; Signal file-error per https://debbugs.gnu.org/16733.
+            ;; Signal file-error per bug#16733.
             (signal 'file-error (list url desc))))))
     (url-insert-buffer-contents buffer url visit beg end replace)))
 
-- 
2.20.1


[-- Attachment #3: Type: text/plain, Size: 20 bytes --]


Thanks,

-- 
Basil

bug#4410: 23.1.50; copy-file get wrong number of args with url-handler-mode

[Eli Zaretskii]

> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Tue, 19 Mar 2019 16:33:31 +0000
> Cc: Lennart Borgman <lennart.borgman@gmail.com>, 4410@debbugs.gnu.org
> 
> May I push the following fix to emacs-26?

Yes, thanks.

bug#4410: 23.1.50; copy-file get wrong number of args with url-handler-mode

[Basil L. Contovounesios]

tags 4410 fixed
close 4410 26.2
quit

Eli Zaretskii <eliz@gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Date: Tue, 19 Mar 2019 16:33:31 +0000
>> Cc: Lennart Borgman <lennart.borgman@gmail.com>, 4410@debbugs.gnu.org
>> 
>> May I push the following fix to emacs-26?
>
> Yes, thanks.

Thanks, done.

-- 
Basil

bug#4410: 23.1.50; copy-file get wrong number of args with url-handler-mode

[Chong Yidong]

Patch looks fine to me.

-- Yidong

On Wed, Mar 20, 2019 at 12:33 AM Basil L. Contovounesios
<contovob@tcd.ie> wrote:
>
> found 4410 24.4
> tags 4410 patch
> quit
>
> Chong Yidong <cyd@stupidchicken.com> writes:
>
> >> Turn on url-handler-mode and evaluate
> >>
> >>   (copy-file
> >>    "http://www.w3.org/QA/Tools/css-validator/css-validator.jar"
> >>    "temp.tmp")
> >>
> >> This gives the error
> >
> > Thanks, I've checked in a fix.
>
> This error was reintroduced in Emacs 24.4.
> May I push the following fix to emacs-26?
>
>
> Thanks,
>
> --
> Basil