From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Micha=C5=82?= Krzywkowski Newsgroups: gmane.emacs.bugs Subject: bug#34972: [PATCH] Use a different name for the help buffer in query-replace Date: Sun, 24 Mar 2019 13:40:11 +0100 Message-ID: <87wokophsk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="74593"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 0.9.18; emacs 27.0.50 To: 34972@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 24 13:42:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h82S7-000JHk-Ea for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 13:42:15 +0100 Original-Received: from localhost ([127.0.0.1]:56009 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h82S6-0007s6-GU for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 08:42:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h82Ry-0007rg-V7 for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 08:42:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h82Rv-0001BS-EV for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 08:42:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42548) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h82Ru-0001Ab-8U for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 08:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h82Ru-0006Lm-04 for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 08:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Micha=C5=82?= Krzywkowski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Mar 2019 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34972 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155343129524376 (code B ref -1); Sun, 24 Mar 2019 12:42:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Mar 2019 12:41:35 +0000 Original-Received: from localhost ([127.0.0.1]:56092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h82RS-0006L6-Kj for submit@debbugs.gnu.org; Sun, 24 Mar 2019 08:41:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h82RQ-0006Kt-Od for submit@debbugs.gnu.org; Sun, 24 Mar 2019 08:41:33 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:56048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h82RL-0000sz-Ih for submit@debbugs.gnu.org; Sun, 24 Mar 2019 08:41:27 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h82RK-0007h4-FX for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 08:41:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h82QF-0000R7-B7 for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 08:40:20 -0400 Original-Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:38928) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h82QE-0000QP-RW for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 08:40:19 -0400 Original-Received: by mail-lj1-x229.google.com with SMTP id l7so5486052ljg.6 for ; Sun, 24 Mar 2019 05:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=oan713alEilyAzbLiV+pPf7IZ04UnNQ5u2aKZQLtNsY=; b=JN6RaR4iN5RvEZVLKSQC464Qee+HMolzOccZmkmD+mzJ1m+97wYY5IY/3IF7sThklP T7G3cyFUQTzVRSDdPbww0cQEj1rRguQejDBnw8AOo3g0/l8azwNtkfEuQgfkrdXIY/jC IqnB0C68H3EXfsEdDBZ5Nqqi9gm4pyd1EvycrI+dijR8nGJXNGvkIKGEBqk2xWH3zOAA 9cm7xF0phuO5j4N7s+C9lhMs4QwBdzj+kBm5G/+ryiqW8LmmuxqNrYVP4+IWqpoapKu5 cUrcfFC18AMDHsjdFdSEgEH/x8O1sCNe8YucWl+mvcd3XJe+QsHDgU9for9nxED5o9HM nAJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=oan713alEilyAzbLiV+pPf7IZ04UnNQ5u2aKZQLtNsY=; b=qpwZ9IfbDsq9RHEH+kyzAUyTE8F02guxWfT8653EfrbK8tBUFqg+N88oVFWxar7s/g JnE0MXibnJiqq7FF4K9imP4QOtTkzr66/AS5K7gl2K3ZKCE0FxI9c+xnhXLVYEicvuIi emh/UOYerxFfJWEUYyv7++x8WlZPMsE8FYwmMjiJhKLct+zOBexYmMJB3SPWqWSD4A25 l//BjS8e1opB4FGc+IJXapmfvBkLM90+GE+VxdGzip5vA53HIKeq1cVi+zSLVdKq+LMg Yg9axUnfFlJJU/8/R+kaPspdxkm+mqvGmqhDUcIJKAheVjhITE+XcpEgELjErAL8+zVE ad5w== X-Gm-Message-State: APjAAAVuQNWlLgXcYmEtVhPnFV5xYnkbeCCdWzUoH1N7jMCk8EZYQWsn Lj70adr3U+j9ClFSIOL1x2Nfrm/7 X-Google-Smtp-Source: APXvYqz/yQrhKNlFkPD37lQLUM5cTMNnfdPzTeFymZG0WyGSekCCHn4CZfxvJcGIqprfaF24bjtlWA== X-Received: by 2002:a2e:7311:: with SMTP id o17mr1791239ljc.124.1553431216454; Sun, 24 Mar 2019 05:40:16 -0700 (PDT) Original-Received: from debian ([2a02:a310:8247:bc00:ddf2:566a:8bf3:8676]) by smtp.gmail.com with ESMTPSA id f19sm2898076lfk.69.2019.03.24.05.40.15 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Mar 2019 05:40:15 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156691 Archived-At: --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hi, I use this to always display the *Help* buffer in the selected window, or to reuse existing window displaying the same buffer: (add-to-list 'display-buffer-alist '("^\\*Help\\*$" . ((display-buffer-reuse-window display-buffer-same-window)))) With this, whenever I forget the keybindings available during query-replace and hit '?' to get help, the help buffer is displayed in the main window which shows the replacements to be performed. When I try to bury the help buffer with 'q', it doesn't do what I intended - it quits the query-replace session. The same thing happens when I try to switch to the main window with 'C-x o' and manually kill the buffer. The only thing that works really, is to enter recursive edit, kill the help buffer and exit-recursive-edit. This happens because the help buffer generated by perform-replace is named "*Help*" and my display-buffer rule matches it. I work around this by adding an additional rule to display-buffer-alist which checks if the help buffer was created by perform-replace. It's ugly: (defun my//display-buffer-help-for-query-replace-condition (bufname action) (and (string-match-p "\\*Help\\*" bufname) (catch 'res (mapbacktrace (lambda (_evald func _args _flags) (when (eq func 'perform-replace) (throw 'res t))))))) (add-to-list 'display-buffer-alist '(my//display-buffer-help-for-query-replace-condition . (display-buffer-pop-up-window))) There are a couple of ways to improve behavior of perform-replace: - Use a different name for the query-replace help buffer (patch attached) - Make 'C-l' or some other key bury the help buffer, if it was displayed in the main window - Make '?' toggle visibility of the help buffer - Allow switching windows in query-replace - Display the help message in the minibuffer --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename=0001-Use-a-different-name-for-the-help-buffer-in-query-re.patch Content-Transfer-Encoding: quoted-printable Content-Description: Patch From=204cbd2022deb50a35ca38040ab0337f707834b3f4 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Micha=3DC5=3D82=3D20Krzywkowski?=3D Date: Fri, 22 Mar 2019 18:36:21 +0100 Subject: [PATCH] Use a different name for the help buffer in query-replace * lisp/replace.el (perform-replace): Use "*Query replace help*" for the name of the help buffer. =2D-- lisp/replace.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/replace.el b/lisp/replace.el index 59ad1a375b..153f8f8287 100644 =2D-- a/lisp/replace.el +++ b/lisp/replace.el @@ -2635,7 +2635,7 @@ perform-replace (setq def (lookup-key map key)) ;; Restore the match data while we process the command. (cond ((eq def 'help) =2D (with-output-to-temp-buffer "*Help*" + (with-output-to-temp-buffer "*Query replace help*" (princ (concat "Query replacing " (if backward "backward " "") =2D-=20 Micha=C5=82 Krzywkowski PGP: A5A7 06C4 28EF 8F64 2868 13A1 7BDE C129 F0B8 09A1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =2D- Micha=C5=82 Krzywkowski PGP: A5A7 06C4 28EF 8F64 2868 13A1 7BDE C129 F0B8 09A1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEWxyvIOWnapfz9K2Z20CneWXMPiIFAlyXeqsACgkQ20CneWXM PiLcwAf+IMlUcaVREcYDJaJj23EnZ4xijG5Mnrwt24PExaa9BBvB5S66EOD1qmZ7 5E5JwBNyUBnYXmnFDtr0yLgUWDcb9gLTqxAYh8uKrDrzVeVFUMdmfzV8HcgMdxM1 dM4IHQwd6+km84guPHZR/L2uKHvE1Ii9Kmh7vUsZ52XF0rxc2DB4flX8GJnofLvi QhZ3fn0jRE4b+NKpAqvzwac9fvT0AkzqWIsj6EsEW3vlHFz1VtraXGmFFGh93kyD aVS2OHIk7CFSsjQuJoF4hOXBB+O85jw2hrAUUW/ZpdJV+K6FMjtNPqoStD8D7JiZ faSGye/oFZVF5naEpkXTha1Us/Izgw== =8EMj -----END PGP SIGNATURE----- --==-=-=--