From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#34847: 27.0.50; auto-revert-buffers occasionally selects a killed buffer Date: Sat, 06 Apr 2019 11:37:38 +0200 Message-ID: <87wok7mq3h.fsf@gmx.de> References: <87tvfsgx8y.fsf@gmx.de> <87a7h3lwl6.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="90714"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34847@debbugs.gnu.org, Dale Sedivec To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 06 11:38:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hChmG-000NUg-K8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2019 11:38:20 +0200 Original-Received: from localhost ([127.0.0.1]:52722 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hChmF-0005Cj-Lf for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2019 05:38:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hChm3-0005CR-EB for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 05:38:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hChlz-0003Ok-8Y for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 05:38:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33018) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hChly-0003OY-OA for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 05:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hChly-00074C-Go for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 05:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Apr 2019 09:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34847 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34847-submit@debbugs.gnu.org id=B34847.155454346927146 (code B ref 34847); Sat, 06 Apr 2019 09:38:02 +0000 Original-Received: (at 34847) by debbugs.gnu.org; 6 Apr 2019 09:37:49 +0000 Original-Received: from localhost ([127.0.0.1]:46562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hChll-00073l-7V for submit@debbugs.gnu.org; Sat, 06 Apr 2019 05:37:49 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:54409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hChlk-00073Z-0e for 34847@debbugs.gnu.org; Sat, 06 Apr 2019 05:37:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1554543460; bh=X9SkkKOf+ftul2lUiuiilAtfF82U5COsq3gq6ha4Rgg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=TWYMehJ7/EXrxywWZCdSLEVXVU7q9lYpA6lbRj/a7M1D5drgOhyzYf1qZULyySHOe 8gk6wRsh02yLjHR0W8kVJ4arDMIiOQ/1mVco5hAn4SION2PVWr6FNygiR4GErRy+9I /5g8GBZCSHYCMGP//kY3VFWwsCUDgX1uMtvl4Zhs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.91.249.211]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M8mCe-1h2mfX3npc-00CCEy; Sat, 06 Apr 2019 11:37:40 +0200 In-Reply-To: <87a7h3lwl6.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 06 Apr 2019 03:02:45 +0100") X-Provags-ID: V03:K1:q0IwG+s+id343uVH7dB9grDFzR7LZnIfRlJt97zwoKV1Gbagfa/ +V5OQIZpX5ush+vQiY2VNdjKphBYTsH1udUHY+JM11jrY8lG5+ARn93giCu9Iso1MAfi4Cn /deyhbmdIfrymvf85lp43/doya27xkpr7S59aG+PvbbFXUKUVdCGu2kGYTmKL+0WC/EOnC+ b5xr0zFn7Gul4OGVlgleQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:MhJd7VVV9os=:fqv6JSrMzkvpaRR4gsw1Wh 6zpiq15TbER0mq4sPB/Gf9Vl5z2wsBYRnbcDqams7ijgcahDZxFFJBlG/VnJuprVj0S8JunMi duzQGZ7pHVuCx3LUjZDnSB8NV5n7hzBL6PNeEBQNpy8cIMPqOV3CLh6XZOkJcVqLzcNnLQxtq TCYh/yfeRS1LVP3XcvyBgyecvl7kFRHaO1CukYZ2SVo2MWaZvRPvubUbRsnsGScsS18+MDCz3 RPKsevVhg8gmsuOvxD/4fMbxr8dgU8QL0vrMhJVYK/TaJBqzIFM5dXSg++F8yLQUGsyIMDm5E sGM4wNhPiCIkdJd6HURIP3DPiKMjnJYWhcBeplZVyvj0VC2yGMMvv6OrTrUZPo1CldryCyFtz 7S+ud8bCQvyb+ufSctu1oJEtZmiE/it32x6EVycWQfo5pefiudA25gLer3qaM1xJFK8ETb67G Ja6JQ05o05qw1fO9zr9wyKUqK9Z1Eygq3NpcDBcLPcA1QjWpM79YVhaINT3AGWpiYW8m1Gzxz BsVsTD2Ig2Kmidf5bXjq2uVPYtc/bWy/EGK42TbsDdRJxMMbtv4DL7RU2ftjnHbQrnOeH+93x EUPylwcZJ+hA+qKC4D73pP+frr6TER4hnJJygX7lGd6q6rTV9F2GWpBGa7hODNOyRzLFD3GYe 1ZVaYAHRSLxYXHhs8RbYmDmBtqQ/GdSY3nohh7SizM8z8io82xHvqVfgFuAHOAwf134ym/uFN +zcT79/knozPR7RL3Vgp0JTSHga4ILXvkznrikBZy/HE23LEc+gZOEbXyDTuhs0QsGIH4oNb X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157261 Archived-At: "Basil L. Contovounesios" writes: Hi Basil, >> ! (defun auto-revert-remove-current-buffer (&optional buffer) >> "Remove dead buffer from `auto-revert-buffer-list'." > > Can you please update the docstring? E.g. > > "Remove BUFFER from `auto-revert-buffer-list'. > BUFFER defaults to `current-buffer'." Done. >> --- 772,783 ---- >> (setq bufs (delq nil >> (mapcar >> (lambda (buf) >> ! (and (buffer-live-p buf) >> ! (with-current-buffer buf >> ! (and >> ! (or (not (file-remote-p default-directory)) >> ! (file-remote-p default-directory nil t)) >> ! buf)))) >> bufs))) >> ;; Partition `bufs' into two halves depending on whether or not >> ;; the buffers are in `auto-revert-remaining-buffers'. The >> two > > Indentation seems a bit off here. Note that you can use 'when' instead > of 'and' to fit more easily within 80 columns, if you prefer. I'd like to keep it, for simpler diffs when time comes. There's no problem with the 80 columns width. > Otherwise LGTM. Can you please also make the following change while > you're at it? > > diff --git a/lisp/autorevert.el b/lisp/autorevert.el > index bc7c616ecb..d736f0d31c 100644 > --- a/lisp/autorevert.el > +++ b/lisp/autorevert.el > @@ -509,7 +509,7 @@ auto-revert-notify-rm-watch > (ignore-errors > (file-notify-rm-watch auto-revert-notify-watch-descriptor))))) > auto-revert-notify-watch-descriptor-hash-list) > - (remove-hook 'kill-buffer-hook #'auto-revert-notify-rm-watch)) > + (remove-hook 'kill-buffer-hook #'auto-revert-notify-rm-watch t)) > (setq auto-revert-notify-watch-descriptor nil > auto-revert-notify-modified-p nil)) Good catch! I've applied it. > Works for me; I hope to see it land soon. See also my other message for > a related but more subtle problem: https://debbugs.gnu.org/34847#16 Eli has already confirmed your approach, so you might commit it (and close the bug then). > Thanks, Best regards, Michael.