From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unit tests and lexical-binding for delim-col.el Date: Wed, 08 May 2019 13:00:41 +0100 Message-ID: <87woj117h2.fsf@tcd.ie> References: <87woj1anpx.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="193848"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 08 14:00:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOLFp-000oGX-43 for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 14:00:57 +0200 Original-Received: from localhost ([127.0.0.1]:35949 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOLFo-0002t4-2p for ged-emacs-devel@m.gmane.org; Wed, 08 May 2019 08:00:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOLFi-0002qZ-7H for emacs-devel@gnu.org; Wed, 08 May 2019 08:00:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOLFg-0004qV-AX for emacs-devel@gnu.org; Wed, 08 May 2019 08:00:49 -0400 Original-Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:43193) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOLFf-0004nz-4G for emacs-devel@gnu.org; Wed, 08 May 2019 08:00:47 -0400 Original-Received: by mail-ed1-x544.google.com with SMTP id w33so19492596edb.10 for ; Wed, 08 May 2019 05:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DoZgOYMshsnmR7+aF4891Ki4NwVHizsdCil12v2Yqpo=; b=GgLlyuSrF7c33ZrSVcJLhjhCzEyJ/iylVdUwDcRPZ1DUF8fiG7OVUqXfu1uDrpupL1 xXikHYxndKhGKhIo6/M6bbjsdgGTJxX+EGEtvKb3ZmKVyzhNZq480yu4ebR/zSh4epeG tMQpXnspKbnN8IuGqQNDfk6dRzeQnyxUgpy5R80CUjVhy71neUsEfuKZoJ3ypGa7jzTh bjt5I5vyxyYKmVwCHgHsqmdKU4Koxw9tD8RwK0RY7cIE7psUWBLITINg5C+Sc4HtUjnb LqhLLba4SP5SqG/SxYYjXxJ8erzMXFXTf9lIpj+A4tJ4Loq4RGQjRZI2BPwISKOtD1Sn O5ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=DoZgOYMshsnmR7+aF4891Ki4NwVHizsdCil12v2Yqpo=; b=A1wteRzO/L3VvwSl0eBd3Df0wDpY5MNWobIIpDZRGyR7GakIEbCpd7QGS95cTsrNAX wbXWffhVw8licNqAtnpB1F0TBtv9OAWnucTMfz4BIHoGDBo5tDh22ALzaDkZdLm8clPA f7NayF2ZfJ7+CMt8MEPSy7CEnD7vRMyDV1RXrOnA/HMhyrkPpPJe1hsHswYJp4cc1GYE H+sQrv55juAnU3LhcLvCNcZiw/vE1ILrDTgpF8u7vrOkdQ7ag/bUiQWJTjlUo/j8ig0J 1vMmnLWRbWwmxqB1x0E+4X93CyXu3BqpHpAYbR3G81LwuK2YKtbzzOOJ6t2YrTrydlG5 sTHg== X-Gm-Message-State: APjAAAUpmphIlyFUjrzhc+bhLaq0JhASgKgH4exXX96rodwfrygjsV2x 2WCs+zNl1PaXgz7WHF6gnQqkg+rW4rURpjWP X-Google-Smtp-Source: APXvYqzVVslWGVWpRRb+DXexzgV1Qh20WbSt0RLuqvdyxpFK1pW06AzYGR2YCeMCyb5fk3Rda8HNSg== X-Received: by 2002:a17:906:d293:: with SMTP id ay19mr29140362ejb.92.1557316844376; Wed, 08 May 2019 05:00:44 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:6fa:38d6:1fce:ddb3]) by smtp.gmail.com with ESMTPSA id x49sm3263566edm.25.2019.05.08.05.00.42 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 08 May 2019 05:00:42 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Wed, 8 May 2019 09:36:12 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::544 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236281 Archived-At: Stefan Kangas writes: > Noam Postavsky writes: >> I think you may as well go with defun here, delimit-columns-str isn't >> being used in some performance-critical spot, as far as I can tell. > > You are probably correct. However, I decided to leave Basil's changes as is, > since I don't know what would conventionally be considered cleaner/better in > this case. It is always better to use defun until proven otherwise, see (info "(elisp) Inline Functions"). The only reason I used defsubst was to be more conservative, but if no-one minds then defun is indeed preferable. Thanks, -- Basil