From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Unit tests and lexical-binding for delim-col.el
Date: Wed, 08 May 2019 13:00:41 +0100 [thread overview]
Message-ID: <87woj117h2.fsf@tcd.ie> (raw)
In-Reply-To: <CADwFkmmqCKmL-2bqY4wt-6DfLTVDPF75VxY+9bh3x+WS8Ae8Uw@mail.gmail.com> (Stefan Kangas's message of "Wed, 8 May 2019 09:36:12 +0200")
Stefan Kangas <stefan@marxist.se> writes:
> Noam Postavsky <npostavs@gmail.com> writes:
>> I think you may as well go with defun here, delimit-columns-str isn't
>> being used in some performance-critical spot, as far as I can tell.
>
> You are probably correct. However, I decided to leave Basil's changes as is,
> since I don't know what would conventionally be considered cleaner/better in
> this case.
It is always better to use defun until proven otherwise, see (info
"(elisp) Inline Functions"). The only reason I used defsubst was to be
more conservative, but if no-one minds then defun is indeed preferable.
Thanks,
--
Basil
next prev parent reply other threads:[~2019-05-08 12:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 20:56 [PATCH] Unit tests and lexical-binding for delim-col.el Stefan Kangas
2019-05-07 22:44 ` Basil L. Contovounesios
2019-05-07 23:03 ` Noam Postavsky
2019-05-08 7:36 ` Stefan Kangas
2019-05-08 12:00 ` Basil L. Contovounesios [this message]
2019-05-08 17:20 ` Stefan Kangas
2019-05-08 20:24 ` Stefan Kangas
2019-05-09 13:39 ` Basil L. Contovounesios
2019-05-09 14:38 ` Stefan Monnier
2019-05-11 10:46 ` Stefan Kangas
2019-05-20 14:40 ` Basil L. Contovounesios
2019-05-30 18:20 ` Stefan Kangas
2019-06-30 23:40 ` bug#36453: [PATCH] Delegate to rectangle version in delim-col when appropriate Stefan Kangas
2019-07-08 22:52 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woj117h2.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.