From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#25702: 26.0.50; `message-make-fqdn' break when `(system-name)' doesn't ends in `.local' Date: Mon, 13 May 2019 17:14:21 -0400 Message-ID: <87woiuoy4y.fsf@mouse.gnus.org> References: <877f4updp4.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="250011"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 25702@debbugs.gnu.org To: Rasmus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 13 23:25:44 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQIS7-0012wn-Vu for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 23:25:44 +0200 Original-Received: from localhost ([127.0.0.1]:35264 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQIS6-0005Qg-Vp for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 May 2019 17:25:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQIRZ-0004bV-8z for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 17:25:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQIHr-0001eF-4a for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 17:15:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32969) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQIHm-0001Zc-Kl for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 17:15:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQIHm-0003OI-FZ for bug-gnu-emacs@gnu.org; Mon, 13 May 2019 17:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 May 2019 21:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25702 X-GNU-PR-Package: emacs Original-Received: via spool by 25702-submit@debbugs.gnu.org id=B25702.155778206912962 (code B ref 25702); Mon, 13 May 2019 21:15:02 +0000 Original-Received: (at 25702) by debbugs.gnu.org; 13 May 2019 21:14:29 +0000 Original-Received: from localhost ([127.0.0.1]:46510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQIHE-0003Mz-Qi for submit@debbugs.gnu.org; Mon, 13 May 2019 17:14:29 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:46348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQIHD-0003Mr-05 for 25702@debbugs.gnu.org; Mon, 13 May 2019 17:14:27 -0400 Original-Received: from [12.41.144.226] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hQIH9-0001hg-FH; Mon, 13 May 2019 23:14:26 +0200 In-Reply-To: <877f4updp4.fsf@gmx.us> (rasmus@gmx.us's message of "Mon, 13 Feb 2017 11:49:59 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159225 Archived-At: Rasmus writes: > The combination of 3485c1693ef (see #24570) and maybe the removal of > `message-valid-fqdn-regexp' means that `message-make-fqdn' has broken for > me. > > My (system-name) is the model number of the machine I use (e.g. "X200s"). > So now it's selected as the fdqn via `message-make-fqdn': > > ((not (string-match message-bogus-system-names sysname)) > ;; `system-name' returned the right result. > sysname) > > Thus, MESSAGE-ID are something@X200s, which is a bogus address. I think this has been fixed in Emacs in 2017. The code is now: ;; A system name without any dots is unlikely to be a good fully ;; qualified domain name. ((and (string-match "[.]" sysname) (not (string-match message-bogus-system-names sysname))) ;; `system-name' returned the right result. sysname) So it won't use sysname if there's no dot. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no