From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35871: 27.0.50; [PATCH] Fix SVG transparency with Cairo Date: Thu, 30 May 2019 01:18:59 +0100 Message-ID: <87woi8bxqk.fsf@tcd.ie> References: <87k1eh2ayc.fsf@gmail.com> <878suqkibp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="223216"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: kevin.legouguec@gmail.com To: 35871@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 30 02:20:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hW8np-000vq0-Fc for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2019 02:20:17 +0200 Original-Received: from localhost ([127.0.0.1]:44608 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW8nl-0001S7-0W for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 May 2019 20:20:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hW8nb-0001S1-Fk for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 20:20:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hW8na-0005Dw-H0 for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 20:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46824) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hW8nZ-0005DN-VX for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 20:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hW8nZ-0007mz-P4 for bug-gnu-emacs@gnu.org; Wed, 29 May 2019 20:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 May 2019 00:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35871-submit@debbugs.gnu.org id=B35871.155917555329865 (code B ref 35871); Thu, 30 May 2019 00:20:01 +0000 Original-Received: (at 35871) by debbugs.gnu.org; 30 May 2019 00:19:13 +0000 Original-Received: from localhost ([127.0.0.1]:60368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW8ml-0007lc-GS for submit@debbugs.gnu.org; Wed, 29 May 2019 20:19:12 -0400 Original-Received: from mail-ed1-f65.google.com ([209.85.208.65]:42228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hW8mi-0007lM-HJ for 35871@debbugs.gnu.org; Wed, 29 May 2019 20:19:10 -0400 Original-Received: by mail-ed1-f65.google.com with SMTP id g24so6361251eds.9 for <35871@debbugs.gnu.org>; Wed, 29 May 2019 17:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=ucc0fZJLN6p4WNZxoOoM26RY2W8n1d1YB9Hf74swPp8=; b=cuVgfvEsOXsGoNOdBhgNmwVeN9zV4a3YujYDQqVTThoIFJKwoQrnEqHKqFbRK+S1jv wxPb8ZG68RvPJRSGL2l0VnrEp+jPqnJfi8uA/kiMrNrZ0Cjos9LDxHoQaG57M4sC6qCM Yq9SS1xRl29+gDsy9V5d2kfeAS2wjDNFEOTyDTxCRlpo6i5x6umQ1Ofyi6wJv2GHKPJU aqoFGN61Xl2CuhMMcIga+dhzh3Y6eTUERWS1r/d0YP2g57szYoTS3+VcGyeqcuMqRyHb oGHDjBnWuoR8xJrmE67k/bvKZgGV+N+L4lXzO8NpmMUgOtkNghUc5E7kOdP2yvxwquy3 LPdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=ucc0fZJLN6p4WNZxoOoM26RY2W8n1d1YB9Hf74swPp8=; b=k3U9f54eSZL3K4ubjEab4nYYIYrVc1po5lGkzbHB6Yum9SOzwYnbaSrb7UKuBjt+IS 76FRSLX2uOciV8IOZ/HpLCX524hW5Hy7c5BKODh6iQ5Ve7xCvbjY6zUyHwMQAH+zvZKH veGjI12f6Jr3qPThxeNRsa2jitxeYviSaFgvTpdYem57H/RArhCn1E33zTIE1dScvPdd rrKWlAbCirF+0nfyH1w0CbvVIwwWWUmjTtdfFKf54e3uf9oCYsHqxFJXRZBYob1UVCvG qVkMuYuw665GvwuI8wLBn+jWLljXRpSGcUIBtpTbVkE6pZSjI7ovw78FHOk4aQfvRg9Z b3Gw== X-Gm-Message-State: APjAAAWyEEc/GbcPf3n00pGiqV4HxjgF4wl+zNenPrZa3/cEgWZekD4y xnp6iS18/A5SLW6SWFOGaSzbjrqGZyw= X-Google-Smtp-Source: APXvYqz0Bw7MNOLAgRYqBxb0yepd1RDJafSOiLxJ4GGym+AJmmocXEWYHh36+lqZSk3sG6IogDJrjg== X-Received: by 2002:a17:906:a3cf:: with SMTP id ca15mr819694ejb.302.1559175542305; Wed, 29 May 2019 17:19:02 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:6fa:38d6:1fce:ddb3]) by smtp.gmail.com with ESMTPSA id k34sm252688ede.88.2019.05.29.17.19.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 29 May 2019 17:19:00 -0700 (PDT) In-Reply-To: (YAMAMOTO Mitsuharu's message of "Wed, 29 May 2019 18:07:04 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159902 Archived-At: YAMAMOTO Mitsuharu writes: > On Tue, 28 May 2019 19:02:34 +0900, > K=C3=A9vin Le Gouguec wrote: >>=20 >> YAMAMOTO Mitsuharu writes: >>=20 >> > Patch attached. >> > >> > It makes cairo image support more consistent with the Xlib one. [=E2= =80=A6] >> > SVG images should look similar on both builds. >>=20 >> Just compiled master (c617b4bf1e50bf33f0016bbcd5f502cc88150f26) >> --with-cairo and your patch on top; SVG images do seem to look the same >> from where I'm standing: > > Thanks for testing. Pushed to master as c89900ebd79. Closing. Thanks for working on this! Unfortunately this commit seems to have broken native image scaling, at least on X: 0. emacs -Q 1. C-x C-f /path/to/image.png RET [Notice the image isn't scaled to the window size.] 2. Any combination of + and - [Notice the image is not scaled.] Reverting c89900ebd79 brings back scaling for me. Here is my build info: In GNU Emacs 27.0.50 (build 4, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll= bars) of 2019-05-29 built on thunk Repository revision: 7f3b0d1c0003f3b883a6df3d2fae7f847f6d3070 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 System Description: Debian GNU/Linux 10 (buster) Configured using: 'configure 'CC=3Dccache gcc' 'CFLAGS=3D-O2 -march=3Dnative' --config-cache --prefix=3D/home/blc/.local --with-mailutils --with-x-toolkit=3Dlucid --with-modules --with-file-notification=3Dyes --with-x' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP Should I file a new bug report for this? Thanks, --=20 Basil