all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: 35871@debbugs.gnu.org
Cc: kevin.legouguec@gmail.com
Subject: bug#35871: 27.0.50; [PATCH] Fix SVG transparency with Cairo
Date: Thu, 30 May 2019 01:18:59 +0100	[thread overview]
Message-ID: <87woi8bxqk.fsf@tcd.ie> (raw)
In-Reply-To: <wl1s0hvdc7.wl-mituharu@math.s.chiba-u.ac.jp> (YAMAMOTO Mitsuharu's message of "Wed, 29 May 2019 18:07:04 +0900")

YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:

> On Tue, 28 May 2019 19:02:34 +0900,
> Kévin Le Gouguec wrote:
>> 
>> YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
>> 
>> > Patch attached.
>> >
>> > It makes cairo image support more consistent with the Xlib one.  […]
>> > SVG images should look similar on both builds.
>> 
>> Just compiled master (c617b4bf1e50bf33f0016bbcd5f502cc88150f26)
>> --with-cairo and your patch on top; SVG images do seem to look the same
>> from where I'm standing:
>
> Thanks for testing.  Pushed to master as c89900ebd79.  Closing.

Thanks for working on this!  Unfortunately this commit seems to have
broken native image scaling, at least on X:

0. emacs -Q
1. C-x C-f /path/to/image.png RET
   [Notice the image isn't scaled to the window size.]
2. Any combination of + and -
   [Notice the image is not scaled.]

Reverting c89900ebd79 brings back scaling for me.
Here is my build info:

In GNU Emacs 27.0.50 (build 4, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2019-05-29 built on thunk
Repository revision: 7f3b0d1c0003f3b883a6df3d2fae7f847f6d3070
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12003000
System Description: Debian GNU/Linux 10 (buster)

Configured using:
 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache
 --prefix=/home/blc/.local --with-mailutils --with-x-toolkit=lucid
 --with-modules --with-file-notification=yes --with-x'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON
PDUMPER LCMS2 GMP

Should I file a new bug report for this?

Thanks,

-- 
Basil





  reply	other threads:[~2019-05-30  0:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 20:05 bug#35871: 27.0.50; [PATCH] Fix SVG transparency with Cairo Kévin Le Gouguec
2019-05-24  0:02 ` YAMAMOTO Mitsuharu
2019-05-24 21:19   ` Kévin Le Gouguec
2019-05-28  0:52   ` YAMAMOTO Mitsuharu
2019-05-28 10:02     ` Kévin Le Gouguec
2019-05-29  9:07       ` YAMAMOTO Mitsuharu
2019-05-30  0:18         ` Basil L. Contovounesios [this message]
2019-05-30  1:09           ` YAMAMOTO Mitsuharu
2019-05-30  1:55             ` Basil L. Contovounesios
2019-05-30 16:42         ` Kévin Le Gouguec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woi8bxqk.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=35871@debbugs.gnu.org \
    --cc=kevin.legouguec@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.