From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Noam Postavsky <npostavs@gmail.com>
Newsgroups: gmane.emacs.bugs
Subject: bug#36139: [PATCH] Make better use of the switch op in cond forms
Date: Tue, 11 Jun 2019 07:25:05 -0400
Message-ID: <87wohsz7n2.fsf@gmail.com>
References: <68467ACF-DA49-4EBA-BA3B-7339DB22A456@acm.org>
 <395efab3-80f6-4ff0-b754-9f58dd4af695@default> <85d0jlbgby.fsf@gmail.com>
 <0D7CFFA0-FC7E-4D4E-A24C-4893776229B0@acm.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="34370"; mail-complaints-to="usenet@blaine.gmane.org"
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
Cc: 36139@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= <mattiase@acm.org>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 11 14:06:54 2019
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1hafYD-0008jl-Kr
	for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2019 14:06:53 +0200
Original-Received: from localhost ([::1]:56838 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1hafYC-0006b2-Ho
	for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2019 08:06:52 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48550)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1haeum-0001pj-Rf
 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 07:26:11 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1haeul-0007x9-DP
 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 07:26:08 -0400
Original-Received: from debbugs.gnu.org ([209.51.188.43]:44538)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1haeug-0007ss-OC
 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 07:26:04 -0400
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1haeug-0005bF-IX
 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 07:26:02 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Noam Postavsky <npostavs@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Tue, 11 Jun 2019 11:26:02 +0000
Resent-Message-ID: <handler.36139.B36139.156025231421463@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 36139
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
Original-Received: via spool by 36139-submit@debbugs.gnu.org id=B36139.156025231421463
 (code B ref 36139); Tue, 11 Jun 2019 11:26:02 +0000
Original-Received: (at 36139) by debbugs.gnu.org; 11 Jun 2019 11:25:14 +0000
Original-Received: from localhost ([127.0.0.1]:58079 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1haett-0005a6-Uw
 for submit@debbugs.gnu.org; Tue, 11 Jun 2019 07:25:14 -0400
Original-Received: from mail-it1-f172.google.com ([209.85.166.172]:38603)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <npostavs@gmail.com>) id 1haets-0005Zr-GQ
 for 36139@debbugs.gnu.org; Tue, 11 Jun 2019 07:25:12 -0400
Original-Received: by mail-it1-f172.google.com with SMTP id e25so4107212itk.3
 for <36139@debbugs.gnu.org>; Tue, 11 Jun 2019 04:25:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; 
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=NuwEaZe4dqrDqa5YSVJhvsYN6JY1YtNrAwzwnpDVfPo=;
 b=hxo38nv8jf7x4cdIBwQxQClMAEib321dk0F7daatQlfFrYWUAyZiYdGhv4yLwjVQx0
 30MLSfVHdFW/617gKy8SDWn0jTfVVeN3473D6x8IF5EhaERCpkT+aZ5/nyLr8NaEHV61
 58xoy+bpSTJMZI3WATLwabsifxHx7XSpJ9RukfpGLnBRg7jRliia321WewQrpKhVyTXs
 rrhBuRlWG3zmFJQZ6TIiYb7Hay68zzarBGNTIiOt6HeCNVHRrTUYuAubz+IOHaNUKxmq
 yKWKFZCWb3WkiiXCFvj+mLslzNvUD5klyf+w0KCZ2/u+MGtda7GwL/HUc5UB0u3IajMR
 zE/g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=NuwEaZe4dqrDqa5YSVJhvsYN6JY1YtNrAwzwnpDVfPo=;
 b=H5IRlIfcy86wNW6Y/vT19zSuxwZDKyjyIw+lgcT63J5Wpg+tBdfwOXDS24H2QuEaPj
 lLbM2ah/FVMt/BJWkJaw0AagILbzY9o1gnB/jbX7VuVuJ4mkcQ6z/lFzC5wJ+SJYOCF3
 AhbrEzzaZeZVKfeF9BGosfI8gEeyvOttP+5mD0HCUbiIq4DsYCvuAkkcRjRjeQK0OV0H
 zn6dRucZV1VdOTWpbYoB4Aq0rYUi+hsq7lE0a76e/Gcz78KKEBW6RFM10gYyBGZoRTNx
 Sr1hWbFN/uo+RAq8mT+3NiUIeChv200RZ3j5Jo9Zut0bMvCL3x+G5WCGCBKIWQaK74fd
 XZ8g==
X-Gm-Message-State: APjAAAXDPeFcqzkfa9it2qvzG3aU0ZSSInF01xsnlNiLno7LrZotbFVY
 FD8O/NpLUIJCzoAHa88eFmE=
X-Google-Smtp-Source: APXvYqzeZGwFsMCBwubqju56sCqxQzIj6WnxnTyvnXBFYZhcpfbbg29eRWne3i4OOwxK/0o5Law9Lg==
X-Received: by 2002:a05:660c:482:: with SMTP id
 a2mr15847980itk.91.1560252306608; 
 Tue, 11 Jun 2019 04:25:06 -0700 (PDT)
Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34])
 by smtp.gmail.com with ESMTPSA id
 y194sm1102446itb.34.2019.06.11.04.25.05
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Tue, 11 Jun 2019 04:25:05 -0700 (PDT)
In-Reply-To: <0D7CFFA0-FC7E-4D4E-A24C-4893776229B0@acm.org> ("Mattias
 \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Tue, 11 Jun 2019 13:12:26
 +0200")
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 209.51.188.43
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: "bug-gnu-emacs"
 <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.bugs:160357
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/160357>

Mattias Engdeg=C3=A5rd <mattiase@acm.org> writes:

> 10 juni 2019 kl. 17.38 skrev npostavs@gmail.com:
>>=20
>> Redefining eq, equal, memq, or member with defun or advice is already
>> unreliable because they are translated to byte codes.  eql and memql are
>> not, so this patchset (specifically, the last 2 patches, I think) would
>> make the situation a bit worse for those functions, in that it would
>> prevent defun/advice override for eql and memql from applying in cond
>> forms.
>
> `eql' is already recognised for switch generation in cond forms
> today.

Oh, I wasn't aware of that.  Somehow I had the impression it was only
for `eq'.

> More generally, is redefinition of such fundamental built-ins
> really a serious concern?

Not in my opinion, I just wanted to mention it for completeness.