Re: master 8a5a1be: * lisp/vc/vc.el (vc-log-search): Fix docstring (bug#36644).

Re: master 8a5a1be: * lisp/vc/vc.el (vc-log-search): Fix docstring (bug#36644).

[Robert Pluim]

>>>>> On Wed, 24 Jul 2019 19:21:35 -0400 (EDT), juri@jurta.org (Juri Linkov) said:

    Juri> branch: master
    Juri> commit 8a5a1bebfa95bf50ef390e4b101f1cfe8046d565
    Juri> Author: Juri Linkov <juri@linkov.net>
    Juri> Commit: Juri Linkov <juri@linkov.net>

    Juri>     * lisp/vc/vc.el (vc-log-search): Fix docstring (bug#36644).

Thanks Juri. Was there a consensus on the key-binding?

Robert

Re: [Emacs-diffs] master 8a5a1be: * lisp/vc/vc.el (vc-log-search): Fix docstring (bug#36644).

[Dmitry Gutov]

On 25.07.2019 2:21, Juri Linkov wrote:
>   (defun vc-git-log-search (buffer pattern)
> +  "Search the log of changes for PATTERN and output results into BUFFER.
> +
> +PATTERN is a basic regular expression by default in Git.

What does "by default" mean here?

> +Display all entries that match log messages in long format.
> +With a prefix argument, ask for a command to run that will output
> +log entries."

I think the last sentence is extraneous here.

Re: [Emacs-diffs] master 8a5a1be: * lisp/vc/vc.el (vc-log-search): Fix docstring (bug#36644).

[Dmitry Gutov]

Sorry, please disregard.

On 25.07.2019 13:43, Dmitry Gutov wrote:
> On 25.07.2019 2:21, Juri Linkov wrote:
>>   (defun vc-git-log-search (buffer pattern)
>> +  "Search the log of changes for PATTERN and output results into BUFFER.
>> +
>> +PATTERN is a basic regular expression by default in Git.
> 
> What does "by default" mean here?
> 
>> +Display all entries that match log messages in long format.
>> +With a prefix argument, ask for a command to run that will output
>> +log entries."
> 
> I think the last sentence is extraneous here.

Re: master 8a5a1be: * lisp/vc/vc.el (vc-log-search): Fix docstring (bug#36644).

[Juri Linkov]

> Thanks Juri. Was there a consensus on the key-binding?

I don't know, the latest proposal was to bind vc-log-search to
'C-x v S'.