From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: PATCH: isearch-yank-until-char Date: Wed, 14 Aug 2019 12:22:41 -0500 Message-ID: <87woff64ri.fsf@red-bean.com> References: <87tvakfnv4.fsf@red-bean.com> <835zmzsuau.fsf@gnu.org> <87d0h77l8d.fsf@red-bean.com> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="38104"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 14 19:23:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hxwzb-0009nN-Hv for ged-emacs-devel@m.gmane.org; Wed, 14 Aug 2019 19:23:23 +0200 Original-Received: from localhost ([::1]:34504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxwza-0003y9-HL for ged-emacs-devel@m.gmane.org; Wed, 14 Aug 2019 13:23:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33604) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxwz2-0003xf-CN for emacs-devel@gnu.org; Wed, 14 Aug 2019 13:22:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxwz0-0001pB-6m for emacs-devel@gnu.org; Wed, 14 Aug 2019 13:22:48 -0400 Original-Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]:43018) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hxwyy-0001nV-G4 for emacs-devel@gnu.org; Wed, 14 Aug 2019 13:22:45 -0400 Original-Received: by mail-ot1-x32d.google.com with SMTP id e12so39935429otp.10 for ; Wed, 14 Aug 2019 10:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version; bh=YSjC3pQA0mxovpiQzCPhYVuHvGxyZmCAWj3VCkclQHQ=; b=s+Bl5wq9cCFP/QbrGSKiXFE+LkAPtCgjD/P9IClo4PkgTF+i9rI1ABlYS5dX4wx/0K UAv+KJ/0lY8aQLMLCNjtp4expA1oI0/Nm+C3Jpfb8b3kH+bwP9aAMwRZRRJazK+ZEU6P 5KJVEp6OMBcleb+HkqGbnJACkZ3b9S2RLe0ZdmEvfCPKJwTVqbHeo/LarDK8+0V3d0lV KjSLBNS6IO57Usr8BauHxgM/Lkio+zL9iL24IunEUeW0+bimSPOo3EFU/YIpzdQtEZ8q ewiPpkaQVOc/G7QqMfOT6PtgXMnEZuSlPmOUR21UHVvdDN60dqsoKdHhaUax7ybw4O2+ vTsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:references:reply-to:date :in-reply-to:message-id:user-agent:mime-version; bh=YSjC3pQA0mxovpiQzCPhYVuHvGxyZmCAWj3VCkclQHQ=; b=ISywBHPYk3aWSkW0t/7jWYVOBuVLGqmC4rr+KX0xCiQey8cj5PM6C56SJpX6tm4rCQ iHstWzmeE01z9DZgrlYUj/f3JXrqaLyUKql+MduGN9Qd8hNcjl5dmv+9Jho4mUQFBtyy 60Ii3ZDVCTfQb/LYdwXGKI7jSrwpciGSoxxE8thYvbwozvMwh+h+Rba/eQMqT/w/3qOq oS6vnhVxVCUUISNaB0kP3J2QJUgSUHir1XU9YsbSmRqcA5ykjWND3rGfSpo8xwFrgycX PZcgVYF+X9C4j/0qSTyCJIHpCrrxdVVMh50ifZlHrkNvyNvq/MS7vLUOc8O8ylBbTQkc U4Qg== X-Gm-Message-State: APjAAAXAmoSG9U1+m70SuDw0pxjryM+ZhbiFSv41MvX2pFQWq7GqX/zs pEcOeXRfiKNkMpBtxZdfWAhSDylp X-Google-Smtp-Source: APXvYqyFasrr1UxjSQ50/biZoWXihSGSLSkXYGTrt/wxtVKI2x+p7RG2aTj1fpxCuoEkmxVYSIv1SA== X-Received: by 2002:a6b:4107:: with SMTP id n7mr1018858ioa.12.1565803362765; Wed, 14 Aug 2019 10:22:42 -0700 (PDT) Original-Received: from kwork (74-92-190-114-Illinois.hfc.comcastbusiness.net. [74.92.190.114]) by smtp.gmail.com with ESMTPSA id v13sm558192ioq.13.2019.08.14.10.22.42 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 14 Aug 2019 10:22:42 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Wed, 14 Aug 2019 09:48:03 -0700 (PDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239364 Archived-At: On 14 Aug 2019, Drew Adams wrote: >> >> this should be "Until char..." >> > >> > [nit] I thought our convention was to use title >> > case, in which case it would be "Until Char...". >> >> The other menu entries there don't seem to be doing >> title case in this way. > >Perhaps they should be fixed too, to be consistent >with the rest of Emacs? Perhaps, yes. However, then that should be a separate change, that fixes all the entries at once, including the new one (if any) for `isearch-yank-until-char'. For comparison: There's another similar situation going on with the entries in `isearch-menu-bar-yank-map'. Many of them say "on search string" when they should say "to search string". It's clearly a copy-and-paste error from the first entry, `isearch-yank-pop' (where the "on" is correct for reasons special to that function). I noticed the problem when I was making my patch, but my patch was not the place to fix it, since it's unrelated. I was just going to do a separate typo-fix commit later for this. Here's that code, so you don't have to dig it up: (defvar isearch-menu-bar-yank-map (let ((map (make-sparse-keymap))) (define-key map [isearch-yank-pop] '(menu-item "Previous kill" isearch-yank-pop :help "Replace previous yanked kill on search string")) (define-key map [isearch-yank-kill] '(menu-item "Current kill" isearch-yank-kill :help "Append current kill to search string")) (define-key map [isearch-yank-line] '(menu-item "Rest of line" isearch-yank-line :help "Yank the rest of the current line on search string")) (define-key map [isearch-yank-symbol-or-char] '(menu-item "Symbol/char" isearch-yank-symbol-or-char :help "Yank next symbol or char on search string")) (define-key map [isearch-yank-word-or-char] '(menu-item "Word/char" isearch-yank-word-or-char :help "Yank next word or char on search string")) (define-key map [isearch-yank-char] '(menu-item "Char" isearch-yank-char :help "Yank char at point on search string")) map))