Re: PATCH: isearch-yank-until-char

[Karl Fogel <kfogel@red-bean.com>]

On 14 Aug 2019, Drew Adams wrote:
>> >> this should be "Until char..."
>> >
>> > [nit] I thought our convention was to use title
>> > case, in which case it would be "Until Char...".
>> 
>> The other menu entries there don't seem to be doing
>> title case in this way.
>
>Perhaps they should be fixed too, to be consistent
>with the rest of Emacs?

Perhaps, yes.  However, then that should be a separate change, that fixes all the entries at once, including the new one (if any) for `isearch-yank-until-char'.

For comparison:

There's another similar situation going on with the entries in `isearch-menu-bar-yank-map'.  Many of them say "on search string" when they should say "to search string".  It's clearly a copy-and-paste error from the first entry, `isearch-yank-pop' (where the "on" is correct for reasons special to that function).  I noticed the problem when I was making my patch, but my patch was not the place to fix it, since it's unrelated.  I was just going to do a separate typo-fix commit later for this.  Here's that code, so you don't have to dig it up:

(defvar isearch-menu-bar-yank-map
  (let ((map (make-sparse-keymap)))
    (define-key map [isearch-yank-pop]
      '(menu-item "Previous kill" isearch-yank-pop
                  :help "Replace previous yanked kill on search string"))
    (define-key map [isearch-yank-kill]
      '(menu-item "Current kill" isearch-yank-kill
                  :help "Append current kill to search string"))
    (define-key map [isearch-yank-line]
      '(menu-item "Rest of line" isearch-yank-line
                  :help "Yank the rest of the current line on search string"))
    (define-key map [isearch-yank-symbol-or-char]
      '(menu-item "Symbol/char"
                  isearch-yank-symbol-or-char
                  :help "Yank next symbol or char on search string"))
    (define-key map [isearch-yank-word-or-char]
      '(menu-item "Word/char"
                  isearch-yank-word-or-char
                  :help "Yank next word or char on search string"))
    (define-key map [isearch-yank-char]
      '(menu-item "Char" isearch-yank-char
                  :help "Yank char at point on search string"))
    map))