From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#25559: Trouble getting battery status Date: Fri, 23 Aug 2019 02:41:47 +0200 Message-ID: <87wof4af1w.fsf@mouse.gnus.org> References: <86wpdgavo1.fsf@gmail.com> <878sskltsh.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="63008"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 25559@debbugs.gnu.org To: Rahul Martim Juliato Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 23 02:42:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0xee-000GHz-Qr for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 02:42:13 +0200 Original-Received: from localhost ([::1]:50668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0xed-0003Dq-L9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Aug 2019 20:42:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44585) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0xeV-00036p-JJ for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 20:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0xeU-0004Gw-HW for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 20:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58011) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0xeU-0004Gp-Ea for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 20:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i0xeU-0004Nj-AT for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 20:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 00:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25559-submit@debbugs.gnu.org id=B25559.156652091516814 (code B ref 25559); Fri, 23 Aug 2019 00:42:02 +0000 Original-Received: (at 25559) by debbugs.gnu.org; 23 Aug 2019 00:41:55 +0000 Original-Received: from localhost ([127.0.0.1]:38596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0xeN-0004N7-67 for submit@debbugs.gnu.org; Thu, 22 Aug 2019 20:41:55 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:36348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0xeL-0004My-C3 for 25559@debbugs.gnu.org; Thu, 22 Aug 2019 20:41:54 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0xeF-00021L-Mc; Fri, 23 Aug 2019 02:41:51 +0200 In-Reply-To: <878sskltsh.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Fri, 26 Jul 2019 17:06:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165615 Archived-At: Lars Ingebrigtsen writes: > It looks like it just looks for batteries named BATx: > > (defcustom battery-linux-sysfs-regexp "[bB][aA][tT][0-9]?$" > > That seems unnecessary -- surely we can just look into all the > directories there and see whether it looks like we have a battery > directory? The patch below does this, but perhaps it's problematic. Do > all power_supply/ directories have a "capacity" file, or does > that vary by Linux kernel version? There were no comments, and I've tested the patch on three different GNU/Linux systems, and it seems to work OK. But like I said, I'm not extremely confident about this change -- if this leads to problems, feel free to revert. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no