[Javascript] code for contextual behavior of < key

[Javascript] code for contextual behavior of < key

[Jorge Araya Navarro]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

Hello!
As an ex-user of rjsx-mode a current user of js-mode on Emacs 27.x I missed the contextual behavior of the < key where it would insert an empty tag (</>) when attempting to write JSX code and inserting a plain < character when you don't. The code was originally written by Felipe (@felipeochoa on Github) and what I did was essentially a copy and paste with added test cases:
repository: https://gitlab.com/shackra/colibri
This thing still misses another function for expanding a balanced tag when the user deletes the / character of a self-closing tag, I don't think that code is trivial and maybe I wouldn't be able to extract it from rjsx-mode as with the extracted code.
I was wondering:
- doing this copy and pasting in regards to js-jsx-electric-lt is somewhat a violation of Felipe copyright?- is this extraction missing something?- If the author of rjsx-mode is here, would you donate parts of your code to js.el so people can have a better experience when dealing with JSX?

[-- Attachment #2: Type: text/html, Size: 1661 bytes --]

Re: [Javascript] code for contextual behavior of < key

[Jorge Javier Araya Navarro]

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

Sorry, let me re-format my message:

Hello!

As an ex-user of rjsx-mode a current user of js-mode on Emacs 27.x I missed the contextual
behavior of the < key where it would insert an empty tag (</>) when attempting to write JSX code and
inserting a plain < character when you don't. The code was originally written by Felipe
(@felipeochoa on Github) and what I did was essentially a copy and paste with added test cases:

repository: https://gitlab.com/shackra/colibri

This thing still misses another function for expanding a balanced tag when the user deletes the /
character of a self-closing tag, I don't think that code is trivial and maybe I wouldn't be able to
extract it from rjsx-mode as with the extracted code.

I was wondering:

- doing this copy and pasting in regards to js-jsx-electric-lt is somewhat a violation of Felipe copyright?
- is this extraction missing something?
- If the author of rjsx-mode is here, would you donate parts of your code to js.el so people can have a better experience when dealing with JSX?

Whatever comes out of this experiment would be a contribution into Emacs and js.el itself

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [Javascript] code for contextual behavior of < key

[Eli Zaretskii]

> From: Jorge Javier Araya Navarro <jorgejavieran@yahoo.com.mx>
> Date: Fri, 13 Sep 2019 19:41:32 -0600
> 
> repository: https://gitlab.com/shackra/colibri
> 
> This thing still misses another function for expanding a balanced tag when the user deletes the /
> character of a self-closing tag, I don't think that code is trivial and maybe I wouldn't be able to
> extract it from rjsx-mode as with the extracted code.
> 
> I was wondering:
> 
> - doing this copy and pasting in regards to js-jsx-electric-lt is somewhat a violation of Felipe copyright?

The code is short enough to be admitted without any legal paperwork,
but the original author should explicitly agree to having his code
added to Emacs, we cannot use his code without a permission.

Thanks.

Re: [Javascript] code for contextual behavior of < key

[Jorge Javier Araya Navarro]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]



El sábado 14 de septiembre del 2019 a las 0123 horas, Eli Zaretskii escribió:

>> From: Jorge Javier Araya Navarro <jorgejavieran@yahoo.com.mx>
>> Date: Fri, 13 Sep 2019 19:41:32 -0600
>>
>> repository: https://gitlab.com/shackra/colibri
>>
>> This thing still misses another function for expanding a balanced tag when the user deletes the /
>> character of a self-closing tag, I don't think that code is trivial and maybe I wouldn't be able to
>> extract it from rjsx-mode as with the extracted code.
>>
>> I was wondering:
>>
>> - doing this copy and pasting in regards to js-jsx-electric-lt is somewhat a violation of Felipe copyright?
>
> The code is short enough to be admitted without any legal paperwork,
> but the original author should explicitly agree to having his code
> added to Emacs, we cannot use his code without a permission.
>
> Thanks.

Understood, Will try to reach to him and ask his permission

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [Javascript] code for contextual behavior of < key

[Jorge Araya Navarro]

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

 Okay, I'm back


according to Felipe, I can make use of the fragment of code (see re-using parts of rjsx-mode for js.el · Issue #118 · felipeochoa/rjsx-mode )


So, as soon has I have this together and functional will send a patch for js.el


| 
| 
| 
|  |  |

 |

 |
| 
|  | 
re-using parts of rjsx-mode for js.el · Issue #118 · felipeochoa/rjsx-mode

I'm currently using the built-in Javascript support that comes with Emacs 27.x, and I was missing the context-se...
 |

 |

 |




    El sábado, 14 de septiembre de 2019 10:33:06 GMT-6, Eli Zaretskii <eliz@gnu.org> escribió:  
 
 > From: Jorge Javier Araya Navarro <jorgejavieran@yahoo.com.mx>
> Date: Fri, 13 Sep 2019 19:41:32 -0600
> 
> repository: https://gitlab.com/shackra/colibri
> 
> This thing still misses another function for expanding a balanced tag when the user deletes the /
> character of a self-closing tag, I don't think that code is trivial and maybe I wouldn't be able to
> extract it from rjsx-mode as with the extracted code.
> 
> I was wondering:
> 
> - doing this copy and pasting in regards to js-jsx-electric-lt is somewhat a violation of Felipe copyright?

The code is short enough to be admitted without any legal paperwork,
but the original author should explicitly agree to having his code
added to Emacs, we cannot use his code without a permission.

Thanks.
  

[-- Attachment #2: Type: text/html, Size: 7736 bytes --]

Re: [Javascript] code for contextual behavior of < key

[Eli Zaretskii]

> Date: Wed, 18 Sep 2019 21:14:14 +0000 (UTC)
> From: Jorge Araya Navarro <jorgejavieran@yahoo.com.mx>
> Cc: Emacs Developers <emacs-devel@gnu.org>
> 
> Okay, I'm back
> 
> according to Felipe, I can make use of the fragment of code (see re-using parts of rjsx-mode for js.el · Issue
> #118 · felipeochoa/rjsx-mode )

Thanks, but we need that agreement sent By Felipe to this mailing
list, so that we could quote it in the commit log message.