From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Jorge Javier Araya Navarro Newsgroups: gmane.emacs.devel Subject: Re: [Javascript] code for contextual behavior of < key Date: Fri, 13 Sep 2019 19:41:32 -0600 Message-ID: <87woebirhv.fsf@yahoo.com.mx> References: <1620828980.1114868.1568416835445.ref@mail.yahoo.com> <1620828980.1114868.1568416835445@mail.yahoo.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="31694"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.3.4; emacs 27.0.50 To: "emacs-devel\@gnu.org" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 14 03:42:00 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i8x4Z-00085O-2U for ged-emacs-devel@m.gmane.org; Sat, 14 Sep 2019 03:41:59 +0200 Original-Received: from localhost ([::1]:48348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8x4X-0005Qe-Sp for ged-emacs-devel@m.gmane.org; Fri, 13 Sep 2019 21:41:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50226) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8x4P-0005QI-N4 for emacs-devel@gnu.org; Fri, 13 Sep 2019 21:41:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8x4O-00026M-3o for emacs-devel@gnu.org; Fri, 13 Sep 2019 21:41:49 -0400 Original-Received: from sonic312-22.consmr.mail.bf2.yahoo.com ([74.6.128.84]:45112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i8x4N-00022J-Mp for emacs-devel@gnu.org; Fri, 13 Sep 2019 21:41:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com.mx; s=s2048; t=1568425306; bh=r/zibUnRsSSzYCYvZLnmFGwl0XKj7GXifuSINhhbGas=; h=References:From:To:Subject:Date:From:Subject; b=PVstXo1FLyqhaXYkG/81KtdrD9PA6zRDT5QO6S73C8V6lYKJDkyR09MFsQNig5zXLZbi5CpqWfexST/aE2p6rvLzVGzpS1mpCL5Fq6lnXaXvWibtVCqQs/qLB7+ZC3cZ8WO86zk/Cps0inHEURaWjQVI5ocFSEYfHJYSKqd28t2CkU06FyHH5XGUPzlRdKjjauFLm5xWAcqGgPvq0nehDGlQ5L1QxEkxKsfWBg8JfZ1PvZjY1AxmNyOegolNbBjc8DhByywhIBRUeKAcgU8DYJ1TghhwcksPe6oiCQTAa+bRaQa/2ATOYhK5hKPDk/Y0DGK492FAX3vid5+5PaJ5Yw== X-YMail-OSG: EAkQokwVM1nm2f9zR4QW_AuHhfu7iLSE8rn1QAbEuQThqkWGPrTZDhND7hmqioc Lb7GzVzTLO0Twe9IzdlJijgbDgC5vYx4bOGJ9L.q1HSDGQGKCfyA7WjHJo.sSj6sLVSBU83Nr1Nu QLQZ2hB5vUtTqERIBSdj5nKQTS7oiZnn70y4YHyACgOo8W52ntfj17wNoszbDTFIFhjvy3W9a2ib HpFMmGMSGFtCyBlelGx5MlYmxq8Mt3FwW39O76uRJXhbYhpdBohkbpYKNCyKlYUbv6mbqxCpgytA bbCyBxeA10DePlz68bPpAPQ5rvwqN69RKU15n8gKr5hu_trhkZPAvNz5gGc7HKrtJNsqYFtyl2zJ OLOnzbc3cbA2yYcvdmH7ypioclBcU.if0VXXO.Vk26fwpe00YkutnI0RSPExCq7MCG_YviUDdXf8 3d.kql6APCcxEejiBjR9sAxR9PlzCf5S_T4dBVLP3yf8iKgGxzd0fjSUboIGxfoff6Tu_2hYVx9G 6Nf_MOeXaKYTS1ozMAY.DKUoLWbHqHkZStd5JbpT.88ItOCQ0_8QqN4_Yn8gtWIjVbeNh9O85Il4 oV9682ZeIHow4UGIwhOXLztaufF.AnjlHVit39PMYwn82QZZUozbXFCq8l8iC4vOUYqWeKf7L2mP vK.RQ5v3E07WaAd8aMH8M6H_8V298HTx0F51db9pRn3P_LURGtfQXdIAnQ8nilEv3znUq7ve2FDB Mrdv9CmMuspT1qB7ap6DAwx1Hh0Y7Y7UsrxzMCT2UrZGLzCStgtILWO.CKfjK9vH4IaccOJ_g1CP 8b4OtweYW9p9RYH43xwp.VNTnLfgubZ1AoEQxdyiJt Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.bf2.yahoo.com with HTTP; Sat, 14 Sep 2019 01:41:46 +0000 Original-Received: by smtp405.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 1d291d6b042b0202d986645b43ae45b4; Sat, 14 Sep 2019 01:41:42 +0000 (UTC) In-reply-to: <1620828980.1114868.1568416835445@mail.yahoo.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 74.6.128.84 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240022 Archived-At: --=-=-= Content-Type: text/plain Sorry, let me re-format my message: Hello! As an ex-user of rjsx-mode a current user of js-mode on Emacs 27.x I missed the contextual behavior of the < key where it would insert an empty tag () when attempting to write JSX code and inserting a plain < character when you don't. The code was originally written by Felipe (@felipeochoa on Github) and what I did was essentially a copy and paste with added test cases: repository: https://gitlab.com/shackra/colibri This thing still misses another function for expanding a balanced tag when the user deletes the / character of a self-closing tag, I don't think that code is trivial and maybe I wouldn't be able to extract it from rjsx-mode as with the extracted code. I was wondering: - doing this copy and pasting in regards to js-jsx-electric-lt is somewhat a violation of Felipe copyright? - is this extraction missing something? - If the author of rjsx-mode is here, would you donate parts of your code to js.el so people can have a better experience when dealing with JSX? Whatever comes out of this experiment would be a contribution into Emacs and js.el itself --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEORmQ/HnKp2aOAjuqtplkhLhPbZMFAl18RUwACgkQtplkhLhP bZNHOw//TQ8SqbJvh5FqrG6bUULrD9nLV/L2oXs357ahFhTciPQHtHBZsSeEbmU2 fsmohTsgU0lD6lmTzOpQNo2yzCvxhWKkrk+pN89lzE1+Jz5MEQu8MMClARL8Vw/l shjmK9QBHe9TsHWkdaHKI7TYyY3lf+vOYSSwmtNOkFQm4Bea5n5LmEXGaXiLmniF mX3NGevECfCOItulyN2OzbQZdzKLmGwoz5oziVo3Hvt0ZcZYYhMG5AX5eQasE2FK YeY361L/XAUVW+43GmjkoTh192pnjzxCSpzIHHPIsJduJrt82BnW2oLuRMicoWvm 3rokqlxpZsJ2mOrhbhDEiPQxryeHCT8hj3LLqxLTzTnzU2Ehw25FNdBfpGecRZdL sMl9UED9WbePnggMC+4mDHV5Q24TV4sexIfuodzO23Rne9qNZH2FrgVSnmTkYFFG x8kksyQ9kqm7rywlTES8SmkCezQOLWFqRh2N6/RnLQfyZodS1WwLR7r1iDNjm38N rWbY5n31pWi3USphGsKl9smnuTlWCK5vah7jOeq37ARnCOX/ac/uMpVvGRQpIlPG /171k/r9zcW5T+t1gy//P7MDDdWonQ/RWFO2zcJx4+GKS1BqyF5Oy/wVCjqLoXSE EKbBO9O/si7n9x0znVmkchGkYp+g105DFiAk3ZVxgXXbMkwGur4= =yzSR -----END PGP SIGNATURE----- --=-=-=--